All of lore.kernel.org
 help / color / mirror / Atom feed
* is it "IMAGE_INSTALL +=" or "IMAGE_INSTALL_append ="?
@ 2012-06-19 12:22 Robert P. J. Day
  2012-06-19 17:52 ` Paul Eggleton
  0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2012-06-19 12:22 UTC (permalink / raw)
  To: Yocto discussion list


  currently, the dev manual (Section 4.2.1) proposes the use of

  IMAGE_INSTALL += "strace"

but the poky ref manual in the variable glossary explicitly
discourages that form, and instead recommends

  IMAGE_INSTALL_append = " package-name"

  can we agree that the "_append" form is preferred?  thoughts?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: is it "IMAGE_INSTALL +=" or "IMAGE_INSTALL_append ="?
  2012-06-19 12:22 is it "IMAGE_INSTALL +=" or "IMAGE_INSTALL_append ="? Robert P. J. Day
@ 2012-06-19 17:52 ` Paul Eggleton
  2012-06-19 18:47   ` Chris Tapp
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Eggleton @ 2012-06-19 17:52 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: yocto

On Tuesday 19 June 2012 08:22:00 Robert P. J. Day wrote:
>   currently, the dev manual (Section 4.2.1) proposes the use of
> 
>   IMAGE_INSTALL += "strace"
> 
> but the poky ref manual in the variable glossary explicitly
> discourages that form, and instead recommends
> 
>   IMAGE_INSTALL_append = " package-name"
> 
>   can we agree that the "_append" form is preferred?  thoughts?

The reference manual is a little unclear on what "ordering issues" means. += 
works just fine, it's just that if you happen to use it at some point before 
core-image.bbclass line sets it with ?= (i.e. either in local.conf or before 
the "inherit core-image" line in your image recipe) the ?= line in core-
image.bbclass will do nothing and you'll end up with much less in the 
IMAGE_INSTALL list than you expected. If you use _append, you can have that 
anywhere you like and it will always work, with the caveat that if you forget 
to add a leading space in the value to be appended, things will break.

Note that the part of 4.2.1 in the dev manual you refer to is specifically 
talking about making a copy of an image recipe and putting the IMAGE_INSTALL 
+= at the end, which will always work and won't suffer from any leading space 
issues. I'm not sure what we should change to improve this...

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: is it "IMAGE_INSTALL +=" or "IMAGE_INSTALL_append ="?
  2012-06-19 17:52 ` Paul Eggleton
@ 2012-06-19 18:47   ` Chris Tapp
  2012-06-20  6:23     ` Tomas Frydrych
  0 siblings, 1 reply; 4+ messages in thread
From: Chris Tapp @ 2012-06-19 18:47 UTC (permalink / raw)
  To: Paul Eggleton; +Cc: yocto

On 19 Jun 2012, at 18:52, Paul Eggleton wrote:

> On Tuesday 19 June 2012 08:22:00 Robert P. J. Day wrote:
>>  currently, the dev manual (Section 4.2.1) proposes the use of
>> 
>>  IMAGE_INSTALL += "strace"
>> 
>> but the poky ref manual in the variable glossary explicitly
>> discourages that form, and instead recommends
>> 
>>  IMAGE_INSTALL_append = " package-name"
>> 
>>  can we agree that the "_append" form is preferred?  thoughts?
> 
> The reference manual is a little unclear on what "ordering issues" means. += 
> works just fine, it's just that if you happen to use it at some point before 
> core-image.bbclass line sets it with ?= (i.e. either in local.conf or before 
> the "inherit core-image" line in your image recipe) the ?= line in core-
> image.bbclass will do nothing and you'll end up with much less in the 
> IMAGE_INSTALL list than you expected. If you use _append, you can have that 
> anywhere you like and it will always work, with the caveat that if you forget 
> to add a leading space in the value to be appended, things will break.
> 
> Note that the part of 4.2.1 in the dev manual you refer to is specifically 
> talking about making a copy of an image recipe and putting the IMAGE_INSTALL 
> += at the end, which will always work and won't suffer from any leading space 
> issues. I'm not sure what we should change to improve this...

Is there a section that explains the order in which all these things happen? i.e. items in local.conf happen before/after...

Chris Tapp

opensource@keylevel.com
www.keylevel.com





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: is it "IMAGE_INSTALL +=" or "IMAGE_INSTALL_append ="?
  2012-06-19 18:47   ` Chris Tapp
@ 2012-06-20  6:23     ` Tomas Frydrych
  0 siblings, 0 replies; 4+ messages in thread
From: Tomas Frydrych @ 2012-06-20  6:23 UTC (permalink / raw)
  To: yocto

Hi,

On 19/06/12 19:47, Chris Tapp wrote:
> Is there a section that explains the order in which all these things
> happen? i.e. items in local.conf happen before/after...

IIRC, the evaluation orders is:

1. variables on the command line (e.g., 'MACHINE=beagleboard bitbake
myimage') are evaluated first,

2. variables in local.conf,

3. Rest depends on the order of things in bblayers.conf *and* how any
given layer.conf is implemented (some layers preppend their stuff to the
BBPATH and some layers append; from memory the Yocto layers prepend, but
layers from OE usually append, and this inconsistency makes for lot of
fun when combining layers into custom distro).

Tomas


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-06-20  6:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-19 12:22 is it "IMAGE_INSTALL +=" or "IMAGE_INSTALL_append ="? Robert P. J. Day
2012-06-19 17:52 ` Paul Eggleton
2012-06-19 18:47   ` Chris Tapp
2012-06-20  6:23     ` Tomas Frydrych

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.