From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY
Date: Fri, 22 Jun 2012 13:52:22 +0200 [thread overview]
Message-ID: <4FE45C76.3020508@suse.de> (raw)
In-Reply-To: <1340364659-20200-3-git-send-email-peter.maydell@linaro.org>
Am 22.06.2012 13:30, schrieb Peter Maydell:
> Remove an ifndef CONFIG_USER_ONLY guard that was pointless
> because it is already inside an if !defined(CONFIG_USER_ONLY).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> cpu-common.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/cpu-common.h b/cpu-common.h
> index 321037f..85548de 100644
> --- a/cpu-common.h
> +++ b/cpu-common.h
> @@ -69,9 +69,7 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
> void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
> void cpu_unregister_map_client(void *cookie);
>
> -#ifndef CONFIG_USER_ONLY
> bool cpu_physical_memory_is_io(target_phys_addr_t phys_addr);
> -#endif
>
> /* Coalesced MMIO regions are areas where write operations can be reordered.
> * This usually implies that write operations are side-effect free. This allows
Acked-by: Andreas Färber <afaerber@suse.de>
Spotted that yesterday myself and was planning to send a patch. :)
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/2] cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY
Date: Fri, 22 Jun 2012 13:52:22 +0200 [thread overview]
Message-ID: <4FE45C76.3020508@suse.de> (raw)
In-Reply-To: <1340364659-20200-3-git-send-email-peter.maydell@linaro.org>
Am 22.06.2012 13:30, schrieb Peter Maydell:
> Remove an ifndef CONFIG_USER_ONLY guard that was pointless
> because it is already inside an if !defined(CONFIG_USER_ONLY).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> cpu-common.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/cpu-common.h b/cpu-common.h
> index 321037f..85548de 100644
> --- a/cpu-common.h
> +++ b/cpu-common.h
> @@ -69,9 +69,7 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
> void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
> void cpu_unregister_map_client(void *cookie);
>
> -#ifndef CONFIG_USER_ONLY
> bool cpu_physical_memory_is_io(target_phys_addr_t phys_addr);
> -#endif
>
> /* Coalesced MMIO regions are areas where write operations can be reordered.
> * This usually implies that write operations are side-effect free. This allows
Acked-by: Andreas Färber <afaerber@suse.de>
Spotted that yesterday myself and was planning to send a patch. :)
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-06-22 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 11:30 [Qemu-trivial] [PATCH 0/2] cpu-common.h: remove pointless ifdef guards Peter Maydell
2012-06-22 11:30 ` [Qemu-devel] " Peter Maydell
2012-06-22 11:30 ` [Qemu-trivial] [PATCH 1/2] cpu-common.h: Remove unnecessary guard on including targphys.h Peter Maydell
2012-06-22 11:30 ` [Qemu-devel] " Peter Maydell
2012-06-22 11:54 ` [Qemu-trivial] " Andreas Färber
2012-06-22 11:54 ` Andreas Färber
2012-06-22 11:30 ` [Qemu-trivial] [PATCH 2/2] cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY Peter Maydell
2012-06-22 11:30 ` [Qemu-devel] " Peter Maydell
2012-06-22 11:52 ` Andreas Färber [this message]
2012-06-22 11:52 ` Andreas Färber
2012-07-02 9:10 ` [Qemu-trivial] [Qemu-devel] [PATCH 0/2] cpu-common.h: remove pointless ifdef guards Stefan Hajnoczi
2012-07-02 9:10 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE45C76.3020508@suse.de \
--to=afaerber@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.