* [Qemu-devel] [PATCH 0/2] cpu-common.h: remove pointless ifdef guards
@ 2012-06-22 11:30 ` Peter Maydell
0 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2012-06-22 11:30 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
These patches remove a couple of pointless ifdef guards in cpu-common.h
that I happened to notice.
Peter Maydell (2):
cpu-common.h: Remove unnecessary guard on including targphys.h
cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY
cpu-common.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-trivial] [PATCH 1/2] cpu-common.h: Remove unnecessary guard on including targphys.h
2012-06-22 11:30 ` [Qemu-devel] " Peter Maydell
@ 2012-06-22 11:30 ` Peter Maydell
-1 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2012-06-22 11:30 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
There's no need to make the include of targphys.h conditional
on whether TARGET_PHYS_ADDR_BITS is defined, because targphys.h
itself checks that and does nothing if it isn't.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
cpu-common.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/cpu-common.h b/cpu-common.h
index 1fe3280..321037f 100644
--- a/cpu-common.h
+++ b/cpu-common.h
@@ -3,9 +3,7 @@
/* CPU interfaces that are target independent. */
-#ifdef TARGET_PHYS_ADDR_BITS
#include "targphys.h"
-#endif
#ifndef NEED_CPU_H
#include "poison.h"
--
1.7.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH 1/2] cpu-common.h: Remove unnecessary guard on including targphys.h
@ 2012-06-22 11:30 ` Peter Maydell
0 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2012-06-22 11:30 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
There's no need to make the include of targphys.h conditional
on whether TARGET_PHYS_ADDR_BITS is defined, because targphys.h
itself checks that and does nothing if it isn't.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
cpu-common.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/cpu-common.h b/cpu-common.h
index 1fe3280..321037f 100644
--- a/cpu-common.h
+++ b/cpu-common.h
@@ -3,9 +3,7 @@
/* CPU interfaces that are target independent. */
-#ifdef TARGET_PHYS_ADDR_BITS
#include "targphys.h"
-#endif
#ifndef NEED_CPU_H
#include "poison.h"
--
1.7.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] cpu-common.h: Remove unnecessary guard on including targphys.h
2012-06-22 11:30 ` [Qemu-devel] " Peter Maydell
@ 2012-06-22 11:54 ` Andreas Färber
-1 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2012-06-22 11:54 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
Am 22.06.2012 13:30, schrieb Peter Maydell:
> There's no need to make the include of targphys.h conditional
> on whether TARGET_PHYS_ADDR_BITS is defined, because targphys.h
> itself checks that and does nothing if it isn't.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] cpu-common.h: Remove unnecessary guard on including targphys.h
@ 2012-06-22 11:54 ` Andreas Färber
0 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2012-06-22 11:54 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
Am 22.06.2012 13:30, schrieb Peter Maydell:
> There's no need to make the include of targphys.h conditional
> on whether TARGET_PHYS_ADDR_BITS is defined, because targphys.h
> itself checks that and does nothing if it isn't.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-trivial] [PATCH 2/2] cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY
2012-06-22 11:30 ` [Qemu-devel] " Peter Maydell
@ 2012-06-22 11:30 ` Peter Maydell
-1 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2012-06-22 11:30 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
Remove an ifndef CONFIG_USER_ONLY guard that was pointless
because it is already inside an if !defined(CONFIG_USER_ONLY).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
cpu-common.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/cpu-common.h b/cpu-common.h
index 321037f..85548de 100644
--- a/cpu-common.h
+++ b/cpu-common.h
@@ -69,9 +69,7 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
void cpu_unregister_map_client(void *cookie);
-#ifndef CONFIG_USER_ONLY
bool cpu_physical_memory_is_io(target_phys_addr_t phys_addr);
-#endif
/* Coalesced MMIO regions are areas where write operations can be reordered.
* This usually implies that write operations are side-effect free. This allows
--
1.7.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH 2/2] cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY
@ 2012-06-22 11:30 ` Peter Maydell
0 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2012-06-22 11:30 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
Remove an ifndef CONFIG_USER_ONLY guard that was pointless
because it is already inside an if !defined(CONFIG_USER_ONLY).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
cpu-common.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/cpu-common.h b/cpu-common.h
index 321037f..85548de 100644
--- a/cpu-common.h
+++ b/cpu-common.h
@@ -69,9 +69,7 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
void cpu_unregister_map_client(void *cookie);
-#ifndef CONFIG_USER_ONLY
bool cpu_physical_memory_is_io(target_phys_addr_t phys_addr);
-#endif
/* Coalesced MMIO regions are areas where write operations can be reordered.
* This usually implies that write operations are side-effect free. This allows
--
1.7.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY
2012-06-22 11:30 ` [Qemu-devel] " Peter Maydell
@ 2012-06-22 11:52 ` Andreas Färber
-1 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2012-06-22 11:52 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
Am 22.06.2012 13:30, schrieb Peter Maydell:
> Remove an ifndef CONFIG_USER_ONLY guard that was pointless
> because it is already inside an if !defined(CONFIG_USER_ONLY).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> cpu-common.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/cpu-common.h b/cpu-common.h
> index 321037f..85548de 100644
> --- a/cpu-common.h
> +++ b/cpu-common.h
> @@ -69,9 +69,7 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
> void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
> void cpu_unregister_map_client(void *cookie);
>
> -#ifndef CONFIG_USER_ONLY
> bool cpu_physical_memory_is_io(target_phys_addr_t phys_addr);
> -#endif
>
> /* Coalesced MMIO regions are areas where write operations can be reordered.
> * This usually implies that write operations are side-effect free. This allows
Acked-by: Andreas Färber <afaerber@suse.de>
Spotted that yesterday myself and was planning to send a patch. :)
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY
@ 2012-06-22 11:52 ` Andreas Färber
0 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2012-06-22 11:52 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
Am 22.06.2012 13:30, schrieb Peter Maydell:
> Remove an ifndef CONFIG_USER_ONLY guard that was pointless
> because it is already inside an if !defined(CONFIG_USER_ONLY).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> cpu-common.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/cpu-common.h b/cpu-common.h
> index 321037f..85548de 100644
> --- a/cpu-common.h
> +++ b/cpu-common.h
> @@ -69,9 +69,7 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
> void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
> void cpu_unregister_map_client(void *cookie);
>
> -#ifndef CONFIG_USER_ONLY
> bool cpu_physical_memory_is_io(target_phys_addr_t phys_addr);
> -#endif
>
> /* Coalesced MMIO regions are areas where write operations can be reordered.
> * This usually implies that write operations are side-effect free. This allows
Acked-by: Andreas Färber <afaerber@suse.de>
Spotted that yesterday myself and was planning to send a patch. :)
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/2] cpu-common.h: remove pointless ifdef guards
2012-06-22 11:30 ` [Qemu-devel] " Peter Maydell
@ 2012-07-02 9:10 ` Stefan Hajnoczi
-1 siblings, 0 replies; 12+ messages in thread
From: Stefan Hajnoczi @ 2012-07-02 9:10 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On Fri, Jun 22, 2012 at 12:30:57PM +0100, Peter Maydell wrote:
> These patches remove a couple of pointless ifdef guards in cpu-common.h
> that I happened to notice.
>
> Peter Maydell (2):
> cpu-common.h: Remove unnecessary guard on including targphys.h
> cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY
>
> cpu-common.h | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
>
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 12+ messages in thread