From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 14/14] usb: chipidea: add imx platform driver
Date: Mon, 25 Jun 2012 12:33:58 +0200 [thread overview]
Message-ID: <4FE83E96.5090004@pengutronix.de> (raw)
In-Reply-To: <1340607391-16380-15-git-send-email-richard.zhao@freescale.com>
On 06/25/2012 08:56 AM, Richard Zhao wrote:
> This patch supports only the host-mode functionality so far.
>
> Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Peter Chen <peter.chen@freescale.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Tested-by: Subodh Nijsure <snijsure@grid-net.com>
> ---
> .../devicetree/bindings/usb/ci13xxx-imx.txt | 20 ++
> drivers/usb/chipidea/Makefile | 3 +
> drivers/usb/chipidea/ci13xxx_imx.c | 197 ++++++++++++++++++++
> 3 files changed, 220 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
> create mode 100644 drivers/usb/chipidea/ci13xxx_imx.c
>
> diff --git a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
> new file mode 100644
> index 0000000..8bcd071
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
> @@ -0,0 +1,20 @@
> +* Freescale i.MX ci13xxx usb controllers
> +
> +Required properties:
> +- compatible: Should be "fsl,imx27-usb"
> +- reg: Should contain registers location and length
> +- interrupts: Should contain controller interrupt
> +
> +Optional properties:
> +- fsl,usbphy: phandler of usb phy that connects to the only one port
> +- fsl,hub-reset-gpios: gpio used to reset on-board usb hub
> +- fsl,vbus-power-gpios: gpio used to set vbus power of the only one port
These two properties are not implemented, are they?
vbus is handled via a fixed regulator.
Further I'm looking into the phy and otg implementation. I think the
handling of the regulator should go into mxs-phy.c, not into the
ci13xxx_imx.c
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120625/03d7b5c4/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Richard Zhao <richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
marex-ynQEQJNshbs@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH v7 14/14] usb: chipidea: add imx platform driver
Date: Mon, 25 Jun 2012 12:33:58 +0200 [thread overview]
Message-ID: <4FE83E96.5090004@pengutronix.de> (raw)
In-Reply-To: <1340607391-16380-15-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2328 bytes --]
On 06/25/2012 08:56 AM, Richard Zhao wrote:
> This patch supports only the host-mode functionality so far.
>
> Signed-off-by: Richard Zhao <richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> Cc: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> Cc: Alexander Shishkin <alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
> Tested-by: Subodh Nijsure <snijsure-4jo+YWezP1RWk0Htik3J/w@public.gmane.org>
> ---
> .../devicetree/bindings/usb/ci13xxx-imx.txt | 20 ++
> drivers/usb/chipidea/Makefile | 3 +
> drivers/usb/chipidea/ci13xxx_imx.c | 197 ++++++++++++++++++++
> 3 files changed, 220 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
> create mode 100644 drivers/usb/chipidea/ci13xxx_imx.c
>
> diff --git a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
> new file mode 100644
> index 0000000..8bcd071
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
> @@ -0,0 +1,20 @@
> +* Freescale i.MX ci13xxx usb controllers
> +
> +Required properties:
> +- compatible: Should be "fsl,imx27-usb"
> +- reg: Should contain registers location and length
> +- interrupts: Should contain controller interrupt
> +
> +Optional properties:
> +- fsl,usbphy: phandler of usb phy that connects to the only one port
> +- fsl,hub-reset-gpios: gpio used to reset on-board usb hub
> +- fsl,vbus-power-gpios: gpio used to set vbus power of the only one port
These two properties are not implemented, are they?
vbus is handled via a fixed regulator.
Further I'm looking into the phy and otg implementation. I think the
handling of the regulator should go into mxs-phy.c, not into the
ci13xxx_imx.c
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-06-25 10:33 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 6:56 [PATCH v7 00/14] add imx usb driver based on Greg next tree Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-25 6:56 ` [PATCH v7 01/14] usb: chipidea: remove unneeded NULL check Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-26 21:43 ` Greg KH
2012-06-26 21:43 ` Greg KH
2012-06-27 6:24 ` Richard Zhao
2012-06-27 6:24 ` Richard Zhao
2012-06-26 21:51 ` Marek Vasut
2012-06-26 21:51 ` Marek Vasut
2012-06-25 6:56 ` [PATCH v7 02/14] usb: chipidea: drop useless arch-check Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-26 21:52 ` Marek Vasut
2012-06-26 21:52 ` Marek Vasut
2012-06-25 6:56 ` [PATCH v7 03/14] usb: chipidea: msm: add missing section annotation Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-26 21:52 ` Marek Vasut
2012-06-26 21:52 ` Marek Vasut
2012-06-25 6:56 ` [PATCH v7 04/14] usb: chipidea: msm: add remove method Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-25 13:18 ` ABRAHAM, KISHON VIJAY
2012-06-25 13:18 ` ABRAHAM, KISHON VIJAY
2012-06-25 13:33 ` Marek Vasut
2012-06-25 13:33 ` Marek Vasut
2012-06-25 13:44 ` ABRAHAM, KISHON VIJAY
2012-06-25 13:44 ` ABRAHAM, KISHON VIJAY
2012-06-25 13:55 ` Marek Vasut
2012-06-25 13:55 ` Marek Vasut
2012-06-25 14:14 ` Felipe Balbi
2012-06-25 14:14 ` Felipe Balbi
2012-06-25 14:20 ` Marek Vasut
2012-06-25 14:20 ` Marek Vasut
2012-06-25 6:56 ` [PATCH v7 05/14] USB: Chipidea: rename struct ci13xxx_udc_driver to struct ci13xxx_platform_data Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-26 21:54 ` Marek Vasut
2012-06-26 21:54 ` Marek Vasut
2012-06-27 6:30 ` Richard Zhao
2012-06-27 6:30 ` Richard Zhao
2012-06-25 6:56 ` [PATCH v7 06/14] USB: Chipidea: rename struct ci13xxx variables from udc to ci Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-26 21:55 ` Marek Vasut
2012-06-26 21:55 ` Marek Vasut
2012-06-27 12:42 ` Marc Kleine-Budde
2012-06-27 12:42 ` Marc Kleine-Budde
2012-06-28 1:59 ` Richard Zhao
2012-06-28 1:59 ` Richard Zhao
2012-06-25 6:56 ` [PATCH v7 07/14] USB: Chipidea: add unified ci13xxx_{add, remove}_device for platform drivers Richard Zhao
2012-06-25 6:56 ` [PATCH v7 07/14] USB: Chipidea: add unified ci13xxx_{add,remove}_device " Richard Zhao
2012-06-25 6:56 ` [PATCH v7 08/14] USB: Chipidea: add ci13xxx device id management Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-25 9:48 ` Marc Kleine-Budde
2012-06-25 9:48 ` Marc Kleine-Budde
2012-06-25 10:03 ` Richard Zhao
2012-06-25 10:03 ` Richard Zhao
2012-06-25 10:17 ` Marc Kleine-Budde
2012-06-25 10:17 ` Marc Kleine-Budde
2012-06-27 5:42 ` Richard Zhao
2012-06-27 5:42 ` Richard Zhao
2012-06-27 11:49 ` Marek Vasut
2012-06-27 11:49 ` Marek Vasut
2012-06-27 12:02 ` Marc Kleine-Budde
2012-06-27 12:02 ` Marc Kleine-Budde
2012-06-25 6:56 ` [PATCH v7 09/14] usb: chipidea: select USB_EHCI_ROOT_HUB_TT in USB_CHIPIDEA_HOST of Kconfig Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-26 21:58 ` Marek Vasut
2012-06-26 21:58 ` Marek Vasut
2012-06-25 6:56 ` [PATCH v7 10/14] usb: otg: add notify_connect/notify_disconnect callback Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-25 6:56 ` [PATCH v7 11/14] USB: notify phy when root hub port connect change Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-25 6:56 ` [PATCH v7 12/14] usb: chipidea: permit driver bindings pass phy pointer Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-25 6:56 ` [PATCH v7 13/14] usb: otg: add basic mxs phy driver support Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-27 6:37 ` Richard Zhao
2012-06-27 6:37 ` Richard Zhao
2012-06-25 6:56 ` [PATCH v7 14/14] usb: chipidea: add imx platform driver Richard Zhao
2012-06-25 6:56 ` Richard Zhao
2012-06-25 10:33 ` Marc Kleine-Budde [this message]
2012-06-25 10:33 ` Marc Kleine-Budde
2012-06-27 6:20 ` Richard Zhao
2012-06-27 6:20 ` Richard Zhao
2012-06-27 9:46 ` Marc Kleine-Budde
2012-06-27 9:46 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE83E96.5090004@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.