All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH 2/3] zsmalloc: add generic path and remove x86 dependency
Date: Thu, 28 Jun 2012 09:20:36 +0900	[thread overview]
Message-ID: <4FEBA354.9030609@kernel.org> (raw)
In-Reply-To: <4FEB5A7E.8040500@linux.vnet.ibm.com>

On 06/28/2012 04:09 AM, Seth Jennings wrote:

> On 06/27/2012 12:28 AM, Minchan Kim wrote:
>>> +{
>>> +	if (area->vm)
>>> +		return 0;
>>
>>
>> Just out of curiosity.
>> When do we need above check?
> 
> I did this in the case that there was a race between the for
> loop in zs_init(), calling zs_cpu_notifier(), and a CPU
> coming online.  I've never seen the condition hit, but if it
> did, it would leak memory without this check.
> 


Could you add this as a comment?



> I would move the cpu notifier registration after the loop in
> zs_init(), but then I could miss a cpu up event and we
> wouldn't have the needed per-cpu resources for mapping.
> 
> All other suggestions are accepted.  Thanks for the feedback!
> 



Thanks!

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH 2/3] zsmalloc: add generic path and remove x86 dependency
Date: Thu, 28 Jun 2012 09:20:36 +0900	[thread overview]
Message-ID: <4FEBA354.9030609@kernel.org> (raw)
In-Reply-To: <4FEB5A7E.8040500@linux.vnet.ibm.com>

On 06/28/2012 04:09 AM, Seth Jennings wrote:

> On 06/27/2012 12:28 AM, Minchan Kim wrote:
>>> +{
>>> +	if (area->vm)
>>> +		return 0;
>>
>>
>> Just out of curiosity.
>> When do we need above check?
> 
> I did this in the case that there was a race between the for
> loop in zs_init(), calling zs_cpu_notifier(), and a CPU
> coming online.  I've never seen the condition hit, but if it
> did, it would leak memory without this check.
> 


Could you add this as a comment?



> I would move the cpu notifier registration after the loop in
> zs_init(), but then I could miss a cpu up event and we
> wouldn't have the needed per-cpu resources for mapping.
> 
> All other suggestions are accepted.  Thanks for the feedback!
> 



Thanks!

-- 
Kind regards,
Minchan Kim

  reply	other threads:[~2012-06-28  0:20 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 16:14 [PATCH 0/3] zsmalloc: remove x86 dependency Seth Jennings
2012-06-25 16:14 ` Seth Jennings
2012-06-25 16:14 ` [PATCH 1/3] zram/zcache: swtich Kconfig dependency from X86 to ZSMALLOC Seth Jennings
2012-06-25 16:14   ` Seth Jennings
2012-06-27  2:37   ` Minchan Kim
2012-06-27  2:37     ` Minchan Kim
2012-06-27  2:43     ` Greg Kroah-Hartman
2012-06-27  2:43       ` Greg Kroah-Hartman
2012-06-27  2:49       ` Minchan Kim
2012-06-27  2:49         ` Minchan Kim
2012-06-27  3:21         ` Greg Kroah-Hartman
2012-06-27  3:21           ` Greg Kroah-Hartman
2012-06-27 15:40           ` Konrad Rzeszutek Wilk
2012-06-27 15:40             ` Konrad Rzeszutek Wilk
2012-06-27 18:55             ` Greg Kroah-Hartman
2012-06-27 18:55               ` Greg Kroah-Hartman
2012-06-27 18:52               ` Konrad Rzeszutek Wilk
2012-06-27 18:52                 ` Konrad Rzeszutek Wilk
2012-06-27 19:29                 ` Greg Kroah-Hartman
2012-06-27 19:29                   ` Greg Kroah-Hartman
2012-06-25 16:14 ` [PATCH 2/3] zsmalloc: add generic path and remove x86 dependency Seth Jennings
2012-06-25 16:14   ` Seth Jennings
2012-06-25 16:59   ` Greg Kroah-Hartman
2012-06-25 16:59     ` Greg Kroah-Hartman
2012-06-25 17:10     ` Seth Jennings
2012-06-25 17:10       ` Seth Jennings
2012-06-25 17:19       ` Greg Kroah-Hartman
2012-06-25 17:19         ` Greg Kroah-Hartman
2012-06-25 18:24         ` Seth Jennings
2012-06-25 18:24           ` Seth Jennings
2012-06-25 23:37           ` Greg Kroah-Hartman
2012-06-25 23:37             ` Greg Kroah-Hartman
2012-06-27  5:28   ` Minchan Kim
2012-06-27  5:28     ` Minchan Kim
2012-06-27 19:09     ` Seth Jennings
2012-06-27 19:09       ` Seth Jennings
2012-06-28  0:20       ` Minchan Kim [this message]
2012-06-28  0:20         ` Minchan Kim
2012-06-25 16:14 ` [PATCH 3/3] x86: add local_tlb_flush_kernel_range() Seth Jennings
2012-06-25 16:14   ` Seth Jennings
2012-06-25 23:01   ` Konrad Rzeszutek Wilk
2012-06-25 23:01     ` Konrad Rzeszutek Wilk
2012-06-26 13:39     ` Seth Jennings
2012-06-26 13:39       ` Seth Jennings
2012-06-27  5:53   ` Minchan Kim
2012-06-27  5:53     ` Minchan Kim
2012-06-27  6:14     ` Alex Shi
2012-06-27  6:14       ` Alex Shi
2012-06-27  6:26       ` Minchan Kim
2012-06-27  6:26         ` Minchan Kim
2012-06-27 15:12         ` Dan Magenheimer
2012-06-27 15:12           ` Dan Magenheimer
2012-06-27 15:39           ` Konrad Rzeszutek Wilk
2012-06-27 15:39             ` Konrad Rzeszutek Wilk
2012-06-27 18:35             ` Seth Jennings
2012-06-27 18:35               ` Seth Jennings
2012-06-27 18:33           ` Seth Jennings
2012-06-27 18:33             ` Seth Jennings
2012-06-27 21:15             ` Dan Magenheimer
2012-06-27 21:15               ` Dan Magenheimer
2012-06-27 21:41               ` Seth Jennings
2012-06-27 21:41                 ` Seth Jennings
2012-06-28  2:03             ` Alex Shi
2012-06-28  2:03               ` Alex Shi
2012-06-28 15:21               ` Seth Jennings
2012-06-28 15:21                 ` Seth Jennings
2012-06-29  0:19                 ` Alex Shi
2012-06-29  0:19                   ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEBA354.9030609@kernel.org \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.