[U-Boot] arm, kirkwood: KWGBE_PORT_SERIAL_CONTROL1_REG define correct?

[U-Boot] arm, kirkwood: KWGBE_PORT_SERIAL_CONTROL1_REG define correct?

[Heiko Schocher]

Hello Prafulla,

I see in current mainline code:

arch/arm/include/asm/arch-kirkwood/cpu.h

35 #define KWGBE_PORT_SERIAL_CONTROL1_REG(_x)      \
36                 ((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c)

with results in:

if _x = 0 KW_EGIGA1_BASE and if _x = 1 KW_EGIGA0_BASE
         ^         ^                  ^         ^

is selected ... is this correct? I read _x as port and so this define
swaps the base addresses, or do I miss something?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] arm, kirkwood: KWGBE_PORT_SERIAL_CONTROL1_REG define correct?

[Prafulla Wadaskar]

> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de]
> Sent: 03 July 2012 14:41
> To: Prafulla Wadaskar
> Cc: U-Boot user list; Brunck, Holger
> Subject: arm, kirkwood: KWGBE_PORT_SERIAL_CONTROL1_REG define correct?
> 
> Hello Prafulla,
> 
> I see in current mainline code:
> 
> arch/arm/include/asm/arch-kirkwood/cpu.h
> 
> 35 #define KWGBE_PORT_SERIAL_CONTROL1_REG(_x)      \
> 36                 ((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c)
> 
> with results in:
> 
> if _x = 0 KW_EGIGA1_BASE and if _x = 1 KW_EGIGA0_BASE
>          ^         ^                  ^         ^
> 
> is selected ... is this correct? I read _x as port and so this define
> swaps the base addresses, or do I miss something?

Hi Heiko

There is a patch for this which I have acked, may be Joe(copied) can pull it.

Ref: http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/133960

Regards...
Prafulla . . .