From: Rajendra Nayak <rnayak@ti.com>
To: "ABRAHAM, KISHON VIJAY" <kishon@ti.com>
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"rob@landley.net" <rob@landley.net>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"b-cousson@ti.com" <b-cousson@ti.com>,
"tony@atomide.com" <tony@atomide.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"balbi@ti.com" <balbi@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"hvaibhav@ti.com" <hvaibhav@ti.com>
Subject: Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy
Date: Tue, 10 Jul 2012 12:35:35 +0530 [thread overview]
Message-ID: <4FFBD43F.4010704@ti.com> (raw)
In-Reply-To: <CAAe_U6Kx8o6sHgpev3UEAou7tuNDt9iL0+hcyOVDb0WsCsSwKg@mail.gmail.com>
On Tuesday 10 July 2012 12:18 PM, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Tue, Jul 10, 2012 at 11:33 AM, Venu Byravarasu
> <vbyravarasu@nvidia.com> wrote:
>>>> +
>>>> +#ifdef CONFIG_PM
>>
>> Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM?
>
> Why? I think we should have CONFIG_PM_SLEEP only when we have
> *suspend*, *resume* hooks. But this driver has only *runtime_suspend*
> and *runtime_resume* hooks.
CONFIG_PM_RUNTIME maybe then?
WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy
Date: Tue, 10 Jul 2012 12:35:35 +0530 [thread overview]
Message-ID: <4FFBD43F.4010704@ti.com> (raw)
In-Reply-To: <CAAe_U6Kx8o6sHgpev3UEAou7tuNDt9iL0+hcyOVDb0WsCsSwKg@mail.gmail.com>
On Tuesday 10 July 2012 12:18 PM, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Tue, Jul 10, 2012 at 11:33 AM, Venu Byravarasu
> <vbyravarasu@nvidia.com> wrote:
>>>> +
>>>> +#ifdef CONFIG_PM
>>
>> Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM?
>
> Why? I think we should have CONFIG_PM_SLEEP only when we have
> *suspend*, *resume* hooks. But this driver has only *runtime_suspend*
> and *runtime_resume* hooks.
CONFIG_PM_RUNTIME maybe then?
next prev parent reply other threads:[~2012-07-10 7:05 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 11:50 [PATCH v1 00/11] omap: musb: Add device tree support Kishon Vijay Abraham I
2012-06-28 11:50 ` Kishon Vijay Abraham I
2012-06-28 11:50 ` Kishon Vijay Abraham I
2012-06-28 11:50 ` [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy Kishon Vijay Abraham I
2012-06-28 11:50 ` Kishon Vijay Abraham I
2012-06-28 11:50 ` Kishon Vijay Abraham I
2012-07-10 5:46 ` Rajendra Nayak
2012-07-10 5:46 ` Rajendra Nayak
2012-07-10 6:03 ` Venu Byravarasu
2012-07-10 6:03 ` Venu Byravarasu
[not found] ` <D958900912E20642BCBC71664EFECE3E6DDAD9FF96-QZ+emBqkIFBDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-07-10 6:48 ` ABRAHAM, KISHON VIJAY
2012-07-10 6:48 ` ABRAHAM, KISHON VIJAY
2012-07-10 6:48 ` ABRAHAM, KISHON VIJAY
2012-07-10 7:05 ` Rajendra Nayak [this message]
2012-07-10 7:05 ` Rajendra Nayak
2012-07-10 7:05 ` Venu Byravarasu
2012-07-10 7:05 ` Venu Byravarasu
[not found] ` <4FFBC1D0.5030506-l0cyMroinI0@public.gmane.org>
2012-07-10 6:37 ` ABRAHAM, KISHON VIJAY
2012-07-10 6:37 ` ABRAHAM, KISHON VIJAY
2012-07-10 6:37 ` ABRAHAM, KISHON VIJAY
[not found] ` <CAAe_U6L9qiBMXWeS2POeBod8uASCtmqDc4DigwBx1bJ-hhaNRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-10 6:49 ` Rajendra Nayak
2012-07-10 6:49 ` Rajendra Nayak
2012-07-10 6:49 ` Rajendra Nayak
2012-06-28 11:50 ` [PATCH v1 02/11] arm/dts: omap: Add omap-usb2 dt data Kishon Vijay Abraham I
2012-06-28 11:50 ` Kishon Vijay Abraham I
2012-06-28 11:50 ` Kishon Vijay Abraham I
2012-06-28 11:50 ` [PATCH v1 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2 Kishon Vijay Abraham I
2012-06-28 11:50 ` Kishon Vijay Abraham I
2012-06-28 11:50 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` [PATCH v1 04/11] arm: omap: hwmod: add a new addr space in otg for writing to control module Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
[not found] ` <1340884267-28908-6-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2012-07-10 5:58 ` Rajendra Nayak
2012-07-10 5:58 ` Rajendra Nayak
2012-07-10 5:58 ` Rajendra Nayak
2012-07-10 6:28 ` ABRAHAM, KISHON VIJAY
2012-07-10 6:28 ` ABRAHAM, KISHON VIJAY
2012-07-10 6:44 ` Rajendra Nayak
2012-07-10 6:44 ` Rajendra Nayak
[not found] ` <4FFBCF45.7000304-l0cyMroinI0@public.gmane.org>
2012-07-10 8:18 ` ABRAHAM, KISHON VIJAY
2012-07-10 8:18 ` ABRAHAM, KISHON VIJAY
2012-07-10 8:18 ` ABRAHAM, KISHON VIJAY
2012-06-28 11:51 ` [PATCH v1 06/11] arm/dts: Add twl6030-usb data Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-07-10 6:02 ` Rajendra Nayak
2012-07-10 6:02 ` Rajendra Nayak
2012-07-10 6:52 ` ABRAHAM, KISHON VIJAY
2012-07-10 6:52 ` ABRAHAM, KISHON VIJAY
2012-07-10 7:02 ` Rajendra Nayak
2012-07-10 7:02 ` Rajendra Nayak
2012-06-28 11:51 ` [PATCH v1 08/11] arm/dts: Add twl4030-usb data Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-07-10 6:13 ` Rajendra Nayak
2012-07-10 6:13 ` Rajendra Nayak
2012-07-10 6:55 ` ABRAHAM, KISHON VIJAY
2012-07-10 6:55 ` ABRAHAM, KISHON VIJAY
2012-06-28 11:51 ` [PATCH v1 09/11] drivers: usb: musb: Add device tree support for omap musb glue Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-07-10 7:14 ` Gupta, Ajay Kumar
2012-07-10 7:14 ` Gupta, Ajay Kumar
2012-06-28 11:51 ` [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
[not found] ` <1340884267-28908-11-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2012-07-10 6:27 ` Rajendra Nayak
2012-07-10 6:27 ` Rajendra Nayak
2012-07-10 6:27 ` Rajendra Nayak
2012-07-10 8:13 ` ABRAHAM, KISHON VIJAY
2012-07-10 8:13 ` ABRAHAM, KISHON VIJAY
2012-07-10 8:13 ` ABRAHAM, KISHON VIJAY
2012-07-10 8:32 ` Rajendra Nayak
2012-07-10 8:32 ` Rajendra Nayak
2012-06-28 11:51 ` [PATCH v1 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-06-28 11:51 ` Kishon Vijay Abraham I
2012-07-10 6:29 ` Rajendra Nayak
2012-07-10 6:29 ` Rajendra Nayak
2012-07-10 8:16 ` ABRAHAM, KISHON VIJAY
2012-07-10 8:16 ` ABRAHAM, KISHON VIJAY
2012-07-10 8:33 ` Rajendra Nayak
2012-07-10 8:33 ` Rajendra Nayak
2012-07-10 8:33 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFBD43F.4010704@ti.com \
--to=rnayak@ti.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=hvaibhav@ti.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=tony@atomide.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.