From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Liu Ping Fan <pingfank@linux.vnet.ibm.com>,
Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access
Date: Tue, 10 Jul 2012 12:41:54 +0200 [thread overview]
Message-ID: <4FFC06F2.2010105@siemens.com> (raw)
In-Reply-To: <4FF164B4.50306@redhat.com>
On 2012-07-02 11:07, Avi Kivity wrote:
> On 06/29/2012 07:37 PM, Jan Kiszka wrote:
>> Instead of flushing pending coalesced MMIO requests on every vmexit,
>> this provides a mechanism to selectively flush when memory regions
>> related to the coalesced one are accessed. This first of all includes
>> the coalesced region itself but can also applied to other regions, e.g.
>> of the same device, by calling memory_region_set_flush_coalesced.
>
> Looks fine.
>
> I have a hard time deciding whether this should go through the kvm tree
> or memory tree. Anthony, perhaps you can commit it directly to avoid
> the livelock?
>
> Reviewed-by: Avi Kivity <avi@redhat.com>
>
Anthony, ping?
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Liu Ping Fan <pingfank@linux.vnet.ibm.com>,
Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access
Date: Tue, 10 Jul 2012 12:41:54 +0200 [thread overview]
Message-ID: <4FFC06F2.2010105@siemens.com> (raw)
In-Reply-To: <4FF164B4.50306@redhat.com>
On 2012-07-02 11:07, Avi Kivity wrote:
> On 06/29/2012 07:37 PM, Jan Kiszka wrote:
>> Instead of flushing pending coalesced MMIO requests on every vmexit,
>> this provides a mechanism to selectively flush when memory regions
>> related to the coalesced one are accessed. This first of all includes
>> the coalesced region itself but can also applied to other regions, e.g.
>> of the same device, by calling memory_region_set_flush_coalesced.
>
> Looks fine.
>
> I have a hard time deciding whether this should go through the kvm tree
> or memory tree. Anthony, perhaps you can commit it directly to avoid
> the livelock?
>
> Reviewed-by: Avi Kivity <avi@redhat.com>
>
Anthony, ping?
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-07-10 10:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 16:27 [PATCH v2 0/7] kvm: Get coalesced MMIO flushing out of the hot-path Jan Kiszka
2012-06-27 16:27 ` [PATCH v2 1/7] i82378: Remove bogus MMIO coalescing Jan Kiszka
2012-06-27 16:27 ` [PATCH v2 2/7] memory: Flush coalesced MMIO on selected region access Jan Kiszka
2012-06-28 16:07 ` Avi Kivity
2012-06-29 16:37 ` [PATCH v3 " Jan Kiszka
2012-07-02 9:07 ` Avi Kivity
2012-07-02 9:07 ` [Qemu-devel] " Avi Kivity
2012-07-02 9:07 ` Avi Kivity
2012-07-02 9:07 ` [Qemu-devel] " Avi Kivity
2012-07-10 10:41 ` Jan Kiszka [this message]
2012-07-10 10:41 ` Jan Kiszka
2012-08-17 10:55 ` Jan Kiszka
2012-08-17 10:55 ` [Qemu-devel] " Jan Kiszka
2012-08-19 9:46 ` Avi Kivity
2012-08-19 9:46 ` [Qemu-devel] " Avi Kivity
2012-06-27 16:27 ` [PATCH v2 3/7] memory: Use transaction_begin/commit also for single-step operations Jan Kiszka
2012-06-27 16:27 ` [PATCH v2 4/7] memory: Fold memory_region_update_topology into memory_region_transaction_commit Jan Kiszka
2012-06-27 16:27 ` [PATCH v2 5/7] memory: Flush coalesced MMIO on mapping and state changes Jan Kiszka
2012-06-27 16:27 ` [PATCH v2 6/7] VGA: Flush coalesced MMIO on related MMIO/PIO accesses Jan Kiszka
2012-06-27 16:27 ` [PATCH v2 7/7] kvm: Stop flushing coalesced MMIO on vmexit Jan Kiszka
2012-06-28 16:09 ` [PATCH v2 0/7] kvm: Get coalesced MMIO flushing out of the hot-path Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC06F2.2010105@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.