* [patch] ASoC: STA529: fix an error message
@ 2012-07-11 6:41 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-07-11 6:41 UTC (permalink / raw)
To: Liam Girdwood
Cc: alsa-devel, Rajeev Kumar, Takashi Iwai, Mark Brown,
kernel-janitors
GCC complains that "ret" is uninitialized here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/sta529.c b/sound/soc/codecs/sta529.c
index a9f34c7..0c225cd 100644
--- a/sound/soc/codecs/sta529.c
+++ b/sound/soc/codecs/sta529.c
@@ -397,8 +397,9 @@ static __devinit int sta529_i2c_probe(struct i2c_client *i2c,
sta529->regmap = devm_regmap_init_i2c(i2c, &sta529_regmap);
if (IS_ERR(sta529->regmap)) {
+ ret = PTR_ERR(sta529->regmap);
dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret);
- return PTR_ERR(sta529->regmap);
+ return ret;
}
i2c_set_clientdata(i2c, sta529);
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] ASoC: STA529: fix an error message
@ 2012-07-11 6:41 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-07-11 6:41 UTC (permalink / raw)
To: Liam Girdwood
Cc: alsa-devel, Rajeev Kumar, Takashi Iwai, Mark Brown,
kernel-janitors
GCC complains that "ret" is uninitialized here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/sta529.c b/sound/soc/codecs/sta529.c
index a9f34c7..0c225cd 100644
--- a/sound/soc/codecs/sta529.c
+++ b/sound/soc/codecs/sta529.c
@@ -397,8 +397,9 @@ static __devinit int sta529_i2c_probe(struct i2c_client *i2c,
sta529->regmap = devm_regmap_init_i2c(i2c, &sta529_regmap);
if (IS_ERR(sta529->regmap)) {
+ ret = PTR_ERR(sta529->regmap);
dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret);
- return PTR_ERR(sta529->regmap);
+ return ret;
}
i2c_set_clientdata(i2c, sta529);
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] ASoC: STA529: fix an error message
2012-07-11 6:41 ` Dan Carpenter
@ 2012-07-11 6:55 ` Rajeev kumar
-1 siblings, 0 replies; 6+ messages in thread
From: Rajeev kumar @ 2012-07-11 6:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel@alsa-project.org, Takashi Iwai, Mark Brown,
kernel-janitors@vger.kernel.org, Liam Girdwood
Hello Dan,
On 7/11/2012 12:11 PM, Dan Carpenter wrote:
> GCC complains that "ret" is uninitialized here.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
> diff --git a/sound/soc/codecs/sta529.c b/sound/soc/codecs/sta529.c
> index a9f34c7..0c225cd 100644
> --- a/sound/soc/codecs/sta529.c
> +++ b/sound/soc/codecs/sta529.c
> @@ -397,8 +397,9 @@ static __devinit int sta529_i2c_probe(struct i2c_client *i2c,
>
> sta529->regmap = devm_regmap_init_i2c(i2c,&sta529_regmap);
> if (IS_ERR(sta529->regmap)) {
> + ret = PTR_ERR(sta529->regmap);
> dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret);
> - return PTR_ERR(sta529->regmap);
> + return ret;
> }
>
> i2c_set_clientdata(i2c, sta529);
> .
>
Thanks for the patch.
Acked-By: Rajeev Kumar <rajeev-dlh.kumar@st.com>
~Rajeev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] ASoC: STA529: fix an error message
@ 2012-07-11 6:55 ` Rajeev kumar
0 siblings, 0 replies; 6+ messages in thread
From: Rajeev kumar @ 2012-07-11 6:55 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel@alsa-project.org, Takashi Iwai, Mark Brown,
kernel-janitors@vger.kernel.org, Liam Girdwood
Hello Dan,
On 7/11/2012 12:11 PM, Dan Carpenter wrote:
> GCC complains that "ret" is uninitialized here.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
> diff --git a/sound/soc/codecs/sta529.c b/sound/soc/codecs/sta529.c
> index a9f34c7..0c225cd 100644
> --- a/sound/soc/codecs/sta529.c
> +++ b/sound/soc/codecs/sta529.c
> @@ -397,8 +397,9 @@ static __devinit int sta529_i2c_probe(struct i2c_client *i2c,
>
> sta529->regmap = devm_regmap_init_i2c(i2c,&sta529_regmap);
> if (IS_ERR(sta529->regmap)) {
> + ret = PTR_ERR(sta529->regmap);
> dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret);
> - return PTR_ERR(sta529->regmap);
> + return ret;
> }
>
> i2c_set_clientdata(i2c, sta529);
> .
>
Thanks for the patch.
Acked-By: Rajeev Kumar <rajeev-dlh.kumar@st.com>
~Rajeev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ASoC: STA529: fix an error message
2012-07-11 6:41 ` Dan Carpenter
@ 2012-07-11 9:38 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-07-11 9:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Rajeev Kumar, Takashi Iwai, kernel-janitors,
Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 198 bytes --]
On Wed, Jul 11, 2012 at 09:41:23AM +0300, Dan Carpenter wrote:
> GCC complains that "ret" is uninitialized here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ASoC: STA529: fix an error message
@ 2012-07-11 9:38 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-07-11 9:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Rajeev Kumar, Takashi Iwai, kernel-janitors,
Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
On Wed, Jul 11, 2012 at 09:41:23AM +0300, Dan Carpenter wrote:
> GCC complains that "ret" is uninitialized here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-11 9:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-11 6:41 [patch] ASoC: STA529: fix an error message Dan Carpenter
2012-07-11 6:41 ` Dan Carpenter
2012-07-11 6:51 ` Rajeev kumar
2012-07-11 6:55 ` Rajeev kumar
2012-07-11 9:38 ` Mark Brown
2012-07-11 9:38 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.