* [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
@ 2012-07-11 6:36 ` Dan Carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2012-07-11 6:36 UTC (permalink / raw)
To: MyungJoo Ham, Mark Brown; +Cc: Chanwoo Choi, linux-kernel, kernel-janitors
Smatch complains about this. I don't have a way to test this, but it
does look like we should unlock on error here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index b068bc9..4782884 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -154,6 +154,7 @@ static irqreturn_t arizona_micdet(int irq, void *data)
ret = regmap_read(arizona->regmap, ARIZONA_MIC_DETECT_3, &val);
if (ret != 0) {
dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
+ mutex_unlock(&info->lock);
return IRQ_NONE;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
2012-07-11 6:36 ` Dan Carpenter
@ 2012-07-11 23:55 ` Chanwoo Choi
-1 siblings, 0 replies; 9+ messages in thread
From: Chanwoo Choi @ 2012-07-11 23:55 UTC (permalink / raw)
To: Dan Carpenter; +Cc: MyungJoo Ham, Mark Brown, linux-kernel, kernel-janitors
Hi Dan,
On 07/11/2012 03:36 PM, Dan Carpenter wrote:
> Smatch complains about this. I don't have a way to test this, but it
> does look like we should unlock on error here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index b068bc9..4782884 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -154,6 +154,7 @@ static irqreturn_t arizona_micdet(int irq, void *data)
> ret = regmap_read(arizona->regmap, ARIZONA_MIC_DETECT_3, &val);
> if (ret != 0) {
> dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
> + mutex_unlock(&info->lock);
> return IRQ_NONE;
> }
>
This patch is right.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
@ 2012-07-11 23:55 ` Chanwoo Choi
0 siblings, 0 replies; 9+ messages in thread
From: Chanwoo Choi @ 2012-07-11 23:55 UTC (permalink / raw)
To: Dan Carpenter; +Cc: MyungJoo Ham, Mark Brown, linux-kernel, kernel-janitors
Hi Dan,
On 07/11/2012 03:36 PM, Dan Carpenter wrote:
> Smatch complains about this. I don't have a way to test this, but it
> does look like we should unlock on error here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index b068bc9..4782884 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -154,6 +154,7 @@ static irqreturn_t arizona_micdet(int irq, void *data)
> ret = regmap_read(arizona->regmap, ARIZONA_MIC_DETECT_3, &val);
> if (ret != 0) {
> dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
> + mutex_unlock(&info->lock);
> return IRQ_NONE;
> }
>
This patch is right.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
2012-07-11 6:36 ` Dan Carpenter
(?)
(?)
@ 2012-07-12 16:19 ` walter harms
-1 siblings, 0 replies; 9+ messages in thread
From: walter harms @ 2012-07-12 16:19 UTC (permalink / raw)
To: kernel-janitors
Am 11.07.2012 08:36, schrieb Dan Carpenter:
> Smatch complains about this. I don't have a way to test this, but it
> does look like we should unlock on error here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index b068bc9..4782884 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -154,6 +154,7 @@ static irqreturn_t arizona_micdet(int irq, void *data)
> ret = regmap_read(arizona->regmap, ARIZONA_MIC_DETECT_3, &val);
> if (ret != 0) {
> dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
> + mutex_unlock(&info->lock);
> return IRQ_NONE;
> }
>
> --
nitpicking:
normally you unlock before dev_err() and is the msg ok ?
IMHO "Failed to read ARIZONA_MIC_DETECT_3:%d\n" seems more obvious,
(I really do not know that device)
re,
wh
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
2012-07-11 6:36 ` Dan Carpenter
` (2 preceding siblings ...)
(?)
@ 2012-07-12 16:24 ` Dan Carpenter
-1 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2012-07-12 16:24 UTC (permalink / raw)
To: kernel-janitors
On Thu, Jul 12, 2012 at 06:19:29PM +0200, walter harms wrote:
> nitpicking:
> normally you unlock before dev_err() and is the msg ok ?
> IMHO "Failed to read ARIZONA_MIC_DETECT_3:%d\n" seems more obvious,
> (I really do not know that device)
>
It's not a bad idea if someone wants to send a follow on patch. I
just matched the rest of the function.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
2012-07-11 6:36 ` Dan Carpenter
` (3 preceding siblings ...)
(?)
@ 2012-07-12 17:27 ` Mark Brown
-1 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2012-07-12 17:27 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
On Thu, Jul 12, 2012 at 06:19:29PM +0200, walter harms wrote:
> > if (ret != 0) {
> > dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
> > + mutex_unlock(&info->lock);
> > return IRQ_NONE;
> normally you unlock before dev_err() and is the msg ok ?
No, that's really unusual as it can make the trace much harder to follow
if there's any contention.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
2012-07-11 6:36 ` Dan Carpenter
@ 2012-07-12 17:30 ` Mark Brown
-1 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2012-07-12 17:30 UTC (permalink / raw)
To: Dan Carpenter; +Cc: MyungJoo Ham, Chanwoo Choi, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Wed, Jul 11, 2012 at 09:36:02AM +0300, Dan Carpenter wrote:
> Smatch complains about this. I don't have a way to test this, but it
> does look like we should unlock on error here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acke-dby: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
@ 2012-07-12 17:30 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2012-07-12 17:30 UTC (permalink / raw)
To: Dan Carpenter; +Cc: MyungJoo Ham, Chanwoo Choi, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Wed, Jul 11, 2012 at 09:36:02AM +0300, Dan Carpenter wrote:
> Smatch complains about this. I don't have a way to test this, but it
> does look like we should unlock on error here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acke-dby: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread