All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yonghong Song <yonghong.song@linux.dev>
To: Daniel Borkmann <daniel@iogearbox.net>,
	Xu Kuohai <xukuohai@huawei.com>,
	Xu Kuohai <xukuohai@huaweicloud.com>,
	bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Yonghong Song <yhs@fb.com>,
	Zi Shen Lim <zlim.lnx@gmail.com>
Subject: Re: [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64
Date: Fri, 18 Aug 2023 08:34:27 -0700	[thread overview]
Message-ID: <4a45663d-2982-bc6a-a895-c0117833339f@linux.dev> (raw)
In-Reply-To: <28f7de40-4941-4554-25bf-370dd2ec3226@iogearbox.net>



On 8/18/23 7:04 AM, Daniel Borkmann wrote:
> On 8/16/23 4:31 AM, Xu Kuohai wrote:
>> On 8/16/2023 9:57 AM, Yonghong Song wrote:
>>> On 8/15/23 6:28 PM, Xu Kuohai wrote:
>>>> On 8/16/2023 12:57 AM, Yonghong Song wrote:
>>>>> On 8/15/23 8:41 AM, Xu Kuohai wrote:
>>>>>> From: Xu Kuohai <xukuohai@huawei.com>
>>>>>>
>>>>>> Enable cpu v4 instruction tests for arm64.
>>>>>>
>>>>>> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
>>>>>
>>>>> Thanks for adding cpu v4 support for arm64. The CI looks green as 
>>>>> well for arm64.
>>>>>
>>>>> https://github.com/kernel-patches/bpf/actions/runs/5868919914/job/15912774884?pr=5525
>>>>
>>>> Well, it looks like the CI's clang doesn't support cpu v4 yet:
>>>>
>>>>    #306/1   verifier_bswap/cpuv4 is not supported by compiler or 
>>>> jit, use a dummy test:OK
>>>>    #306     verifier_bswap:OK
>>>>
>>>>> Ack this patch which enabled cpu v4 tests for arm64.
>>>
>>> Ah. Sorry. Could you paste your local cpu v4 run results for
>>> these related tests in the commit message then?
>>
>> Sure. The results are as follows. I'll post these in the commit message.
> 
> Thanks, I've added these to the commit message given Florent's review and
> tests came in.
> 
> Yonghong, did you ping all other JIT folks as well, so they are aware 
> and have
> a chance to look into adding support for their archs?

Thanks, Daniel for reminder. Will ping them soon to get
cpu v4 support for other arch's as well.

> 
> Thanks,
> Daniel
> 

WARNING: multiple messages have this Message-ID (diff)
From: Yonghong Song <yonghong.song@linux.dev>
To: Daniel Borkmann <daniel@iogearbox.net>,
	Xu Kuohai <xukuohai@huawei.com>,
	Xu Kuohai <xukuohai@huaweicloud.com>,
	bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Yonghong Song <yhs@fb.com>,
	Zi Shen Lim <zlim.lnx@gmail.com>
Subject: Re: [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64
Date: Fri, 18 Aug 2023 08:34:27 -0700	[thread overview]
Message-ID: <4a45663d-2982-bc6a-a895-c0117833339f@linux.dev> (raw)
In-Reply-To: <28f7de40-4941-4554-25bf-370dd2ec3226@iogearbox.net>



On 8/18/23 7:04 AM, Daniel Borkmann wrote:
> On 8/16/23 4:31 AM, Xu Kuohai wrote:
>> On 8/16/2023 9:57 AM, Yonghong Song wrote:
>>> On 8/15/23 6:28 PM, Xu Kuohai wrote:
>>>> On 8/16/2023 12:57 AM, Yonghong Song wrote:
>>>>> On 8/15/23 8:41 AM, Xu Kuohai wrote:
>>>>>> From: Xu Kuohai <xukuohai@huawei.com>
>>>>>>
>>>>>> Enable cpu v4 instruction tests for arm64.
>>>>>>
>>>>>> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
>>>>>
>>>>> Thanks for adding cpu v4 support for arm64. The CI looks green as 
>>>>> well for arm64.
>>>>>
>>>>> https://github.com/kernel-patches/bpf/actions/runs/5868919914/job/15912774884?pr=5525
>>>>
>>>> Well, it looks like the CI's clang doesn't support cpu v4 yet:
>>>>
>>>>    #306/1   verifier_bswap/cpuv4 is not supported by compiler or 
>>>> jit, use a dummy test:OK
>>>>    #306     verifier_bswap:OK
>>>>
>>>>> Ack this patch which enabled cpu v4 tests for arm64.
>>>
>>> Ah. Sorry. Could you paste your local cpu v4 run results for
>>> these related tests in the commit message then?
>>
>> Sure. The results are as follows. I'll post these in the commit message.
> 
> Thanks, I've added these to the commit message given Florent's review and
> tests came in.
> 
> Yonghong, did you ping all other JIT folks as well, so they are aware 
> and have
> a chance to look into adding support for their archs?

Thanks, Daniel for reminder. Will ping them soon to get
cpu v4 support for other arch's as well.

> 
> Thanks,
> Daniel
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-18 15:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 15:41 [PATCH bpf-next 0/7] Support cpu v4 instructions for arm64 Xu Kuohai
2023-08-15 15:41 ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 1/7] arm64: insn: Add encoders for LDRSB/LDRSH/LDRSW Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 2/7] bpf, arm64: Support sign-extension load instructions Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 3/7] bpf, arm64: Support sign-extension mov instructions Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 4/7] bpf, arm64: Support unconditional bswap Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 5/7] bpf, arm64: Support 32-bit offset jmp instruction Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 6/7] bpf, arm64: Support signed div/mod instructions Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64 Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 16:57   ` Yonghong Song
2023-08-15 16:57     ` Yonghong Song
2023-08-16  1:28     ` Xu Kuohai
2023-08-16  1:28       ` Xu Kuohai
2023-08-16  1:57       ` Yonghong Song
2023-08-16  1:57         ` Yonghong Song
2023-08-16  2:31         ` Xu Kuohai
2023-08-16  2:31           ` Xu Kuohai
2023-08-18 14:04           ` Daniel Borkmann
2023-08-18 14:04             ` Daniel Borkmann
2023-08-18 15:34             ` Yonghong Song [this message]
2023-08-18 15:34               ` Yonghong Song
2023-08-18 12:22 ` [PATCH bpf-next 0/7] Support cpu v4 instructions " Florent Revest
2023-08-18 12:22   ` Florent Revest
2023-08-18 13:50 ` patchwork-bot+netdevbpf
2023-08-18 13:50   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a45663d-2982-bc6a-a895-c0117833339f@linux.dev \
    --to=yonghong.song@linux.dev \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel@iogearbox.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.lau@linux.dev \
    --cc=will@kernel.org \
    --cc=xukuohai@huawei.com \
    --cc=xukuohai@huaweicloud.com \
    --cc=yhs@fb.com \
    --cc=zlim.lnx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.