All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yonghong Song <yonghong.song@linux.dev>
To: Xu Kuohai <xukuohai@huaweicloud.com>,
	bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Yonghong Song <yhs@fb.com>,
	Zi Shen Lim <zlim.lnx@gmail.com>
Subject: Re: [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64
Date: Tue, 15 Aug 2023 09:57:50 -0700	[thread overview]
Message-ID: <f1b6fde2-5097-7a0f-29ad-7390a165bf16@linux.dev> (raw)
In-Reply-To: <20230815154158.717901-8-xukuohai@huaweicloud.com>



On 8/15/23 8:41 AM, Xu Kuohai wrote:
> From: Xu Kuohai <xukuohai@huawei.com>
> 
> Enable cpu v4 instruction tests for arm64.
> 
> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>

Thanks for adding cpu v4 support for arm64. The CI looks green as well 
for arm64.

https://github.com/kernel-patches/bpf/actions/runs/5868919914/job/15912774884?pr=5525

Ack this patch which enabled cpu v4 tests for arm64.

Acked-by: Yonghong Song <yonghong.song@linux.dev>

> ---
>   tools/testing/selftests/bpf/progs/test_ldsx_insn.c | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_bswap.c | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_gotol.c | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_ldsx.c  | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_movsx.c | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_sdiv.c  | 2 +-
>   6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
> index 321abf862801..916d9435f12c 100644
> --- a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
> +++ b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
> @@ -5,7 +5,7 @@
>   #include <bpf/bpf_helpers.h>
>   #include <bpf/bpf_tracing.h>
>   
> -#if defined(__TARGET_ARCH_x86) && __clang_major__ >= 18
> +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && __clang_major__ >= 18
>   const volatile int skip = 0;
>   #else
>   const volatile int skip = 1;
[...]

WARNING: multiple messages have this Message-ID (diff)
From: Yonghong Song <yonghong.song@linux.dev>
To: Xu Kuohai <xukuohai@huaweicloud.com>,
	bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Yonghong Song <yhs@fb.com>,
	Zi Shen Lim <zlim.lnx@gmail.com>
Subject: Re: [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64
Date: Tue, 15 Aug 2023 09:57:50 -0700	[thread overview]
Message-ID: <f1b6fde2-5097-7a0f-29ad-7390a165bf16@linux.dev> (raw)
In-Reply-To: <20230815154158.717901-8-xukuohai@huaweicloud.com>



On 8/15/23 8:41 AM, Xu Kuohai wrote:
> From: Xu Kuohai <xukuohai@huawei.com>
> 
> Enable cpu v4 instruction tests for arm64.
> 
> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>

Thanks for adding cpu v4 support for arm64. The CI looks green as well 
for arm64.

https://github.com/kernel-patches/bpf/actions/runs/5868919914/job/15912774884?pr=5525

Ack this patch which enabled cpu v4 tests for arm64.

Acked-by: Yonghong Song <yonghong.song@linux.dev>

> ---
>   tools/testing/selftests/bpf/progs/test_ldsx_insn.c | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_bswap.c | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_gotol.c | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_ldsx.c  | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_movsx.c | 2 +-
>   tools/testing/selftests/bpf/progs/verifier_sdiv.c  | 2 +-
>   6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
> index 321abf862801..916d9435f12c 100644
> --- a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
> +++ b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
> @@ -5,7 +5,7 @@
>   #include <bpf/bpf_helpers.h>
>   #include <bpf/bpf_tracing.h>
>   
> -#if defined(__TARGET_ARCH_x86) && __clang_major__ >= 18
> +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && __clang_major__ >= 18
>   const volatile int skip = 0;
>   #else
>   const volatile int skip = 1;
[...]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-15 16:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 15:41 [PATCH bpf-next 0/7] Support cpu v4 instructions for arm64 Xu Kuohai
2023-08-15 15:41 ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 1/7] arm64: insn: Add encoders for LDRSB/LDRSH/LDRSW Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 2/7] bpf, arm64: Support sign-extension load instructions Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 3/7] bpf, arm64: Support sign-extension mov instructions Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 4/7] bpf, arm64: Support unconditional bswap Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 5/7] bpf, arm64: Support 32-bit offset jmp instruction Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 6/7] bpf, arm64: Support signed div/mod instructions Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 15:41 ` [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64 Xu Kuohai
2023-08-15 15:41   ` Xu Kuohai
2023-08-15 16:57   ` Yonghong Song [this message]
2023-08-15 16:57     ` Yonghong Song
2023-08-16  1:28     ` Xu Kuohai
2023-08-16  1:28       ` Xu Kuohai
2023-08-16  1:57       ` Yonghong Song
2023-08-16  1:57         ` Yonghong Song
2023-08-16  2:31         ` Xu Kuohai
2023-08-16  2:31           ` Xu Kuohai
2023-08-18 14:04           ` Daniel Borkmann
2023-08-18 14:04             ` Daniel Borkmann
2023-08-18 15:34             ` Yonghong Song
2023-08-18 15:34               ` Yonghong Song
2023-08-18 12:22 ` [PATCH bpf-next 0/7] Support cpu v4 instructions " Florent Revest
2023-08-18 12:22   ` Florent Revest
2023-08-18 13:50 ` patchwork-bot+netdevbpf
2023-08-18 13:50   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1b6fde2-5097-7a0f-29ad-7390a165bf16@linux.dev \
    --to=yonghong.song@linux.dev \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel@iogearbox.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.lau@linux.dev \
    --cc=will@kernel.org \
    --cc=xukuohai@huaweicloud.com \
    --cc=yhs@fb.com \
    --cc=zlim.lnx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.