[PATCH 0/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree support

[PATCH 0/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree support

[muhammad.nazim.amirul.nazle.asmade]

From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>

This series introduces initial device tree support for the Intel
SoCFPGA Agilex7 Gen2 platform.

The first patch registers the new SoC and board compatible strings in
the DT binding. The second patch adds the SoC DTSI and board DTS with
basic platform nodes.

Nazim Amirul (2):
  dt-bindings: arm: altera: Add Agilex7 Gen2 SoCFPGA compatible strings
  arm64: dts: socfpga: agilex7-gen2: Add initial device tree

 .../devicetree/bindings/arm/altera.yaml       |   6 +
 arch/arm64/boot/dts/intel/Makefile            |   1 +
 .../boot/dts/intel/socfpga_agilex7_gen2.dtsi  | 175 ++++++++++++++++++
 .../dts/intel/socfpga_agilex7_gen2_socdk.dts  |  15 ++
 4 files changed, 197 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex7_gen2.dtsi
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex7_gen2_socdk.dts

-- 
2.43.7

[PATCH 1/2] dt-bindings: arm: altera: Add Agilex7 Gen2 SoCFPGA compatible strings

[muhammad.nazim.amirul.nazle.asmade]

From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>

Add the SoC and board compatible strings for the Intel SoCFPGA
Agilex7 Gen2 platform.

Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
---
 Documentation/devicetree/bindings/arm/altera.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
index 4b096e52243e..da32ff31aea0 100644
--- a/Documentation/devicetree/bindings/arm/altera.yaml
+++ b/Documentation/devicetree/bindings/arm/altera.yaml
@@ -115,6 +115,12 @@ properties:
               - intel,socfpga-agilex5-socdk-nand
           - const: intel,socfpga-agilex5
 
+      - description: Agilex7 Gen2 boards
+        items:
+          - enum:
+              - intel,socfpga-agilex7-gen2-socdk
+          - const: intel,socfpga-agilex7-gen2
+
       - description: Agilex7m boards
         items:
           - enum:
-- 
2.43.7

Re: [PATCH 1/2] dt-bindings: arm: altera: Add Agilex7 Gen2 SoCFPGA compatible strings

[Krzysztof Kozlowski]

On Tue, Jun 23, 2026 at 04:17:15AM -0700, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
> 
> Add the SoC and board compatible strings for the Intel SoCFPGA
> Agilex7 Gen2 platform.
> 
> Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
> ---
>  Documentation/devicetree/bindings/arm/altera.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

[PATCH 2/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree

[muhammad.nazim.amirul.nazle.asmade]

From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>

Add initial device tree support for the Intel SoCFPGA Agilex7 Gen2
platform. This introduces the SoC DTSI and the SoCDK board DTS as
the first upstream submission for this platform.

The Agilex7 Gen2 SoC features a heterogeneous CPU cluster with
Cortex-A520 and Cortex-A720 cores, and includes an SMMU v3 for
memory management.

Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
---
 arch/arm64/boot/dts/intel/Makefile            |   1 +
 .../boot/dts/intel/socfpga_agilex7_gen2.dtsi  | 119 ++++++++++++++++++
 .../dts/intel/socfpga_agilex7_gen2_socdk.dts  |  15 +++
 3 files changed, 135 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex7_gen2.dtsi
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex7_gen2_socdk.dts

diff --git a/arch/arm64/boot/dts/intel/Makefile b/arch/arm64/boot/dts/intel/Makefile
index 088a03b89c99..7a53b3c174a1 100644
--- a/arch/arm64/boot/dts/intel/Makefile
+++ b/arch/arm64/boot/dts/intel/Makefile
@@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \
 				socfpga_agilex5_socdk_013b.dtb \
 				socfpga_agilex5_socdk_modular.dtb \
 				socfpga_agilex5_socdk_nand.dtb \
+				socfpga_agilex7_gen2_socdk.dtb \
 				socfpga_agilex7m_socdk.dtb \
 				socfpga_n5x_socdk.dtb
 dtb-$(CONFIG_ARCH_KEEMBAY) += keembay-evm.dtb
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex7_gen2.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex7_gen2.dtsi
new file mode 100644
index 000000000000..e3b777408f9a
--- /dev/null
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex7_gen2.dtsi
@@ -0,0 +1,119 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2026, Altera Corporation
+ */
+/dts-v1/;
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+/ {
+	compatible = "intel,socfpga-agilex7-gen2";
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		atf_reserved: atf@80000000 {
+			compatible = "shared-dma-pool";
+			reg = <0x0 0x80000000 0x0 0x100000>;
+			alignment = <0x1000>;
+			no-map;
+		};
+
+		service_reserved: svcbuffer@80100000 {
+			compatible = "shared-dma-pool";
+			reg = <0x0 0x80100000 0x0 0xf00000>;
+			alignment = <0x1000>;
+			no-map;
+		};
+	};
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu0: cpu@0 {
+			compatible = "arm,cortex-a520";
+			device_type = "cpu";
+			enable-method = "psci";
+			reg = <0x0>;
+		};
+
+		cpu1: cpu@100 {
+			compatible = "arm,cortex-a520";
+			device_type = "cpu";
+			enable-method = "psci";
+			reg = <0x100>;
+		};
+
+		cpu2: cpu@200 {
+			compatible = "arm,cortex-a720";
+			device_type = "cpu";
+			enable-method = "psci";
+			reg = <0x200>;
+		};
+
+		cpu3: cpu@300 {
+			compatible = "arm,cortex-a720";
+			device_type = "cpu";
+			enable-method = "psci";
+			reg = <0x300>;
+		};
+	};
+
+	psci {
+		compatible = "arm,psci-0.2";
+		method = "smc";
+	};
+
+	intc: interrupt-controller@7000000 {
+		compatible = "arm,gic-v3";
+		reg = <0x0 0x7000000 0x0 0x10000>,
+		      <0x0 0x7080000 0x0 0x100000>;
+		ranges;
+		#interrupt-cells = <3>;
+		#address-cells = <2>;
+		#size-cells = <2>;
+		interrupt-controller;
+		#redistributor-regions = <1>;
+		redistributor-stride = <0x0 0x40000>;
+
+		its: msi-controller@7040000 {
+			compatible = "arm,gic-v3-its";
+			reg = <0x0 0x7040000 0x0 0x20000>;
+			msi-controller;
+			#msi-cells = <1>;
+		};
+	};
+
+	soc: soc@0 {
+		compatible = "simple-bus";
+		ranges = <0 0 0 0xffffffff>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		device_type = "soc";
+		interrupt-parent = <&intc>;
+
+		smmu: iommu@c100000 {
+			compatible = "arm,smmu-v3";
+			reg = <0x0c100000 0x30000>;
+			interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_RISING>,
+				     <GIC_SPI 129 IRQ_TYPE_EDGE_RISING>,
+				     <GIC_SPI 132 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "eventq", "gerror", "priq";
+			dma-coherent;
+			#iommu-cells = <1>;
+		};
+
+		ocram: sram@0 {
+			compatible = "mmio-sram";
+			reg = <0x00000000 0x80000>;
+			ranges = <0 0 0x80000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+	};
+};
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex7_gen2_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex7_gen2_socdk.dts
new file mode 100644
index 000000000000..416d033445ff
--- /dev/null
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex7_gen2_socdk.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2026, Altera Corporation
+ */
+#include "socfpga_agilex7_gen2.dtsi"
+
+/ {
+	model = "Altera SoCFPGA Agilex7 Gen2 SoCDK";
+	compatible = "intel,socfpga-agilex7-gen2-socdk", "intel,socfpga-agilex7-gen2";
+
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x0 0x80000000 0x0 0x80000000>;
+	};
+};
-- 
2.43.7

Re: [PATCH 2/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 7 potential issue(s) to consider:
- [Critical] Missing mandatory ARM architected timer (`arm,armv8-timer`) node.
- [High] The ATF (ARM Trusted Firmware) reserved memory is improperly declared as a shared DMA pool.
- [Medium] Missing Energy Aware Scheduling (EAS) capacity and topology maps for heterogeneous big.LITTLE CPUs.
- [Medium] Missing UART/serial console and `chosen` node.
- [Medium] Missing VGIC maintenance interrupt in the GICv3 node.
- [Low] Invalid combination of `reg` and `alignment` properties in `reserved-memory` nodes.
- [Low] Incorrect `#address-cells` for 64-bit CPUs.
--

commit 686f550501dd7f94cdc969838594ed32ff4cbd42
Author: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>

arm64: dts: socfpga: agilex7-gen2: Add initial device tree

This patch adds the initial device tree support for the Intel SoCFPGA Agilex7
Gen2 platform. It includes the SoC DTSI and the SoCDK board DTS, featuring
a heterogeneous CPU cluster with Cortex-A520 and Cortex-A720 cores.

> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex7_gen2.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex7_gen2.dtsi
> new file mode 100644
> index 0000000000000..e3b777408f9a6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex7_gen2.dtsi
> @@ -0,0 +1,119 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2026, Altera Corporation
> + */
> +/dts-v1/;
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> +	compatible = "intel,socfpga-agilex7-gen2";
> +	#address-cells = <2>;
> +	#size-cells = <2>;

[Severity: Critical]
Is it intentional to omit the arm,armv8-timer node from the root level? Without
the architectural timer node, the system may fail to establish a clocksource
and clockevents, which typically leads to an indefinite hang during early boot
when timer_probe() fails.

[Severity: Medium]
Does this platform need a chosen node and UART serial console configured at
the root level? Omitting them usually results in no interactive console or
kernel boot logs over serial, which makes early boot validation very difficult.

> +
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		atf_reserved: atf@80000000 {
> +			compatible = "shared-dma-pool";

[Severity: High]
Does declaring the ATF reserved memory as a shared-dma-pool expose the secure
EL3 memory region to the kernel's DMA allocator? If the kernel resolves a DMA
allocation to this region and a device writes to it, it could overwrite the
TrustZone firmware, potentially triggering a secure access violation (SError).

> +			reg = <0x0 0x80000000 0x0 0x100000>;
> +			alignment = <0x1000>;

[Severity: Low]
Is it necessary to include the alignment property when reg is already
explicitly provided? Device tree schema validation typically rejects combining
reg and alignment in reserved-memory nodes, as the kernel parser typically
ignores alignment when reg is present.

> +			no-map;
> +		};
> +
> +		service_reserved: svcbuffer@80100000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x0 0x80100000 0x0 0xf00000>;
> +			alignment = <0x1000>;

[Severity: Low]
Similar to the ATF reserved node, is the alignment property needed here when a
reg property is explicitly defined?

> +			no-map;
> +		};
> +	};
> +
> +	cpus {
> +		#address-cells = <1>;

[Severity: Low]
Should #address-cells be 2 for 64-bit ARM CPUs? While it might work if the
Aff3 field is zero, setting it to 1 truncates the MPIDR_EL1 representation to
32 bits and violates ARM64 device tree binding conventions.

> +		#size-cells = <0>;
> +
> +		cpu0: cpu@0 {
> +			compatible = "arm,cortex-a520";
> +			device_type = "cpu";
> +			enable-method = "psci";
> +			reg = <0x0>;
> +		};

[ ... ]

> +		cpu3: cpu@300 {
> +			compatible = "arm,cortex-a720";

[Severity: Medium]
Are the Energy Aware Scheduling (EAS) capacity and topology maps missing for
these heterogeneous cores? Without them, the scheduler might treat the
Cortex-A520 and Cortex-A720 as having identical performance capabilities,
leading to suboptimal task placement.

> +			device_type = "cpu";
> +			enable-method = "psci";
> +			reg = <0x300>;
> +		};
> +	};
> +
> +	psci {
> +		compatible = "arm,psci-0.2";
> +		method = "smc";
> +	};
> +
> +	intc: interrupt-controller@7000000 {
> +		compatible = "arm,gic-v3";
> +		reg = <0x0 0x7000000 0x0 0x10000>,
> +		      <0x0 0x7080000 0x0 0x100000>;
> +		ranges;
> +		#interrupt-cells = <3>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		interrupt-controller;
> +		#redistributor-regions = <1>;
> +		redistributor-stride = <0x0 0x40000>;

[Severity: Medium]
Does the GICv3 node need to declare a VGIC maintenance interrupt? Without this
interrupt, the KVM hypervisor might not receive maintenance interrupts,
which can break virtualized interrupt state management for guest VMs.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623111716.16690-1-muhammad.nazim.amirul.nazle.asmade@altera.com?part=2

Re: [PATCH 2/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree

[Krzysztof Kozlowski]

On Tue, Jun 23, 2026 at 04:17:16AM -0700, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
> +
> +	psci {
> +		compatible = "arm,psci-0.2";
> +		method = "smc";
> +	};
> +
> +	intc: interrupt-controller@7000000 {

MMIO goes to MMIO, please read writing bindings and submitting patches docs in DT dir.

I think this also fails tests (W=1). If that is true, then review should
finish here, because instead of using machine to find issues you use
community.

> +		compatible = "arm,gic-v3";
> +		reg = <0x0 0x7000000 0x0 0x10000>,
> +		      <0x0 0x7080000 0x0 0x100000>;
> +		ranges;
> +		#interrupt-cells = <3>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		interrupt-controller;
> +		#redistributor-regions = <1>;
> +		redistributor-stride = <0x0 0x40000>;
> +
> +		its: msi-controller@7040000 {
> +			compatible = "arm,gic-v3-its";
> +			reg = <0x0 0x7040000 0x0 0x20000>;
> +			msi-controller;
> +			#msi-cells = <1>;
> +		};
> +	};
> +
> +	soc: soc@0 {
> +		compatible = "simple-bus";
> +		ranges = <0 0 0 0xffffffff>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		device_type = "soc";
> +		interrupt-parent = <&intc>;
> +
> +		smmu: iommu@c100000 {
> +			compatible = "arm,smmu-v3";
> +			reg = <0x0c100000 0x30000>;
> +			interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_RISING>,
> +				     <GIC_SPI 129 IRQ_TYPE_EDGE_RISING>,
> +				     <GIC_SPI 132 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "eventq", "gerror", "priq";
> +			dma-coherent;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ocram: sram@0 {
> +			compatible = "mmio-sram";
> +			reg = <0x00000000 0x80000>;
> +			ranges = <0 0 0x80000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;

SoC without any interface, serial or storage or network, is close to
useless one.

I don't see a point in having it in mainline. Serial is usually ABSOLUTE
minimum.

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree

[Nazle Asmade, Muhammad Nazim Amirul]

On 24/6/2026 3:57 pm, Krzysztof Kozlowski wrote:
> On Tue, Jun 23, 2026 at 04:17:16AM -0700, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
>> +
>> +	psci {
>> +		compatible = "arm,psci-0.2";
>> +		method = "smc";
>> +	};
>> +
>> +	intc: interrupt-controller@7000000 {
> 
> MMIO goes to MMIO, please read writing bindings and submitting patches docs in DT dir.
> 
> I think this also fails tests (W=1). If that is true, then review should
> finish here, because instead of using machine to find issues you use
> community.
> 
>> +		compatible = "arm,gic-v3";
>> +		reg = <0x0 0x7000000 0x0 0x10000>,
>> +		      <0x0 0x7080000 0x0 0x100000>;
>> +		ranges;
>> +		#interrupt-cells = <3>;
>> +		#address-cells = <2>;
>> +		#size-cells = <2>;
>> +		interrupt-controller;
>> +		#redistributor-regions = <1>;
>> +		redistributor-stride = <0x0 0x40000>;
>> +
>> +		its: msi-controller@7040000 {
>> +			compatible = "arm,gic-v3-its";
>> +			reg = <0x0 0x7040000 0x0 0x20000>;
>> +			msi-controller;
>> +			#msi-cells = <1>;
>> +		};
>> +	};
>> +
>> +	soc: soc@0 {
>> +		compatible = "simple-bus";
>> +		ranges = <0 0 0 0xffffffff>;
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +		device_type = "soc";
>> +		interrupt-parent = <&intc>;
>> +
>> +		smmu: iommu@c100000 {
>> +			compatible = "arm,smmu-v3";
>> +			reg = <0x0c100000 0x30000>;
>> +			interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 129 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 132 IRQ_TYPE_EDGE_RISING>;
>> +			interrupt-names = "eventq", "gerror", "priq";
>> +			dma-coherent;
>> +			#iommu-cells = <1>;
>> +		};
>> +
>> +		ocram: sram@0 {
>> +			compatible = "mmio-sram";
>> +			reg = <0x00000000 0x80000>;
>> +			ranges = <0 0 0x80000>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
> 
> SoC without any interface, serial or storage or network, is close to
> useless one.
> 
> I don't see a point in having it in mainline. Serial is usually ABSOLUTE
> minimum.
> 
> Best regards,
> Krzysztof
> 
Hi Krzysztof,

Thank you for the review and fast response!

I ran both dt_binding_check and dtbs_check (with CHECK_DTBS=y) locally — 
both passed without errors. Could you clarify which specific test you 
believe is failing?

Regarding "MMIO goes to MMIO" — are you referring to the GIC 
(interrupt-controller@7000000) being placed at the root level instead of 
under the soc bus node?

Regarding the serial console — the platform clock driver is not yet 
upstream, so the UART depends on clkmgr. Would adding the UART with 
clock-frequency be acceptable as an interim solution?

BR,
Nazim

Re: [PATCH 2/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree

[Krzysztof Kozlowski]

On 24/06/2026 12:17, Nazle Asmade, Muhammad Nazim Amirul wrote:
>> SoC without any interface, serial or storage or network, is close to
>> useless one.
>>
>> I don't see a point in having it in mainline. Serial is usually ABSOLUTE
>> minimum.
>>
>> Best regards,
>> Krzysztof
>>
> Hi Krzysztof,
> 
> Thank you for the review and fast response!
> 
> I ran both dt_binding_check and dtbs_check (with CHECK_DTBS=y) locally — 
> both passed without errors. Could you clarify which specific test you 
> believe is failing?

I would expect simple-bus schema warning or W=1, because node is placed
outside of soc@, but maybe there is no such.

> 
> Regarding "MMIO goes to MMIO" — are you referring to the GIC 

Comments are placed in very specific and intentional place. Please read
guides how mailing list in-line review works before posting patches.

> (interrupt-controller@7000000) being placed at the root level instead of 
> under the soc bus node?
> 
> Regarding the serial console — the platform clock driver is not yet 
> upstream, so the UART depends on clkmgr. Would adding the UART with 
> clock-frequency be acceptable as an interim solution?

Add complete working serial. Why can't you use fixed placeholder clock?
There are probably multiple ways to solve it, not necessary
clock-frequency and I do not even remember if clock-frequency is allowed.

But if you cannot bring serial, then my comment stays valid: this is
unusable upstream thus is not ready to be posted and merged.

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree

[Nazle Asmade, Muhammad Nazim Amirul]

On 24/6/2026 6:26 pm, Krzysztof Kozlowski wrote:
> On 24/06/2026 12:17, Nazle Asmade, Muhammad Nazim Amirul wrote:
>>> SoC without any interface, serial or storage or network, is close to
>>> useless one.
>>>
>>> I don't see a point in having it in mainline. Serial is usually ABSOLUTE
>>> minimum.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Hi Krzysztof,
>>
>> Thank you for the review and fast response!
>>
>> I ran both dt_binding_check and dtbs_check (with CHECK_DTBS=y) locally —
>> both passed without errors. Could you clarify which specific test you
>> believe is failing?
> 
> I would expect simple-bus schema warning or W=1, because node is placed
> outside of soc@, but maybe there is no such.
 > >>
>> Regarding "MMIO goes to MMIO" — are you referring to the GIC
> 
> Comments are placed in very specific and intentional place. Please read
> guides how mailing list in-line review works before posting patches.
Apologies on this matter.>
>> (interrupt-controller@7000000) being placed at the root level instead of
>> under the soc bus node?
>>
>> Regarding the serial console — the platform clock driver is not yet
>> upstream, so the UART depends on clkmgr. Would adding the UART with
>> clock-frequency be acceptable as an interim solution?
> 
> Add complete working serial. Why can't you use fixed placeholder clock?
> There are probably multiple ways to solve it, not necessary
> clock-frequency and I do not even remember if clock-frequency is allowed.
Will add a UART node with a fixed-clock placeholder>
> But if you cannot bring serial, then my comment stays valid: this is
> unusable upstream thus is not ready to be posted and merged.
> 
> Best regards,
> Krzysztof
Sorry I had to reply again to this thread due to not including all 
recipient just now. Also one thing to mention, this patch actually a V1 
version and latest should be v2 but it is just a device renaming change 
on the latest one so the comment still valid. Will send out v3 once it 
is ready! Thanks Krzysztof!

BR,
Nazim