All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Gong <wgong@codeaurora.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Johannes Berg <johannes.berg@intel.com>,
	kirtika@google.com, linux-wireless-owner@vger.kernel.org,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	Johannes Berg <johannes@sipsolutions.net>,
	ath11k@lists.infradead.org
Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable
Date: Fri, 13 Nov 2020 10:08:13 +0800	[thread overview]
Message-ID: <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> (raw)
In-Reply-To: <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com>

On 2020-11-12 20:49, Arend Van Spriel wrote:
> On 11/12/2020 11:55 AM, Wen Gong wrote:
>> On 2017-03-08 21:20, Johannes Berg wrote:
>>> From: Johannes Berg <johannes.berg@intel.com>
>>> 
> 
> [...]
> 
>>> @@ -2685,6 +2686,21 @@ static int ieee80211_set_bitrate_mask(struct
>>> wiphy *wiphy,
>>>              return ret;
>>>      }
>>> 
>>> +    /*
>>> +     * If active validate the setting and reject it if it doesn't 
>>> leave
>>> +     * at least one basic rate usable, since we really have to be 
>>> able
>>> +     * to send something, and if we're an AP we have to be able to 
>>> do
>>> +     * so at a basic rate so that all clients can receive it.
>>> +     */
>>> +    if (rcu_access_pointer(sdata->vif.chanctx_conf) &&
>>> +        sdata->vif.bss_conf.chandef.chan) {
>>> +        u32 basic_rates = sdata->vif.bss_conf.basic_rates;
>>> +        enum nl80211_band band = 
>>> sdata->vif.bss_conf.chandef.chan->band;
>>> +
>>> +        if (!(mask->control[band].legacy & basic_rates))
>>> +            return -EINVAL;
>> If user want to use “iw wlan0 set bitrates legacy-5 54” to set it to 
>> fixed in 54M and 54M is
>> not basic rate in AP's becaon as example of below, then the iw command 
>> will fail.
> 
> Which was the intent of this change, wasn't it? You want to allow
> anyway or you want a clear error message as to why it fails?
We need to set the tx rate to fixed at a single rate, e.g., 
54M/48M/36M... for a test case.
I do not want a clear error message, I want to the 54M rate pass/set 
success to lower wlan driver.
Then lower wlan driver can handle it.
> 
> Regards,
> Arend

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Johannes Berg <johannes.berg@intel.com>,
	kirtika@google.com, linux-wireless-owner@vger.kernel.org,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	Johannes Berg <johannes@sipsolutions.net>,
	ath11k@lists.infradead.org
Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable
Date: Fri, 13 Nov 2020 10:08:13 +0800	[thread overview]
Message-ID: <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> (raw)
In-Reply-To: <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com>

On 2020-11-12 20:49, Arend Van Spriel wrote:
> On 11/12/2020 11:55 AM, Wen Gong wrote:
>> On 2017-03-08 21:20, Johannes Berg wrote:
>>> From: Johannes Berg <johannes.berg@intel.com>
>>> 
> 
> [...]
> 
>>> @@ -2685,6 +2686,21 @@ static int ieee80211_set_bitrate_mask(struct
>>> wiphy *wiphy,
>>>              return ret;
>>>      }
>>> 
>>> +    /*
>>> +     * If active validate the setting and reject it if it doesn't 
>>> leave
>>> +     * at least one basic rate usable, since we really have to be 
>>> able
>>> +     * to send something, and if we're an AP we have to be able to 
>>> do
>>> +     * so at a basic rate so that all clients can receive it.
>>> +     */
>>> +    if (rcu_access_pointer(sdata->vif.chanctx_conf) &&
>>> +        sdata->vif.bss_conf.chandef.chan) {
>>> +        u32 basic_rates = sdata->vif.bss_conf.basic_rates;
>>> +        enum nl80211_band band = 
>>> sdata->vif.bss_conf.chandef.chan->band;
>>> +
>>> +        if (!(mask->control[band].legacy & basic_rates))
>>> +            return -EINVAL;
>> If user want to use “iw wlan0 set bitrates legacy-5 54” to set it to 
>> fixed in 54M and 54M is
>> not basic rate in AP's becaon as example of below, then the iw command 
>> will fail.
> 
> Which was the intent of this change, wasn't it? You want to allow
> anyway or you want a clear error message as to why it fails?
We need to set the tx rate to fixed at a single rate, e.g., 
54M/48M/36M... for a test case.
I do not want a clear error message, I want to the 54M rate pass/set 
success to lower wlan driver.
Then lower wlan driver can handle it.
> 
> Regards,
> Arend

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, kirtika@google.com,
	Johannes Berg <johannes.berg@intel.com>,
	linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable
Date: Fri, 13 Nov 2020 10:08:13 +0800	[thread overview]
Message-ID: <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> (raw)
In-Reply-To: <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com>

On 2020-11-12 20:49, Arend Van Spriel wrote:
> On 11/12/2020 11:55 AM, Wen Gong wrote:
>> On 2017-03-08 21:20, Johannes Berg wrote:
>>> From: Johannes Berg <johannes.berg@intel.com>
>>> 
> 
> [...]
> 
>>> @@ -2685,6 +2686,21 @@ static int ieee80211_set_bitrate_mask(struct
>>> wiphy *wiphy,
>>>              return ret;
>>>      }
>>> 
>>> +    /*
>>> +     * If active validate the setting and reject it if it doesn't 
>>> leave
>>> +     * at least one basic rate usable, since we really have to be 
>>> able
>>> +     * to send something, and if we're an AP we have to be able to 
>>> do
>>> +     * so at a basic rate so that all clients can receive it.
>>> +     */
>>> +    if (rcu_access_pointer(sdata->vif.chanctx_conf) &&
>>> +        sdata->vif.bss_conf.chandef.chan) {
>>> +        u32 basic_rates = sdata->vif.bss_conf.basic_rates;
>>> +        enum nl80211_band band = 
>>> sdata->vif.bss_conf.chandef.chan->band;
>>> +
>>> +        if (!(mask->control[band].legacy & basic_rates))
>>> +            return -EINVAL;
>> If user want to use “iw wlan0 set bitrates legacy-5 54” to set it to 
>> fixed in 54M and 54M is
>> not basic rate in AP's becaon as example of below, then the iw command 
>> will fail.
> 
> Which was the intent of this change, wasn't it? You want to allow
> anyway or you want a clear error message as to why it fails?
We need to set the tx rate to fixed at a single rate, e.g., 
54M/48M/36M... for a test case.
I do not want a clear error message, I want to the 54M rate pass/set 
success to lower wlan driver.
Then lower wlan driver can handle it.
> 
> Regards,
> Arend

  reply	other threads:[~2020-11-13  2:08 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 13:20 [PATCH v2] mac80211: reject/clear user rate mask if not usable Johannes Berg
2020-11-12 10:55 ` Wen Gong
2020-11-12 10:55   ` Wen Gong
2020-11-12 10:55   ` Wen Gong
2020-11-12 12:49   ` Arend Van Spriel
2020-11-12 12:49     ` Arend Van Spriel
2020-11-12 12:49     ` Arend Van Spriel
2020-11-13  2:08     ` Wen Gong [this message]
2020-11-13  2:08       ` Wen Gong
2020-11-13  2:08       ` Wen Gong
2020-11-13  7:38       ` Johannes Berg
2020-11-13  7:38         ` Johannes Berg
2020-11-13  7:38         ` Johannes Berg
2020-11-13  8:14         ` Wen Gong
2020-11-13  8:14           ` Wen Gong
2020-11-13  8:14           ` Wen Gong
2020-11-13  8:16           ` Johannes Berg
2020-11-13  8:16             ` Johannes Berg
2020-11-13  8:16             ` Johannes Berg
2020-11-13  8:35             ` Wen Gong
2020-11-13  8:35               ` Wen Gong
2020-11-13  8:35               ` Wen Gong
2020-11-13  8:35               ` Johannes Berg
2020-11-13  8:35                 ` Johannes Berg
2020-11-13  8:35                 ` Johannes Berg
2020-11-13  8:51                 ` Wen Gong
2020-11-13  8:51                   ` Wen Gong
2020-11-13  8:51                   ` Wen Gong
2020-11-13  8:51                   ` Johannes Berg
2020-11-13  8:51                     ` Johannes Berg
2020-11-13  8:51                     ` Johannes Berg
2020-11-13  9:09                     ` Wen Gong
2020-11-13  9:09                       ` Wen Gong
2020-11-13  9:09                       ` Wen Gong
2020-11-13  9:10                       ` Johannes Berg
2020-11-13  9:10                         ` Johannes Berg
2020-11-13  9:10                         ` Johannes Berg
2020-11-13  9:21                         ` Wen Gong
2020-11-13  9:21                           ` Wen Gong
2020-11-13  9:21                           ` Wen Gong
2020-11-13  9:23                           ` Johannes Berg
2020-11-13  9:23                             ` Johannes Berg
2020-11-13  9:23                             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b8f37fde23262547edb6ed4635cf89b@codeaurora.org \
    --to=wgong@codeaurora.org \
    --cc=arend.vanspriel@broadcom.com \
    --cc=ath10k@lists.infradead.org \
    --cc=ath11k@lists.infradead.org \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=kirtika@google.com \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.