From: Jens Axboe <axboe@kernel.dk>
To: Kohei Enju <enjuk@amazon.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Cc: Damien Le Moal <damien.lemoal@wdc.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Kohei Enju <kohei.enju@gmail.com>
Subject: Re: [f2fs-dev] [PATCH v1] f2fs: remove unnecessary null checking
Date: Sun, 2 Feb 2025 08:05:11 -0700 [thread overview]
Message-ID: <4c45eff4-e87a-4eff-a760-b3b7d86b1987@kernel.dk> (raw)
In-Reply-To: <20250202043253.64389-1-enjuk@amazon.com>
On 2/1/25 9:32 PM, Kohei Enju wrote:
> When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is
> specified, bio_alloc_bioset() never fails to allocate a bio.
> Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced
> f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after
> bio_alloc_bioset() was still left.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Kohei Enju <enjuk@amazon.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Damien Le Moal <damien.lemoal@wdc.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Kohei Enju <kohei.enju@gmail.com>
Subject: Re: [PATCH v1] f2fs: remove unnecessary null checking
Date: Sun, 2 Feb 2025 08:05:11 -0700 [thread overview]
Message-ID: <4c45eff4-e87a-4eff-a760-b3b7d86b1987@kernel.dk> (raw)
In-Reply-To: <20250202043253.64389-1-enjuk@amazon.com>
On 2/1/25 9:32 PM, Kohei Enju wrote:
> When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is
> specified, bio_alloc_bioset() never fails to allocate a bio.
> Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced
> f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after
> bio_alloc_bioset() was still left.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2025-02-02 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-02 4:32 [f2fs-dev] [PATCH v1] f2fs: remove unnecessary null checking Kohei Enju via Linux-f2fs-devel
2025-02-02 4:32 ` Kohei Enju
2025-02-02 14:20 ` [f2fs-dev] [PATCH] " Markus Elfring via Linux-f2fs-devel
2025-02-02 14:20 ` Markus Elfring
2025-02-02 15:05 ` Jens Axboe [this message]
2025-02-02 15:05 ` [PATCH v1] " Jens Axboe
2025-02-06 1:59 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-02-06 1:59 ` Chao Yu
2025-02-06 18:40 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-02-06 18:40 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c45eff4-e87a-4eff-a760-b3b7d86b1987@kernel.dk \
--to=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=enjuk@amazon.com \
--cc=jaegeuk@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=kohei.enju@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.