All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [oe] [meta-oe][PATCH] Disable FASTCV HAL implementation
  2025-02-10  7:53 Pulkit Singh Tak
@ 2025-02-10  8:45 ` Gyorgy Sarvari
  2025-02-10 16:41   ` Khem Raj
  0 siblings, 1 reply; 3+ messages in thread
From: Gyorgy Sarvari @ 2025-02-10  8:45 UTC (permalink / raw)
  To: quic_ptak, openembedded-devel; +Cc: quic_sssanjee, quic_vkaruchu

> +#Fastcv based Opencv HAL/Extensions are not supported on all platforms, hence disabling it by default
> +PACKAGECONFIG[fastcv] = "-DWITH_FASTCV=ON,-DWITH_FASTCV=OFF,,"
Is there a dependency missing? Using this new packageconfig fails with
the following error during do_configuration:

| -- FASTCV: Downloading fastcv_linux_aarch64_2024_12_11.tgz from
https://raw.githubusercontent.com/opencv/opencv_3rdparty/dc5d58018f3af915a8d209386d2c58c0501c0f2c/fastcv/fastcv_linux_aarch64_2024_12_11.tgz
| CMake Error at cmake/OpenCVDownload.cmake:210 (message):
|   Not going to download fastcv_linux_aarch64_2024_12_11.tgz
| Call Stack (most recent call first):
|   3rdparty/fastcv/fastcv.cmake:29 (ocv_download)
|   cmake/OpenCVFindLibsPerf.cmake:188 (download_fastcv)
|   CMakeLists.txt:800 (include)
|
|
| -- Configuring incomplete, errors occurred!


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [oe] [meta-oe][PATCH] Disable FASTCV HAL implementation
       [not found] <23700.1739182003353626062@lists.openembedded.org>
@ 2025-02-10 10:27 ` Gyorgy Sarvari
  0 siblings, 0 replies; 3+ messages in thread
From: Gyorgy Sarvari @ 2025-02-10 10:27 UTC (permalink / raw)
  To: openembedded-devel@lists.openembedded.org

(Please keep the discussion on the mailing list)

I have enabled the fastcv PACKAGECONFIG in my run, since that's the
point of having it, isn't it? With that it has -DWITH_FASTCV=ON amonst
the CMake flags, and that part seems to work as it should.
Did enabling this new PACKAGECONFIG flag work for you?

-------- Forwarded Message --------

Hi, 
 
It should not download the tar file when FastCV is disabled.  Try
sourcing the env again and check for the flag : DWITH_FASTCV=OFF in the
configure file.
 
On Mon, Feb 10, 2025 at 12:45 AM, Gyorgy Sarvari wrote:

        +#Fastcv based Opencv HAL/Extensions are not supported on all
        platforms, hence disabling it by default
        +PACKAGECONFIG[fastcv] = "-DWITH_FASTCV=ON,-DWITH_FASTCV=OFF,,"

    Is there a dependency missing? Using this new packageconfig fails with
    the following error during do_configuration:

    | -- FASTCV: Downloading fastcv_linux_aarch64_2024_12_11.tgz from
    https://raw.githubusercontent.com/opencv/opencv_3rdparty/dc5d58018f3af915a8d209386d2c58c0501c0f2c/fastcv/fastcv_linux_aarch64_2024_12_11.tgz
    | CMake Error at cmake/OpenCVDownload.cmake:210 (message):
    |   Not going to download fastcv_linux_aarch64_2024_12_11.tgz
    | Call Stack (most recent call first):
    |   3rdparty/fastcv/fastcv.cmake:29 (ocv_download)
    |   cmake/OpenCVFindLibsPerf.cmake:188 (download_fastcv)
    |   CMakeLists.txt:800 (include)
    |
    |
    | -- Configuring incomplete, errors occurred!



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [oe] [meta-oe][PATCH] Disable FASTCV HAL implementation
  2025-02-10  8:45 ` [oe] " Gyorgy Sarvari
@ 2025-02-10 16:41   ` Khem Raj
  0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2025-02-10 16:41 UTC (permalink / raw)
  To: skandigraun; +Cc: quic_ptak, openembedded-devel, quic_sssanjee, quic_vkaruchu

On Mon, Feb 10, 2025 at 12:45 AM Gyorgy Sarvari via
lists.openembedded.org <skandigraun=gmail.com@lists.openembedded.org>
wrote:
>
> > +#Fastcv based Opencv HAL/Extensions are not supported on all platforms, hence disabling it by default
> > +PACKAGECONFIG[fastcv] = "-DWITH_FASTCV=ON,-DWITH_FASTCV=OFF,,"
> Is there a dependency missing? Using this new packageconfig fails with
> the following error during do_configuration:

I think we need to download it along with other dependencies in
SRC_URI or provide a separate recipe for fastcv, at times we have
housed dependencies in packageconfig which may come
from other layers as long as they are off by default. In fastcv's case
I think the recipe does not exist in any known layer either.
my intention was to add a note so we remember why we disabled it so
perhaps just adding a comment would be fine.

>
> | -- FASTCV: Downloading fastcv_linux_aarch64_2024_12_11.tgz from
> https://raw.githubusercontent.com/opencv/opencv_3rdparty/dc5d58018f3af915a8d209386d2c58c0501c0f2c/fastcv/fastcv_linux_aarch64_2024_12_11.tgz
> | CMake Error at cmake/OpenCVDownload.cmake:210 (message):
> |   Not going to download fastcv_linux_aarch64_2024_12_11.tgz
> | Call Stack (most recent call first):
> |   3rdparty/fastcv/fastcv.cmake:29 (ocv_download)
> |   cmake/OpenCVFindLibsPerf.cmake:188 (download_fastcv)
> |   CMakeLists.txt:800 (include)
> |
> |
> | -- Configuring incomplete, errors occurred!
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#115328): https://lists.openembedded.org/g/openembedded-devel/message/115328
> Mute This Topic: https://lists.openembedded.org/mt/111098636/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-10 16:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <23700.1739182003353626062@lists.openembedded.org>
2025-02-10 10:27 ` [oe] [meta-oe][PATCH] Disable FASTCV HAL implementation Gyorgy Sarvari
2025-02-10  7:53 Pulkit Singh Tak
2025-02-10  8:45 ` [oe] " Gyorgy Sarvari
2025-02-10 16:41   ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.