Re: [oe] [meta-oe][PATCH] Disable FASTCV HAL implementation

Re: [oe] [meta-oe][PATCH] Disable FASTCV HAL implementation

[Gyorgy Sarvari]

(Please keep the discussion on the mailing list)

I have enabled the fastcv PACKAGECONFIG in my run, since that's the
point of having it, isn't it? With that it has -DWITH_FASTCV=ON amonst
the CMake flags, and that part seems to work as it should.
Did enabling this new PACKAGECONFIG flag work for you?

-------- Forwarded Message --------

Hi, 
 
It should not download the tar file when FastCV is disabled.  Try
sourcing the env again and check for the flag : DWITH_FASTCV=OFF in the
configure file.
 
On Mon, Feb 10, 2025 at 12:45 AM, Gyorgy Sarvari wrote:

        +#Fastcv based Opencv HAL/Extensions are not supported on all
        platforms, hence disabling it by default
        +PACKAGECONFIG[fastcv] = "-DWITH_FASTCV=ON,-DWITH_FASTCV=OFF,,"

    Is there a dependency missing? Using this new packageconfig fails with
    the following error during do_configuration:

    | -- FASTCV: Downloading fastcv_linux_aarch64_2024_12_11.tgz from
    https://raw.githubusercontent.com/opencv/opencv_3rdparty/dc5d58018f3af915a8d209386d2c58c0501c0f2c/fastcv/fastcv_linux_aarch64_2024_12_11.tgz
    | CMake Error at cmake/OpenCVDownload.cmake:210 (message):
    |   Not going to download fastcv_linux_aarch64_2024_12_11.tgz
    | Call Stack (most recent call first):
    |   3rdparty/fastcv/fastcv.cmake:29 (ocv_download)
    |   cmake/OpenCVFindLibsPerf.cmake:188 (download_fastcv)
    |   CMakeLists.txt:800 (include)
    |
    |
    | -- Configuring incomplete, errors occurred!

[meta-oe][PATCH] Disable FASTCV HAL implementation

[Pulkit Singh Tak]

Adding FastCV in packageconfig option
Fastcv based Opencv HAL/Extensions are not supported on all platforms.
By default Upstream OpenCV expects it to be disabled.

Signed-off-by: Pulkit Singh Tak <quic_ptak@quicinc.com>
---
 meta-oe/recipes-support/opencv/opencv_4.11.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/opencv/opencv_4.11.0.bb b/meta-oe/recipes-support/opencv/opencv_4.11.0.bb
index 07b3a9d9e6..97dccfe2fb 100644
--- a/meta-oe/recipes-support/opencv/opencv_4.11.0.bb
+++ b/meta-oe/recipes-support/opencv/opencv_4.11.0.bb
@@ -70,7 +70,6 @@ EXTRA_OECMAKE = "-DOPENCV_EXTRA_MODULES_PATH=${S}/contrib/modules \
     -DENABLE_PRECOMPILED_HEADERS=OFF \
     -DCMAKE_SKIP_RPATH=ON \
     -DWITH_IPP=OFF \
-    -DWITH_FASTCV=OFF \
     -DOPENCV_GENERATE_PKGCONFIG=ON \
     -DOPENCV_DOWNLOAD_PATH=${OPENCV_DLDIR} \
     -DOPENCV_ALLOW_DOWNLOADS=OFF \
@@ -121,6 +120,8 @@ PACKAGECONFIG[tests] = "-DBUILD_TESTS=ON,-DBUILD_TESTS=OFF,,"
 PACKAGECONFIG[text] = "-DBUILD_opencv_text=ON,-DBUILD_opencv_text=OFF,tesseract,"
 PACKAGECONFIG[tiff] = "-DWITH_TIFF=ON,-DWITH_TIFF=OFF,tiff,"
 PACKAGECONFIG[v4l] = "-DWITH_V4L=ON,-DWITH_V4L=OFF,v4l-utils,"
+#Fastcv based Opencv HAL/Extensions are not supported on all platforms, hence disabling it by default
+PACKAGECONFIG[fastcv] = "-DWITH_FASTCV=ON,-DWITH_FASTCV=OFF,,"
 
 inherit pkgconfig cmake setuptools3-base python3native
 
-- 
2.34.1

Re: [oe] [meta-oe][PATCH] Disable FASTCV HAL implementation

[Gyorgy Sarvari]

> +#Fastcv based Opencv HAL/Extensions are not supported on all platforms, hence disabling it by default
> +PACKAGECONFIG[fastcv] = "-DWITH_FASTCV=ON,-DWITH_FASTCV=OFF,,"
Is there a dependency missing? Using this new packageconfig fails with
the following error during do_configuration:

| -- FASTCV: Downloading fastcv_linux_aarch64_2024_12_11.tgz from
https://raw.githubusercontent.com/opencv/opencv_3rdparty/dc5d58018f3af915a8d209386d2c58c0501c0f2c/fastcv/fastcv_linux_aarch64_2024_12_11.tgz
| CMake Error at cmake/OpenCVDownload.cmake:210 (message):
|   Not going to download fastcv_linux_aarch64_2024_12_11.tgz
| Call Stack (most recent call first):
|   3rdparty/fastcv/fastcv.cmake:29 (ocv_download)
|   cmake/OpenCVFindLibsPerf.cmake:188 (download_fastcv)
|   CMakeLists.txt:800 (include)
|
|
| -- Configuring incomplete, errors occurred!

Re: [oe] [meta-oe][PATCH] Disable FASTCV HAL implementation

[Khem Raj]

On Mon, Feb 10, 2025 at 12:45 AM Gyorgy Sarvari via
lists.openembedded.org <skandigraun=gmail.com@lists.openembedded.org>
wrote:
>
> > +#Fastcv based Opencv HAL/Extensions are not supported on all platforms, hence disabling it by default
> > +PACKAGECONFIG[fastcv] = "-DWITH_FASTCV=ON,-DWITH_FASTCV=OFF,,"
> Is there a dependency missing? Using this new packageconfig fails with
> the following error during do_configuration:

I think we need to download it along with other dependencies in
SRC_URI or provide a separate recipe for fastcv, at times we have
housed dependencies in packageconfig which may come
from other layers as long as they are off by default. In fastcv's case
I think the recipe does not exist in any known layer either.
my intention was to add a note so we remember why we disabled it so
perhaps just adding a comment would be fine.

>
> | -- FASTCV: Downloading fastcv_linux_aarch64_2024_12_11.tgz from
> https://raw.githubusercontent.com/opencv/opencv_3rdparty/dc5d58018f3af915a8d209386d2c58c0501c0f2c/fastcv/fastcv_linux_aarch64_2024_12_11.tgz
> | CMake Error at cmake/OpenCVDownload.cmake:210 (message):
> |   Not going to download fastcv_linux_aarch64_2024_12_11.tgz
> | Call Stack (most recent call first):
> |   3rdparty/fastcv/fastcv.cmake:29 (ocv_download)
> |   cmake/OpenCVFindLibsPerf.cmake:188 (download_fastcv)
> |   CMakeLists.txt:800 (include)
> |
> |
> | -- Configuring incomplete, errors occurred!
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#115328): https://lists.openembedded.org/g/openembedded-devel/message/115328
> Mute This Topic: https://lists.openembedded.org/mt/111098636/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>