All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>, alim.akhtar@samsung.com
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] ARM: dts: s5pv210: Adjust I2S entries to match spec
Date: Wed, 23 Mar 2022 16:14:36 +0100	[thread overview]
Message-ID: <4ebe2bb9-4f92-2dff-6737-d057e5950b24@kernel.org> (raw)
In-Reply-To: <CY4PR04MB056784D54ADDBB4F57F82D4ACB189@CY4PR04MB0567.namprd04.prod.outlook.com>

On 23/03/2022 16:03, Jonathan Bakker wrote:
> Based on the device tree spec, clocks should be ordered tx/rx.
> Re-order from rx/tx to avoid warnings when running make dtbs_check
> 
> Additionally, the number of #sound-dai-cells should be 1, not 0
> 
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> ---
>  arch/arm/boot/dts/s5pv210-aries.dtsi |  2 +-
>  arch/arm/boot/dts/s5pv210.dtsi       | 18 +++++++++---------
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> index 70ff56daf4cb..503b5a50ef1a 100644
> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> @@ -644,7 +644,7 @@
>  };
>  
>  &i2s0 {
> -	dmas = <&pdma0 9>, <&pdma0 10>, <&pdma0 11>;
> +	dmas = <&pdma0 10>, <&pdma0 9>, <&pdma0 11>;
>  	status = "okay";

Except that fix that's the same commit as here:
https://lore.kernel.org/all/20200907161141.31034-26-krzk@kernel.org/
so just extend it.

sound-dai-cells should go to a separate commit. But are you sure they
are correct? The Fascinate 4G seems to be using them as cells=0.


Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>, alim.akhtar@samsung.com
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] ARM: dts: s5pv210: Adjust I2S entries to match spec
Date: Wed, 23 Mar 2022 16:14:36 +0100	[thread overview]
Message-ID: <4ebe2bb9-4f92-2dff-6737-d057e5950b24@kernel.org> (raw)
In-Reply-To: <CY4PR04MB056784D54ADDBB4F57F82D4ACB189@CY4PR04MB0567.namprd04.prod.outlook.com>

On 23/03/2022 16:03, Jonathan Bakker wrote:
> Based on the device tree spec, clocks should be ordered tx/rx.
> Re-order from rx/tx to avoid warnings when running make dtbs_check
> 
> Additionally, the number of #sound-dai-cells should be 1, not 0
> 
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> ---
>  arch/arm/boot/dts/s5pv210-aries.dtsi |  2 +-
>  arch/arm/boot/dts/s5pv210.dtsi       | 18 +++++++++---------
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> index 70ff56daf4cb..503b5a50ef1a 100644
> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> @@ -644,7 +644,7 @@
>  };
>  
>  &i2s0 {
> -	dmas = <&pdma0 9>, <&pdma0 10>, <&pdma0 11>;
> +	dmas = <&pdma0 10>, <&pdma0 9>, <&pdma0 11>;
>  	status = "okay";

Except that fix that's the same commit as here:
https://lore.kernel.org/all/20200907161141.31034-26-krzk@kernel.org/
so just extend it.

sound-dai-cells should go to a separate commit. But are you sure they
are correct? The Fascinate 4G seems to be using them as cells=0.


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-23 15:14 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220322201144.20320-1-xc-racer2@live.ca>
2022-03-22 20:11 ` [PATCH 1/7] ARM: dts: s5pv210: Split memory nodes to match spec Jonathan Bakker
2022-03-22 20:11   ` Jonathan Bakker
2022-03-23 10:54   ` Krzysztof Kozlowski
2022-03-23 10:54     ` Krzysztof Kozlowski
2022-03-23 14:59     ` Jonathan Bakker
2022-03-23 14:59       ` Jonathan Bakker
2022-03-23 15:06       ` Krzysztof Kozlowski
2022-03-23 15:06         ` Krzysztof Kozlowski
2022-03-23 17:05         ` Jonathan Bakker
2022-03-23 17:05           ` Jonathan Bakker
2022-03-24 11:23           ` Krzysztof Kozlowski
2022-03-24 11:23             ` Krzysztof Kozlowski
2022-03-23 15:03   ` [PATCH 2/7] ARM: dts: s5pv210: Adjust I2S entries " Jonathan Bakker
2022-03-23 15:03     ` Jonathan Bakker
2022-03-23 15:14     ` Krzysztof Kozlowski [this message]
2022-03-23 15:14       ` Krzysztof Kozlowski
2022-03-23 15:15       ` Krzysztof Kozlowski
2022-03-23 15:15         ` Krzysztof Kozlowski
2022-03-23 17:24         ` Jonathan Bakker
2022-03-23 17:24           ` Jonathan Bakker
2022-03-24 11:49           ` Krzysztof Kozlowski
2022-03-24 11:49             ` Krzysztof Kozlowski
2023-04-21  9:44             ` Krzysztof Kozlowski
2023-04-21  9:44               ` Krzysztof Kozlowski
2023-05-03  2:33               ` Jonathan Bakker
2023-05-03  2:33                 ` Jonathan Bakker
     [not found]   ` <20220323150311.26699-1-xc-racer2@live.ca>
2022-03-23 15:03     ` [PATCH 3/7] ARM: dts: s5pv210: Adjust DMA node names " Jonathan Bakker
2022-03-23 15:03       ` Jonathan Bakker
2022-03-23 15:03     ` [PATCH 4/7] ARM: dts: s5pv210: Remove spi-cs-high on panel in Aries Jonathan Bakker
2022-03-23 15:03       ` Jonathan Bakker
2022-03-23 15:22       ` Krzysztof Kozlowski
2022-03-23 15:22         ` Krzysztof Kozlowski
2022-03-23 15:03     ` [PATCH 5/7] ARM: dts: s5pv210: Correct interrupt name for bluetooth " Jonathan Bakker
2022-03-23 15:03       ` Jonathan Bakker
2022-03-23 15:23       ` krzk
2022-03-23 15:23         ` krzk
2022-03-23 15:03     ` [PATCH 6/7] ARM: dts: s5pv210: Add charger regulator to max8998 " Jonathan Bakker
2022-03-23 15:03       ` Jonathan Bakker
2022-03-23 15:03     ` [PATCH 7/7] ARM: dts: s5pv210: Add charger support " Jonathan Bakker
2022-03-23 15:03       ` Jonathan Bakker
2022-03-23 15:31       ` krzk
2022-03-23 15:31         ` krzk
2022-03-23 17:20         ` Jonathan Bakker
2022-03-23 17:20           ` Jonathan Bakker
2022-03-24 11:47           ` Krzysztof Kozlowski
2022-03-24 11:47             ` Krzysztof Kozlowski
2022-03-25  2:23             ` Jonathan Bakker
2022-03-25  2:23               ` Jonathan Bakker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ebe2bb9-4f92-2dff-6737-d057e5950b24@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=xc-racer2@live.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.