Re: [Intel-wired-lan] [RFC PATCH v9 00/10] Create common DPLL configuration API

From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "geert+renesas@glider.be" <geert+renesas@glider.be>,
	"mst@redhat.com" <mst@redhat.com>,
	"razor@blackwall.org" <razor@blackwall.org>,
	"phil@nwl.cc" <phil@nwl.cc>,
	"javierm@redhat.com" <javierm@redhat.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"lucien.xin@gmail.com" <lucien.xin@gmail.com>,
	"leon@kernel.org" <leon@kernel.org>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"masahiroy@kernel.org" <masahiroy@kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
	"vadfed@meta.com" <vadfed@meta.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"airlied@redhat.com" <airlied@redhat.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"ricardo.canuelo@collabora.com" <ricardo.canuelo@collabora.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"idosch@nvidia.com" <idosch@nvidia.com>,
	"richardcochran@gmail.com" <richardcochran@gmail.com>,
	"claudiajkang@gmail.com" <claudiajkang@gmail.com>,
	"kuniyu@amazon.com" <kuniyu@amazon.com>,
	"jacek.lawrynowicz@linux.intel.com"
	<jacek.lawrynowicz@linux.intel.com>,
	"liuhangbin@gmail.com" <liuhangbin@gmail.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"nicolas.dichtel@6wind.com" <nicolas.dichtel@6wind.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"sj@kernel.org" <sj@kernel.org>, "linux@zary.sk" <linux@zary.sk>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"ogabbay@kernel.org" <ogabbay@kernel.org>,
	"nipun.gupta@amd.com" <nipun.gupta@amd.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"jonathan.lemon@gmail.com" <jonathan.lemon@gmail.com>,
	"M, Saeed" <saeedm@nvidia.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"Olech, Milena" <milena.olech@intel.com>,
	"hkallweit1@gmail.com" <hkallweit1@gmail.com>
Subject: Re: [Intel-wired-lan] [RFC PATCH v9 00/10] Create common DPLL configuration API
Date: Wed, 28 Jun 2023 14:22:00 +0100	[thread overview]
Message-ID: <4ebfa74e-8998-a1af-e6b9-3701008900ec@linux.dev> (raw)
In-Reply-To: <ZJwxHucKMwCQMMVM@nanopsycho>

On 28/06/2023 14:09, Jiri Pirko wrote:
> Wed, Jun 28, 2023 at 01:11:19PM CEST, vadim.fedorenko@linux.dev wrote:
>> On 28/06/2023 10:27, Kubalewski, Arkadiusz wrote:
>>>> From: Kubalewski, Arkadiusz
>>>> Sent: Wednesday, June 28, 2023 11:15 AM
>>>>
>>>>> From: Jiri Pirko <jiri@resnulli.us>
>>>>> Sent: Tuesday, June 27, 2023 12:18 PM
>>>>>
>>>>> Fri, Jun 23, 2023 at 02:38:10PM CEST, arkadiusz.kubalewski@intel.com
>>>> wrote:
>>>>>
>>>>>> v8 -> v9:
>>>>>
>>>>> Could you please address all the unresolved issues from v8 and send v10?
>>>>> I'm not reviewing this one.
>>>>>
>>>>> Thanks!
>>>>
>>>> Sure, will do, but first missing to-do/discuss list:
>>>> 1) remove mode_set as not used by any driver
>>>> 2) remove "no-added-value" static functions descriptions in
>>>>     dpll_core/dpll_netlink
>>>> 3) merge patches [ 03/10, 04/10, 05/10 ] into patches that are compiling
>>>>     after each patch apply
>>>> 4) remove function return values descriptions/lists
>>>> 5) Fix patch [05/10]:
>>>>     - status Supported
>>>>     - additional maintainers
>>>>     - remove callback:
>>>>       int (*source_pin_idx_get)(...) from `struct dpll_device_ops`
>>>> 6) Fix patch [08/10]: rethink ice mutex locking scheme
>>>> 7) Fix patch [09/10]: multiple comments on
>>>> https://lore.kernel.org/netdev/ZIQu+%2Fo4J0ZBspVg@nanopsycho/#t
>>>> 8) add PPS DPLL phase offset to the netlink get-device API
>>>>
>>>> Thank you!
>>>> Arkadiusz
>>>
>>> If someone has any objections please state them now, I will work on
>>> all above except 5) and 7).
>>> Vadim, could you take care of those 2 points?
>>>
>> Yeah, sure, I'll update 5 and 7.
>> I'm not sure about 8) - do we really need this info, I believe every
>> supported DPLL device exports PTP device as well. But I'm Ok to add this
>> feature too.
> 
> Could you add the notification work while you are at it? I don't want
> that to be forgotten. Thanks!

Sure, Jiri, I'm working on it for ptp_ocp.

>>
>>> Thank you!
>>> Arkadiusz
>>

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan