From: Matthias Brugger <matthias.bgg@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Michael Kao <michael.kao@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Eduardo Valentin <edubezval@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, hsinyi@chromium.org,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3,1/8] arm64: dts: mt8183: add thermal zone node
Date: Thu, 20 Feb 2020 21:57:26 +0100 [thread overview]
Message-ID: <4fab7d40-d7d9-883e-1c50-0507ee1dd750@gmail.com> (raw)
In-Reply-To: <270efbcf-51bb-629f-c64b-fa343b3d2988@linaro.org>
On 20/02/2020 12:52, Daniel Lezcano wrote:
> On 11/02/2020 04:17, Michael Kao wrote:
>> On Thu, 2020-01-09 at 12:31 +0100, Daniel Lezcano wrote:
>>> On 03/01/2020 07:44, Michael Kao wrote:
>>>> From: "michael.kao" <michael.kao@mediatek.com>
>>>>
>>>> Add thermal zone node to Mediatek MT8183 dts file.
>>>>
>>>> Signed-off-by: Michael Kao <michael.kao@mediatek.com>
>>>> ---
>>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 85 ++++++++++++++++++++++++
>>>> 1 file changed, 85 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>> index 10b32471bc7b..a2793cf3d994 100644
>>>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>> @@ -570,6 +570,88 @@
>>>> status = "disabled";
>>>> };
>>>>
>>>> + thermal: thermal@1100b000 {
>>>> + #thermal-sensor-cells = <1>;
>>>> + compatible = "mediatek,mt8183-thermal";
>>>> + reg = <0 0x1100b000 0 0x1000>;
>>>> + interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>;
>>>
>>> What is this interrupt for?
>>
>> The interrupts pin is designed in our SoC. But it is not used in our
>> upstream thermal code now. There is also add the settings but not use
>> for mt8173.dtsi. To align the thermal dtsi format, I follow the past
>> experience to add the interrupt settings of this project first.
>
> Assuming the interrupt can be set by the driver to fire when a specified
> temperature is set, I suggest to change your driver to handle it so you
> can get rid of the polling waking up the SoC every second.
>
For the record the interrupt is a required property by the binding description.
Regards,
Matthias
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Michael Kao <michael.kao@mediatek.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
hsinyi@chromium.org, linux-pm@vger.kernel.org,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3,1/8] arm64: dts: mt8183: add thermal zone node
Date: Thu, 20 Feb 2020 21:57:26 +0100 [thread overview]
Message-ID: <4fab7d40-d7d9-883e-1c50-0507ee1dd750@gmail.com> (raw)
In-Reply-To: <270efbcf-51bb-629f-c64b-fa343b3d2988@linaro.org>
On 20/02/2020 12:52, Daniel Lezcano wrote:
> On 11/02/2020 04:17, Michael Kao wrote:
>> On Thu, 2020-01-09 at 12:31 +0100, Daniel Lezcano wrote:
>>> On 03/01/2020 07:44, Michael Kao wrote:
>>>> From: "michael.kao" <michael.kao@mediatek.com>
>>>>
>>>> Add thermal zone node to Mediatek MT8183 dts file.
>>>>
>>>> Signed-off-by: Michael Kao <michael.kao@mediatek.com>
>>>> ---
>>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 85 ++++++++++++++++++++++++
>>>> 1 file changed, 85 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>> index 10b32471bc7b..a2793cf3d994 100644
>>>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>> @@ -570,6 +570,88 @@
>>>> status = "disabled";
>>>> };
>>>>
>>>> + thermal: thermal@1100b000 {
>>>> + #thermal-sensor-cells = <1>;
>>>> + compatible = "mediatek,mt8183-thermal";
>>>> + reg = <0 0x1100b000 0 0x1000>;
>>>> + interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>;
>>>
>>> What is this interrupt for?
>>
>> The interrupts pin is designed in our SoC. But it is not used in our
>> upstream thermal code now. There is also add the settings but not use
>> for mt8173.dtsi. To align the thermal dtsi format, I follow the past
>> experience to add the interrupt settings of this project first.
>
> Assuming the interrupt can be set by the driver to fire when a specified
> temperature is set, I suggest to change your driver to handle it so you
> can get rid of the polling waking up the SoC every second.
>
For the record the interrupt is a required property by the binding description.
Regards,
Matthias
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Michael Kao <michael.kao@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Eduardo Valentin <edubezval@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, hsinyi@chromium.org,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3,1/8] arm64: dts: mt8183: add thermal zone node
Date: Thu, 20 Feb 2020 21:57:26 +0100 [thread overview]
Message-ID: <4fab7d40-d7d9-883e-1c50-0507ee1dd750@gmail.com> (raw)
In-Reply-To: <270efbcf-51bb-629f-c64b-fa343b3d2988@linaro.org>
On 20/02/2020 12:52, Daniel Lezcano wrote:
> On 11/02/2020 04:17, Michael Kao wrote:
>> On Thu, 2020-01-09 at 12:31 +0100, Daniel Lezcano wrote:
>>> On 03/01/2020 07:44, Michael Kao wrote:
>>>> From: "michael.kao" <michael.kao@mediatek.com>
>>>>
>>>> Add thermal zone node to Mediatek MT8183 dts file.
>>>>
>>>> Signed-off-by: Michael Kao <michael.kao@mediatek.com>
>>>> ---
>>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 85 ++++++++++++++++++++++++
>>>> 1 file changed, 85 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>> index 10b32471bc7b..a2793cf3d994 100644
>>>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>> @@ -570,6 +570,88 @@
>>>> status = "disabled";
>>>> };
>>>>
>>>> + thermal: thermal@1100b000 {
>>>> + #thermal-sensor-cells = <1>;
>>>> + compatible = "mediatek,mt8183-thermal";
>>>> + reg = <0 0x1100b000 0 0x1000>;
>>>> + interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>;
>>>
>>> What is this interrupt for?
>>
>> The interrupts pin is designed in our SoC. But it is not used in our
>> upstream thermal code now. There is also add the settings but not use
>> for mt8173.dtsi. To align the thermal dtsi format, I follow the past
>> experience to add the interrupt settings of this project first.
>
> Assuming the interrupt can be set by the driver to fire when a specified
> temperature is set, I suggest to change your driver to handle it so you
> can get rid of the polling waking up the SoC every second.
>
For the record the interrupt is a required property by the binding description.
Regards,
Matthias
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-20 20:58 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 6:43 [PATCH v3,0/8] Add Mediatek thermal dirver and dtsi Michael Kao
2020-01-03 6:43 ` Michael Kao
2020-01-03 6:43 ` Michael Kao
2020-01-03 6:44 ` [PATCH v3,1/8] arm64: dts: mt8183: add thermal zone node Michael Kao
2020-01-03 6:44 ` Michael Kao
2020-01-09 11:31 ` Daniel Lezcano
2020-01-09 11:31 ` Daniel Lezcano
2020-01-09 11:31 ` Daniel Lezcano
2020-02-11 3:17 ` Michael Kao
2020-02-11 3:17 ` Michael Kao
2020-02-20 11:52 ` Daniel Lezcano
2020-02-20 11:52 ` Daniel Lezcano
2020-02-20 11:52 ` Daniel Lezcano
2020-02-20 20:57 ` Matthias Brugger [this message]
2020-02-20 20:57 ` Matthias Brugger
2020-02-20 20:57 ` Matthias Brugger
2020-02-26 1:58 ` Michael Kao
2020-02-26 1:58 ` Michael Kao
2020-02-26 1:58 ` Michael Kao
2020-02-20 20:56 ` Matthias Brugger
2020-02-20 20:56 ` Matthias Brugger
2020-02-20 20:56 ` Matthias Brugger
2020-01-03 6:44 ` [PATCH v3, 2/8] arm64: dts: mt8183: add/update dynamic power coefficients Michael Kao
2020-01-03 6:44 ` Michael Kao
2020-01-10 14:40 ` [PATCH v3,2/8] " Matthias Brugger
2020-01-10 14:40 ` Matthias Brugger
2020-01-10 14:40 ` Matthias Brugger
2020-02-11 2:05 ` Michael Kao
2020-02-11 2:05 ` Michael Kao
2020-02-20 21:06 ` Matthias Brugger
2020-02-20 21:06 ` Matthias Brugger
2020-02-20 21:06 ` Matthias Brugger
2020-01-03 6:44 ` [PATCH v3,3/8] arm64: dts: mt8183: Add #cooling-cells to CPU nodes Michael Kao
2020-01-03 6:44 ` Michael Kao
2020-02-20 21:59 ` Matthias Brugger
2020-02-20 21:59 ` Matthias Brugger
2020-02-20 21:59 ` Matthias Brugger
2020-01-03 6:44 ` [PATCH v3,4/8] arm64: dts: mt8183: Configure CPU cooling Michael Kao
2020-01-03 6:44 ` Michael Kao
2020-02-25 9:34 ` Michael Kao
2020-02-25 9:34 ` Michael Kao
2020-01-03 6:44 ` [PATCH v3, 5/8] arm64: dts: mt8183: Increase polling frequency for CPU thermal zone Michael Kao
2020-01-03 6:44 ` Michael Kao
2020-01-03 6:44 ` [PATCH v3,5/8] " Michael Kao
2020-01-03 6:44 ` [PATCH v3,6/8] thermal: mediatek: mt8183: fix bank number settings Michael Kao
2020-01-03 6:44 ` Michael Kao
2020-01-08 9:58 ` [PATCH v3, 6/8] " Hsin-Yi Wang
2020-01-08 9:58 ` Hsin-Yi Wang
2020-01-08 9:58 ` [PATCH v3,6/8] " Hsin-Yi Wang
2020-01-03 6:44 ` [PATCH v3, 7/8] thermal: mediatek: add another get_temp ops for thermal sensors Michael Kao
2020-01-03 6:44 ` Michael Kao
2020-01-03 6:44 ` [PATCH v3,7/8] " Michael Kao
2020-01-03 6:44 ` [PATCH v3,8/8] thermal: mediatek: use spinlock to protect PTPCORESEL Michael Kao
2020-01-03 6:44 ` Michael Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fab7d40-d7d9-883e-1c50-0507ee1dd750@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.kao@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.