Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

[Stefan Weil <sw@weilnetz.de>]

Am 15.07.2012 22:26, schrieb Mike Frysinger:
> We should not quote the PKG_CONFIG setting as this deviates from the
> canonical upstream behavior that gets integrated with all other build
> systems, and deviates from how we treat all other toolchain variables
> that we get from the environment.
>
> Ultimately, the point is that it breaks passing custom flags directly
> to pkg-config via the env var where this normally works elsewhere,
> and it used to work in the past.


What about passing custom flags with QEMU_PKG_CONFIG_FLAGS?

Removing the quotes will not allow paths containing spaces,
so that's not a good idea.

Regards,

Stefan Weil



>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>   configure |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 83fa1ca..bd12ed3 100755
> --- a/configure
> +++ b/configure
> @@ -245,7 +245,7 @@ strip="${STRIP-${cross_prefix}strip}"
>   windres="${WINDRES-${cross_prefix}windres}"
>   pkg_config_exe="${PKG_CONFIG-${cross_prefix}pkg-config}"
>   query_pkg_config() {
> -    "${pkg_config_exe}" ${QEMU_PKG_CONFIG_FLAGS} "$@"
> +    ${pkg_config_exe} ${QEMU_PKG_CONFIG_FLAGS} "$@"
>   }
>   pkg_config=query_pkg_config
>   sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
> @@ -1511,7 +1511,7 @@ fi
>   ##########################################
>   # pkg-config probe
>   
> -if ! has "$pkg_config_exe"; then
> +if ! has $pkg_config_exe; then
>     echo "Error: pkg-config binary '$pkg_config_exe' not found"
>     exit 1
>   fi