Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]

On 09/17/2012 01:38 PM, Anthony Liguori wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
> 
>> We should not quote the PKG_CONFIG setting as this deviates from the
>> canonical upstream behavior that gets integrated with all other build
>> systems, and deviates from how we treat all other toolchain variables
>> that we get from the environment.
>>
>> Ultimately, the point is that it breaks passing custom flags directly
>> to pkg-config via the env var where this normally works elsewhere,
>> and it used to work in the past.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> 
> This doesn't make any sense to me.   What is the command line that
> you're trying to execute?
> 
> This obviously would introduce a bug if there was a space in the
> filename of the pkg-config binary.

Except that the de facto standard is that the pkg-config binary already
is prohibited from having a space in the filename.

https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02015.html

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]