From: Stefan Weil <sw@weilnetz.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Sergei Trofimovich <slyfox@gentoo.org>
Subject: Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG
Date: Sun, 16 Sep 2012 22:21:31 +0200 [thread overview]
Message-ID: <505634CB.9050000@weilnetz.de> (raw)
In-Reply-To: <201209161552.08483.vapier@gentoo.org>
Am 16.09.2012 21:52, schrieb Mike Frysinger:
> On Sunday 15 July 2012 15:54:51 Stefan Weil wrote:
>> Am 15.07.2012 22:26, schrieb Mike Frysinger:
>>> We should not quote the PKG_CONFIG setting as this deviates from the
>>> canonical upstream behavior that gets integrated with all other build
>>> systems, and deviates from how we treat all other toolchain variables
>>> that we get from the environment.
>>>
>>> Ultimately, the point is that it breaks passing custom flags directly
>>> to pkg-config via the env var where this normally works elsewhere,
>>> and it used to work in the past.
> ping ...
> -mike
The complete discussion is here: http://patchwork.ozlabs.org/patch/171087/.
I suggested using Mike's patch and removing commit
17884d7b6462b0fe497f08fec6091ffbe04caa8d.
(./configure: request pkg-config to provide private
libs when static linking).
Anthony, Sergei, any comments?
Regards
Stefan
next prev parent reply other threads:[~2012-09-16 20:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 20:26 [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG Mike Frysinger
2012-07-15 19:54 ` Stefan Weil
2012-07-15 21:53 ` Mike Frysinger
2012-07-16 15:39 ` Eric Blake
2012-07-16 15:58 ` Stefan Weil
2012-07-18 12:13 ` Mike Frysinger
2012-09-16 19:52 ` Mike Frysinger
2012-09-16 20:21 ` Stefan Weil [this message]
2012-09-17 5:24 ` Sergei Trofimovich
2012-09-17 19:38 ` Anthony Liguori
2012-09-17 19:51 ` Eric Blake
2013-06-17 6:20 ` [Qemu-devel] [PATCH v2] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505634CB.9050000@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=slyfox@gentoo.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.