All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-trivial <qemu-trivial@nongnu.org>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-trivial] [PATCH] Stop saving/restoring cpu_single_env
Date: Tue, 17 Jul 2012 17:23:33 +0200	[thread overview]
Message-ID: <50058375.5080009@siemens.com> (raw)

This variable is now thread-local, so cannot change anymore while
dropping the global mutex.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 cpus.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/cpus.c b/cpus.c
index b182b3d..733568d 100644
--- a/cpus.c
+++ b/cpus.c
@@ -660,10 +660,7 @@ void run_on_cpu(CPUArchState *env, void (*func)(void *data), void *data)
 
     qemu_cpu_kick(env);
     while (!wi.done) {
-        CPUArchState *self_env = cpu_single_env;
-
         qemu_cond_wait(&qemu_work_cond, &qemu_global_mutex);
-        cpu_single_env = self_env;
     }
 }
 
-- 
1.7.3.4


WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-trivial <qemu-trivial@nongnu.org>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] Stop saving/restoring cpu_single_env
Date: Tue, 17 Jul 2012 17:23:33 +0200	[thread overview]
Message-ID: <50058375.5080009@siemens.com> (raw)

This variable is now thread-local, so cannot change anymore while
dropping the global mutex.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 cpus.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/cpus.c b/cpus.c
index b182b3d..733568d 100644
--- a/cpus.c
+++ b/cpus.c
@@ -660,10 +660,7 @@ void run_on_cpu(CPUArchState *env, void (*func)(void *data), void *data)
 
     qemu_cpu_kick(env);
     while (!wi.done) {
-        CPUArchState *self_env = cpu_single_env;
-
         qemu_cond_wait(&qemu_work_cond, &qemu_global_mutex);
-        cpu_single_env = self_env;
     }
 }
 
-- 
1.7.3.4

             reply	other threads:[~2012-07-17 15:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 15:23 Jan Kiszka [this message]
2012-07-17 15:23 ` [Qemu-devel] [PATCH] Stop saving/restoring cpu_single_env Jan Kiszka
2012-07-17 15:27 ` [Qemu-trivial] " Peter Maydell
2012-07-17 15:27   ` Peter Maydell
2012-07-17 15:31   ` [Qemu-trivial] " Jan Kiszka
2012-07-17 15:31     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50058375.5080009@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.