From: Jan Kiszka <jan.kiszka@siemens.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Stop saving/restoring cpu_single_env
Date: Tue, 17 Jul 2012 17:31:15 +0200 [thread overview]
Message-ID: <50058543.7090305@siemens.com> (raw)
In-Reply-To: <CAFEAcA_j=4N5M5uH5-+KamBb-7pf5Qzk_m_C+NqeTn1303TTmA@mail.gmail.com>
On 2012-07-17 17:27, Peter Maydell wrote:
> On 17 July 2012 16:23, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> This variable is now thread-local, so cannot change anymore while
>> dropping the global mutex.
>
> This isn't true on any host except Linux, and run_on_cpu() isn't
> inside a !_WIN32 ifdef as far as I can tell.
Err, yes, forgot that minor detail. It would also break on non-Linux Unixes.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Stop saving/restoring cpu_single_env
Date: Tue, 17 Jul 2012 17:31:15 +0200 [thread overview]
Message-ID: <50058543.7090305@siemens.com> (raw)
In-Reply-To: <CAFEAcA_j=4N5M5uH5-+KamBb-7pf5Qzk_m_C+NqeTn1303TTmA@mail.gmail.com>
On 2012-07-17 17:27, Peter Maydell wrote:
> On 17 July 2012 16:23, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> This variable is now thread-local, so cannot change anymore while
>> dropping the global mutex.
>
> This isn't true on any host except Linux, and run_on_cpu() isn't
> inside a !_WIN32 ifdef as far as I can tell.
Err, yes, forgot that minor detail. It would also break on non-Linux Unixes.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-07-17 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 15:23 [Qemu-trivial] [PATCH] Stop saving/restoring cpu_single_env Jan Kiszka
2012-07-17 15:23 ` [Qemu-devel] " Jan Kiszka
2012-07-17 15:27 ` [Qemu-trivial] " Peter Maydell
2012-07-17 15:27 ` Peter Maydell
2012-07-17 15:31 ` Jan Kiszka [this message]
2012-07-17 15:31 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50058543.7090305@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.