From: Stefan Weil <sw@weilnetz.de>
To: Anthony Liguori <anthony@codemonkey.ws>,
Blue Swirl <blauwirbel@gmail.com>,
qemu-trivial <qemu-trivial@nongnu.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: fix ALSA configure test
Date: Tue, 17 Jul 2012 20:32:05 +0200 [thread overview]
Message-ID: <5005AFA5.6080101@weilnetz.de> (raw)
In-Reply-To: <5005A904.5000006@samsung.com>
Am 17.07.2012 20:03, schrieb Igor Mitsyanko:
> I see now that this bug was already noticed, please ignore this mail
>
> On 07/17/2012 09:34 PM, Igor Mitsyanko wrote:
>> After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure
>> tests are
>> executed with -Werror flag. Current ALSA configure test program
>> invokes a warning:
>>
>> warning: ‘handle’ is used uninitialized in this function
>> [-Wuninitialized]
>>
>> which results in error with -Werror flag and, consequently, in alsa
>> test failing.
>> This means that QEMU won't configure with "--audio-drv-list=alsa".
>>
>> Initialize "handle" variable to fix compilation warning.
>>
>> Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
>> ---
>> configure | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
Hello Anthony, hello Blue,
these patches fix broken builds, therefore I expected that they
would be applied fast:
http://patchwork.ozlabs.org/patch/171066/
http://patchwork.ozlabs.org/patch/171067/
http://patchwork.ozlabs.org/patch/171081/
http://patchwork.ozlabs.org/patch/171082/
The first of them fixes the ALSA problem.
I think that all 4 patches are trivial, so maybe they could
also be committed via qemu-trivial if the next pull request
comes before they were applied to git master.
Regards,
Stefan W.
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Anthony Liguori <anthony@codemonkey.ws>,
Blue Swirl <blauwirbel@gmail.com>,
qemu-trivial <qemu-trivial@nongnu.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test
Date: Tue, 17 Jul 2012 20:32:05 +0200 [thread overview]
Message-ID: <5005AFA5.6080101@weilnetz.de> (raw)
In-Reply-To: <5005A904.5000006@samsung.com>
Am 17.07.2012 20:03, schrieb Igor Mitsyanko:
> I see now that this bug was already noticed, please ignore this mail
>
> On 07/17/2012 09:34 PM, Igor Mitsyanko wrote:
>> After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure
>> tests are
>> executed with -Werror flag. Current ALSA configure test program
>> invokes a warning:
>>
>> warning: ‘handle’ is used uninitialized in this function
>> [-Wuninitialized]
>>
>> which results in error with -Werror flag and, consequently, in alsa
>> test failing.
>> This means that QEMU won't configure with "--audio-drv-list=alsa".
>>
>> Initialize "handle" variable to fix compilation warning.
>>
>> Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
>> ---
>> configure | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
Hello Anthony, hello Blue,
these patches fix broken builds, therefore I expected that they
would be applied fast:
http://patchwork.ozlabs.org/patch/171066/
http://patchwork.ozlabs.org/patch/171067/
http://patchwork.ozlabs.org/patch/171081/
http://patchwork.ozlabs.org/patch/171082/
The first of them fixes the ALSA problem.
I think that all 4 patches are trivial, so maybe they could
also be committed via qemu-trivial if the next pull request
comes before they were applied to git master.
Regards,
Stefan W.
next prev parent reply other threads:[~2012-07-17 18:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 17:34 [Qemu-devel] [PATCH] configure: fix ALSA configure test Igor Mitsyanko
2012-07-17 18:03 ` Igor Mitsyanko
2012-07-17 18:32 ` Stefan Weil [this message]
2012-07-17 18:32 ` Stefan Weil
2012-07-17 18:46 ` [Qemu-trivial] " Peter Maydell
2012-07-17 18:46 ` Peter Maydell
2012-07-17 19:24 ` [Qemu-trivial] " Stefan Weil
2012-07-17 19:24 ` Stefan Weil
2012-07-17 19:28 ` [Qemu-trivial] " Peter Maydell
2012-07-17 19:28 ` Peter Maydell
2012-07-17 19:42 ` [Qemu-trivial] " Stefan Weil
2012-07-17 19:42 ` Stefan Weil
2012-07-21 9:37 ` [Qemu-trivial] " Stefan Hajnoczi
2012-07-21 9:37 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-07-23 17:40 ` [Qemu-trivial] [Qemu-devel] " Blue Swirl
2012-07-23 17:40 ` Blue Swirl
2012-07-23 17:45 ` [Qemu-trivial] " Peter Maydell
2012-07-23 17:45 ` Peter Maydell
2012-07-23 19:32 ` [Qemu-trivial] " Peter Maydell
2012-07-23 19:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5005AFA5.6080101@weilnetz.de \
--to=sw@weilnetz.de \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=i.mitsyanko@samsung.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.