From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: fix ALSA configure test
Date: Tue, 17 Jul 2012 21:42:19 +0200 [thread overview]
Message-ID: <5005C01B.2010803@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA9n7+UVp9W20x8zs71cPxZWBu8o1FQxVSwq8o6TdGZ0BQ@mail.gmail.com>
Am 17.07.2012 21:28, schrieb Peter Maydell:
> On 17 July 2012 20:24, Stefan Weil <sw@weilnetz.de> wrote:
>> The arguments why -Werror is a bad idea for some configure tests
>> are reasonable.
>>
>> Nevertheless the QEMU community was able to produce thousands of
>> lines of code which compile without a warning, so we should be able
>> to create warning and error free code for a handful of configure
>> tests.
> The trouble is that the warnings and errors here don't cause the
> build to fail noisily; that's a big distinction IMHO.
> I suppose we could make compile_prog do something like:
> * run the compile test
> * if it fails => test failure as now
> * if it succeeds (and we're doing a Werror build at all),
> rerun the same test with -Werror
> * if that fails, abort configure with an error message
> Then we would have the same "make the problem obvious" effect
> that plain -Werror provides for our main compilation.
Good idea. Of course it will increase the time needed for
running the default configure, but I think that's acceptable
if we don't use it for the tests of the compiler warning options.
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test
Date: Tue, 17 Jul 2012 21:42:19 +0200 [thread overview]
Message-ID: <5005C01B.2010803@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA9n7+UVp9W20x8zs71cPxZWBu8o1FQxVSwq8o6TdGZ0BQ@mail.gmail.com>
Am 17.07.2012 21:28, schrieb Peter Maydell:
> On 17 July 2012 20:24, Stefan Weil <sw@weilnetz.de> wrote:
>> The arguments why -Werror is a bad idea for some configure tests
>> are reasonable.
>>
>> Nevertheless the QEMU community was able to produce thousands of
>> lines of code which compile without a warning, so we should be able
>> to create warning and error free code for a handful of configure
>> tests.
> The trouble is that the warnings and errors here don't cause the
> build to fail noisily; that's a big distinction IMHO.
> I suppose we could make compile_prog do something like:
> * run the compile test
> * if it fails => test failure as now
> * if it succeeds (and we're doing a Werror build at all),
> rerun the same test with -Werror
> * if that fails, abort configure with an error message
> Then we would have the same "make the problem obvious" effect
> that plain -Werror provides for our main compilation.
Good idea. Of course it will increase the time needed for
running the default configure, but I think that's acceptable
if we don't use it for the tests of the compiler warning options.
next prev parent reply other threads:[~2012-07-17 19:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 17:34 [Qemu-devel] [PATCH] configure: fix ALSA configure test Igor Mitsyanko
2012-07-17 18:03 ` Igor Mitsyanko
2012-07-17 18:32 ` [Qemu-trivial] " Stefan Weil
2012-07-17 18:32 ` Stefan Weil
2012-07-17 18:46 ` [Qemu-trivial] " Peter Maydell
2012-07-17 18:46 ` Peter Maydell
2012-07-17 19:24 ` [Qemu-trivial] " Stefan Weil
2012-07-17 19:24 ` Stefan Weil
2012-07-17 19:28 ` [Qemu-trivial] " Peter Maydell
2012-07-17 19:28 ` Peter Maydell
2012-07-17 19:42 ` Stefan Weil [this message]
2012-07-17 19:42 ` Stefan Weil
2012-07-21 9:37 ` [Qemu-trivial] " Stefan Hajnoczi
2012-07-21 9:37 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-07-23 17:40 ` [Qemu-trivial] [Qemu-devel] " Blue Swirl
2012-07-23 17:40 ` Blue Swirl
2012-07-23 17:45 ` [Qemu-trivial] " Peter Maydell
2012-07-23 17:45 ` Peter Maydell
2012-07-23 19:32 ` [Qemu-trivial] " Peter Maydell
2012-07-23 19:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5005C01B.2010803@weilnetz.de \
--to=sw@weilnetz.de \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.