All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] audio: Make PC speaker audio card available by default
Date: Thu, 19 Jul 2012 18:28:12 -0500	[thread overview]
Message-ID: <5008980C.60809@codemonkey.ws> (raw)
In-Reply-To: <50082E7F.7030800@siemens.com>

On 07/19/2012 10:57 AM, Jan Kiszka wrote:
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>

Broke the build.  I'm also confused about why this is necessary.

You can just set CONFIG_PCSPK=y in default-configs/${ARCH}.mak to enable it and 
indeed, it's enabled by default for a bunch of targets including x86_64.

So... I'm confused what this is fixing.  Since I suspect malc and Jan are 
asleep, I'm going to revert for now to fix the build.

I'll happily help fix whatever Jan was trying to fix tomorrow.

Regards,

Anthony Liguori

> ---
>   configure |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 106209a..42adc8d 100755
> --- a/configure
> +++ b/configure
> @@ -90,8 +90,8 @@ static="no"
>   sparc_cpu=""
>   cross_prefix=""
>   audio_drv_list=""
> -audio_card_list="ac97 es1370 sb16 hda"
> -audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus hda"
> +audio_card_list="ac97 es1370 sb16 hda pcspk"
> +audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus hda pcspk"
>   block_drv_whitelist=""
>   host_cc="gcc"
>   helper_cflags=""

  parent reply	other threads:[~2012-07-19 23:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 15:57 [Qemu-trivial] [PATCH] audio: Make PC speaker audio card available by default Jan Kiszka
2012-07-19 15:57 ` [Qemu-devel] " Jan Kiszka
2012-07-19 16:18 ` [Qemu-trivial] " malc
2012-07-19 16:18   ` [Qemu-devel] " malc
2012-07-19 23:28 ` Anthony Liguori [this message]
2012-07-20  0:01   ` malc
2012-07-20  7:02     ` Jan Kiszka
2012-07-20  7:17       ` [Qemu-devel] [PATCH] audio: Make pcspk card selectable again Jan Kiszka
2012-08-14 11:30         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5008980C.60809@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.