From: Jan Kiszka <jan.kiszka@web.de>
To: malc <av1474@comtv.ru>, Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] audio: Make PC speaker audio card available by default
Date: Fri, 20 Jul 2012 09:02:01 +0200 [thread overview]
Message-ID: <50090269.7090604@web.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1207200359280.6944@linmac>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On 2012-07-20 02:01, malc wrote:
> On Thu, 19 Jul 2012, Anthony Liguori wrote:
>
>> On 07/19/2012 10:57 AM, Jan Kiszka wrote:
>>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>>
>> Broke the build. I'm also confused about why this is necessary.
>
> It built fine here[1]. So was i, but...
Yeah, sorry, was to quick to send a premature workaround instead of
trying to understand what actually broke here.
What happened is that pcspk is no longer selectable via -soundhw. And
that is because CONFIG_PCSPK, used by arch_init.c to build the static
soundhw arraw, is no longer selected at target built time. It became a
host level define when we moved the speaker into hwlib. I will try to
find some workaround at configure level.
I guess, on the long run, we will have to refactor the audio backend to
allow for runtime registration of drivers.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-07-20 7:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 15:57 [Qemu-trivial] [PATCH] audio: Make PC speaker audio card available by default Jan Kiszka
2012-07-19 15:57 ` [Qemu-devel] " Jan Kiszka
2012-07-19 16:18 ` [Qemu-trivial] " malc
2012-07-19 16:18 ` [Qemu-devel] " malc
2012-07-19 23:28 ` Anthony Liguori
2012-07-20 0:01 ` malc
2012-07-20 7:02 ` Jan Kiszka [this message]
2012-07-20 7:17 ` [Qemu-devel] [PATCH] audio: Make pcspk card selectable again Jan Kiszka
2012-08-14 11:30 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50090269.7090604@web.de \
--to=jan.kiszka@web.de \
--cc=anthony@codemonkey.ws \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.