From: Jan Kiszka <jan.kiszka@web.de>
To: malc <av1474@comtv.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: [Qemu-devel] [PATCH] audio: Make pcspk card selectable again
Date: Fri, 20 Jul 2012 09:17:21 +0200 [thread overview]
Message-ID: <50090601.40800@web.de> (raw)
In-Reply-To: <50090269.7090604@web.de>
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
From: Jan Kiszka <jan.kiszka@siemens.com>
Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per
target. Therefore, statically built soundhw array in arch_init.c stopped
including this card.
Work around this by re-adding this define to config-target.mak.
Long-term, a dynamic creation of this soundhw list will be necessary.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
configure | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 106209a..77b5096 100755
--- a/configure
+++ b/configure
@@ -3818,6 +3818,11 @@ if test "$target_bsd_user" = "yes" ; then
echo "CONFIG_BSD_USER=y" >> $config_target_mak
fi
+# the static way of configuring available audio cards requires this workaround
+if test "$target_user_only" != "yes" && grep -q CONFIG_PCSPK $source_path/default-configs/$target.mak; then
+ echo "CONFIG_PCSPK=y" >> $config_target_mak
+fi
+
# generate QEMU_CFLAGS/LDFLAGS for targets
cflags=""
--
1.7.3.4
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-07-20 7:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 15:57 [Qemu-trivial] [PATCH] audio: Make PC speaker audio card available by default Jan Kiszka
2012-07-19 15:57 ` [Qemu-devel] " Jan Kiszka
2012-07-19 16:18 ` [Qemu-trivial] " malc
2012-07-19 16:18 ` [Qemu-devel] " malc
2012-07-19 23:28 ` Anthony Liguori
2012-07-20 0:01 ` malc
2012-07-20 7:02 ` Jan Kiszka
2012-07-20 7:17 ` Jan Kiszka [this message]
2012-08-14 11:30 ` [Qemu-devel] [PATCH] audio: Make pcspk card selectable again Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50090601.40800@web.de \
--to=jan.kiszka@web.de \
--cc=anthony@codemonkey.ws \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.