* flush cache according to 'preferred life time'
@ 2012-07-23 7:36 BALAKUMARAN KANNAN
2012-07-23 8:05 ` Gao feng
0 siblings, 1 reply; 6+ messages in thread
From: BALAKUMARAN KANNAN @ 2012-07-23 7:36 UTC (permalink / raw)
To: netdev@vger.kernel.org
Hello all,
I am running test casees for IPv6 conformation on linux-3.0.26 kernel. Here I am facing a problem in routing advertisement. Once test case sets the 'preferred life time' to 20 seconds for a particular destination. And continuously sending ICMP REQUEST. It is expected that the ICMP_REPLY should stop in 20 seconds. But as because the default gc_interval is 30seconds, even after the timer expiry of the route, it is staying in the router cache. So even after 20 seconds, the nut(node under test) sends ICMP_REPLY. So if I changes gc_interval to 1, the test is getting passed.
But if I changes gc_interval to 1 seconds another test case in pmtu section fails. It expects that the nut should hold pmtu(path mtu) information for different value. So if I flushes the cache, the pmtu value is turning back to default.
So I made the kernel to alter its gc_interval value according to the 'preferred life time' of the path. Here is my path. Kindly tell me whether my idea is correct. Am I missing something?
--------------------------------------------------------------------------------------
--- ../linux-3.0.y-BRANCH_SS-RT.git.fresh/net/ipv6/ndisc.c.bak 2012-07-23 12:50:46.000000000 +0530
+++ ../linux-3.0.y-BRANCH_SS-RT.git.fresh/net/ipv6/ndisc.c 2012-07-23 12:54:17.000000000 +0530
@@ -1160,6 +1160,9 @@
__u8 * opt = (__u8 *)(ra_msg + 1);
+ struct net *net = dev_net(skb->dev);
+ fib6_run_gc(1, net);
+
optlen = (skb->tail - skb->transport_header) - sizeof(struct ra_msg);
if (!(ipv6_addr_type(&ipv6_hdr(skb)->saddr) & IPV6_ADDR_LINKLOCAL)) {
@@ -1200,6 +1203,22 @@
return;
}
+ if (*opt == 3) {
+ printk("<8> IN OPT 3\n");
+ struct net *net = dev_net(skb->dev);
+ fib6_run_gc(1, net);
+ int pref_life_time = ntohl(*((int *) (((char *) (opt)) + 8)));
+ if ((pref_life_time != 0) && (pref_life_time < 50)) {
+ printk("<8> gc_interval CHANGED\n");
+ //init_net.ipv6.sysctl.flush_delay = 1;
+ init_net.ipv6.sysctl.ip6_rt_gc_interval = 1 * HZ;
+ }
+ else {
+ init_net.ipv6.sysctl.ip6_rt_gc_interval = 30 * HZ;
+ }
+
+ }
+
if (!accept_ra(in6_dev))
goto skip_linkparms;
--------------------------------------------------------------------------------------
Note: This is not well structured. I just created it for temparory solution. Just clarify me whether this idea is right.
And Please let me know why pmtu value is not stored in routing table but only in cache.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: flush cache according to 'preferred life time'
2012-07-23 7:36 flush cache according to 'preferred life time' BALAKUMARAN KANNAN
@ 2012-07-23 8:05 ` Gao feng
2012-07-23 8:12 ` BALAKUMARAN KANNAN
0 siblings, 1 reply; 6+ messages in thread
From: Gao feng @ 2012-07-23 8:05 UTC (permalink / raw)
To: BALAKUMARAN KANNAN; +Cc: netdev@vger.kernel.org
于 2012年07月23日 15:36, BALAKUMARAN KANNAN 写道:
> Hello all,
> I am running test casees for IPv6 conformation on linux-3.0.26 kernel. Here I am facing a problem in routing advertisement. Once test case sets the 'preferred life time' to 20 seconds for a particular destination. And continuously sending ICMP REQUEST. It is expected that the ICMP_REPLY should stop in 20 seconds. But as because the default gc_interval is 30seconds, even after the timer expiry of the route, it is staying in the router cache. So even after 20 seconds, the nut(node under test) sends ICMP_REPLY. So if I changes gc_interval to 1, the test is getting passed.
>
> But if I changes gc_interval to 1 seconds another test case in pmtu section fails. It expects that the nut should hold pmtu(path mtu) information for different value. So if I flushes the cache, the pmtu value is turning back to default.
>
> So I made the kernel to alter its gc_interval value according to the 'preferred life time' of the path. Here is my path. Kindly tell me whether my idea is correct. Am I missing something?
>
Is this commit 1716a96101c49186bb0b8491922fd3e69030235f what you need?
> --------------------------------------------------------------------------------------
> --- ../linux-3.0.y-BRANCH_SS-RT.git.fresh/net/ipv6/ndisc.c.bak 2012-07-23 12:50:46.000000000 +0530
> +++ ../linux-3.0.y-BRANCH_SS-RT.git.fresh/net/ipv6/ndisc.c 2012-07-23 12:54:17.000000000 +0530
> @@ -1160,6 +1160,9 @@
>
> __u8 * opt = (__u8 *)(ra_msg + 1);
>
> + struct net *net = dev_net(skb->dev);
> + fib6_run_gc(1, net);
> +
> optlen = (skb->tail - skb->transport_header) - sizeof(struct ra_msg);
>
> if (!(ipv6_addr_type(&ipv6_hdr(skb)->saddr) & IPV6_ADDR_LINKLOCAL)) {
> @@ -1200,6 +1203,22 @@
> return;
> }
>
> + if (*opt == 3) {
> + printk("<8> IN OPT 3\n");
> + struct net *net = dev_net(skb->dev);
> + fib6_run_gc(1, net);
> + int pref_life_time = ntohl(*((int *) (((char *) (opt)) + 8)));
> + if ((pref_life_time != 0) && (pref_life_time < 50)) {
> + printk("<8> gc_interval CHANGED\n");
> + //init_net.ipv6.sysctl.flush_delay = 1;
> + init_net.ipv6.sysctl.ip6_rt_gc_interval = 1 * HZ;
> + }
> + else {
> + init_net.ipv6.sysctl.ip6_rt_gc_interval = 30 * HZ;
> + }
> +
> + }
> +
> if (!accept_ra(in6_dev))
> goto skip_linkparms;
> --------------------------------------------------------------------------------------
>
> Note: This is not well structured. I just created it for temparory solution. Just clarify me whether this idea is right.
>
> And Please let me know why pmtu value is not stored in routing table but only in cache.
I think the pmtu should be belong to destination.the different destinations may have
different pmtu,even they use same route entry.
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: flush cache according to 'preferred life time'
2012-07-23 8:05 ` Gao feng
@ 2012-07-23 8:12 ` BALAKUMARAN KANNAN
2012-07-23 8:24 ` Gao feng
0 siblings, 1 reply; 6+ messages in thread
From: BALAKUMARAN KANNAN @ 2012-07-23 8:12 UTC (permalink / raw)
To: Gao feng; +Cc: netdev@vger.kernel.org
________________________________________
From: netdev-owner@vger.kernel.org [netdev-owner@vger.kernel.org] on behalf of Gao feng [gaofeng@cn.fujitsu.com]
Sent: Monday, July 23, 2012 1:35 PM
To: BALAKUMARAN KANNAN
Cc: netdev@vger.kernel.org
Subject: Re: flush cache according to 'preferred life time'
于 2012年07月23日 15:36, BALAKUMARAN KANNAN 写道:
> Hello all,
> I am running test casees for IPv6 conformation on linux-3.0.26 kernel. Here I am facing a problem in routing advertisement. Once test case sets the 'preferred life time' to 20 seconds for a particular destination. And continuously sending ICMP REQUEST. It is expected that the ICMP_REPLY should stop in 20 seconds. But as because the default gc_interval is 30seconds, even after the timer expiry of the route, it is staying in the router cache. So even after 20 seconds, the nut(node under test) sends ICMP_REPLY. So if I changes gc_interval to 1, the test is getting passed.
>
> But if I changes gc_interval to 1 seconds another test case in pmtu section fails. It expects that the nut should hold pmtu(path mtu) information for different value. So if I flushes the cache, the pmtu value is turning back to default.
>
> So I made the kernel to alter its gc_interval value according to the 'preferred life time' of the path. Here is my path. Kindly tell me whether my idea is correct. Am I missing something?
>
Is this commit 1716a96101c49186bb0b8491922fd3e69030235f what you need?
> --------------------------------------------------------------------------------------
> --- ../linux-3.0.y-BRANCH_SS-RT.git.fresh/net/ipv6/ndisc.c.bak 2012-07-23 12:50:46.000000000 +0530
> +++ ../linux-3.0.y-BRANCH_SS-RT.git.fresh/net/ipv6/ndisc.c 2012-07-23 12:54:17.000000000 +0530
> @@ -1160,6 +1160,9 @@
>
> __u8 * opt = (__u8 *)(ra_msg + 1);
>
> + struct net *net = dev_net(skb->dev);
> + fib6_run_gc(1, net);
> +
> optlen = (skb->tail - skb->transport_header) - sizeof(struct ra_msg);
>
> if (!(ipv6_addr_type(&ipv6_hdr(skb)->saddr) & IPV6_ADDR_LINKLOCAL)) {
> @@ -1200,6 +1203,22 @@
> return;
> }
>
> + if (*opt == 3) {
> + printk("<8> IN OPT 3\n");
> + struct net *net = dev_net(skb->dev);
> + fib6_run_gc(1, net);
> + int pref_life_time = ntohl(*((int *) (((char *) (opt)) + 8)));
> + if ((pref_life_time != 0) && (pref_life_time < 50)) {
> + printk("<8> gc_interval CHANGED\n");
> + //init_net.ipv6.sysctl.flush_delay = 1;
> + init_net.ipv6.sysctl.ip6_rt_gc_interval = 1 * HZ;
> + }
> + else {
> + init_net.ipv6.sysctl.ip6_rt_gc_interval = 30 * HZ;
> + }
> +
> + }
> +
> if (!accept_ra(in6_dev))
> goto skip_linkparms;
> --------------------------------------------------------------------------------------
>
> Note: This is not well structured. I just created it for temparory solution. Just clarify me whether this idea is right.
>
> And Please let me know why pmtu value is not stored in routing table but only in cache.
I think the pmtu should be belong to destination.the different destinations may have
different pmtu,even they use same route entry.
So what you are comming to say, there will not be any entry in routing table for each destination but only in routing cache. So the pmtu value is updated in the cache not in the routing table. thank you. Also I have one more doubt. Is there a way to delete an entry (particular entry) from cache once the corresponding entry in the routing table is expired. As in my case, the routing table entry is expired in 20 seconds. but the cache entry is available till next cache flush. But I want to delete the entry from cache once the entry in routing table is expired. I believe you understand.
Thank you Geo feng-san for Interest.
--Regards,
K.Balakumaran
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: flush cache according to 'preferred life time'
2012-07-23 8:12 ` BALAKUMARAN KANNAN
@ 2012-07-23 8:24 ` Gao feng
2012-07-23 8:36 ` BALAKUMARAN KANNAN
0 siblings, 1 reply; 6+ messages in thread
From: Gao feng @ 2012-07-23 8:24 UTC (permalink / raw)
To: BALAKUMARAN KANNAN; +Cc: netdev@vger.kernel.org
于 2012年07月23日 16:12, BALAKUMARAN KANNAN 写道:
>
> ________________________________________
> From: netdev-owner@vger.kernel.org [netdev-owner@vger.kernel.org] on behalf of Gao feng [gaofeng@cn.fujitsu.com]
> Sent: Monday, July 23, 2012 1:35 PM
> To: BALAKUMARAN KANNAN
> Cc: netdev@vger.kernel.org
> Subject: Re: flush cache according to 'preferred life time'
>
> 于 2012年07月23日 15:36, BALAKUMARAN KANNAN 写道:
>> Hello all,
>> I am running test casees for IPv6 conformation on linux-3.0.26 kernel. Here I am facing a problem in routing advertisement. Once test case sets the 'preferred life time' to 20 seconds for a particular destination. And continuously sending ICMP REQUEST. It is expected that the ICMP_REPLY should stop in 20 seconds. But as because the default gc_interval is 30seconds, even after the timer expiry of the route, it is staying in the router cache. So even after 20 seconds, the nut(node under test) sends ICMP_REPLY. So if I changes gc_interval to 1, the test is getting passed.
>>
>> But if I changes gc_interval to 1 seconds another test case in pmtu section fails. It expects that the nut should hold pmtu(path mtu) information for different value. So if I flushes the cache, the pmtu value is turning back to default.
>>
>> So I made the kernel to alter its gc_interval value according to the 'preferred life time' of the path. Here is my path. Kindly tell me whether my idea is correct. Am I missing something?
>>
>
> Is this commit 1716a96101c49186bb0b8491922fd3e69030235f what you need?
>
>> --------------------------------------------------------------------------------------
>> --- ../linux-3.0.y-BRANCH_SS-RT.git.fresh/net/ipv6/ndisc.c.bak 2012-07-23 12:50:46.000000000 +0530
>> +++ ../linux-3.0.y-BRANCH_SS-RT.git.fresh/net/ipv6/ndisc.c 2012-07-23 12:54:17.000000000 +0530
>> @@ -1160,6 +1160,9 @@
>>
>> __u8 * opt = (__u8 *)(ra_msg + 1);
>>
>> + struct net *net = dev_net(skb->dev);
>> + fib6_run_gc(1, net);
>> +
>> optlen = (skb->tail - skb->transport_header) - sizeof(struct ra_msg);
>>
>> if (!(ipv6_addr_type(&ipv6_hdr(skb)->saddr) & IPV6_ADDR_LINKLOCAL)) {
>> @@ -1200,6 +1203,22 @@
>> return;
>> }
>>
>> + if (*opt == 3) {
>> + printk("<8> IN OPT 3\n");
>> + struct net *net = dev_net(skb->dev);
>> + fib6_run_gc(1, net);
>> + int pref_life_time = ntohl(*((int *) (((char *) (opt)) + 8)));
>> + if ((pref_life_time != 0) && (pref_life_time < 50)) {
>> + printk("<8> gc_interval CHANGED\n");
>> + //init_net.ipv6.sysctl.flush_delay = 1;
>> + init_net.ipv6.sysctl.ip6_rt_gc_interval = 1 * HZ;
>> + }
>> + else {
>> + init_net.ipv6.sysctl.ip6_rt_gc_interval = 30 * HZ;
>> + }
>> +
>> + }
>> +
>> if (!accept_ra(in6_dev))
>> goto skip_linkparms;
>> --------------------------------------------------------------------------------------
>>
>> Note: This is not well structured. I just created it for temparory solution. Just clarify me whether this idea is right.
>>
>> And Please let me know why pmtu value is not stored in routing table but only in cache.
>
> I think the pmtu should be belong to destination.the different destinations may have
> different pmtu,even they use same route entry.
>
> So what you are comming to say, there will not be any entry in routing table for each destination but only in routing cache. So the pmtu value is updated in the cache not in the routing table. thank you. Also I have one more doubt. Is there a way to delete an entry (particular entry) from cache once the corresponding entry in the routing table is expired. As in my case, the routing table entry is expired in 20 seconds. but the cache entry is available till next cache flush. But I want to delete the entry from cache once the entry in routing table is expired. I believe you understand.
>
Yes,I think so too.
> Thank you Geo feng-san for Interest.
I don't know if this commit is what you are finding.
1716a96101c49186bb0b8491922fd3e69030235f
You can test again with this commit.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: flush cache according to 'preferred life time'
2012-07-23 8:24 ` Gao feng
@ 2012-07-23 8:36 ` BALAKUMARAN KANNAN
2012-07-23 9:44 ` Gao feng
0 siblings, 1 reply; 6+ messages in thread
From: BALAKUMARAN KANNAN @ 2012-07-23 8:36 UTC (permalink / raw)
To: Gao feng; +Cc: netdev@vger.kernel.org
Than you Gao-san. Your patch is helpful. I will try that. Also I am facing another problem. Tahi test case section nd test case 145 is failing if gc_interval is 30. The test case is as follows
* The tester node (tn) sends RA with curhoplimit 64
* tn sends a ICMP_REQUEST and checks the ICMP_REPLY from nut is having hoplimit 64. (it is fine in my case)
* Then the tn sends a RA with curhoplimit 0. (It should be ignored)
* Then again tn sends ICMP_REQUEST and checks the ICMP_REPLY from nut whether the hoplimit remains 64 (but it changes to 255 if cache is present. But once I changed the gc_interval to 1, this testcase passes)
Can you please explain what is the reason.
Thank you
--Regards,
K.Balakumaran
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: flush cache according to 'preferred life time'
2012-07-23 8:36 ` BALAKUMARAN KANNAN
@ 2012-07-23 9:44 ` Gao feng
0 siblings, 0 replies; 6+ messages in thread
From: Gao feng @ 2012-07-23 9:44 UTC (permalink / raw)
To: BALAKUMARAN KANNAN; +Cc: netdev@vger.kernel.org
于 2012年07月23日 16:36, BALAKUMARAN KANNAN 写道:
> Than you Gao-san. Your patch is helpful. I will try that. Also I am facing another problem. Tahi test case section nd test case 145 is failing if gc_interval is 30. The test case is as follows
> * The tester node (tn) sends RA with curhoplimit 64
> * tn sends a ICMP_REQUEST and checks the ICMP_REPLY from nut is having hoplimit 64. (it is fine in my case)
> * Then the tn sends a RA with curhoplimit 0. (It should be ignored)
> * Then again tn sends ICMP_REQUEST and checks the ICMP_REPLY from nut whether the hoplimit remains 64 (but it changes to 255 if cache is present. But once I changed the gc_interval to 1, this testcase passes)
> Can you please explain what is the reason.
>
Hi
Can you test with the last kernel?
Maybe this bug has been fixed too.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-23 9:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-23 7:36 flush cache according to 'preferred life time' BALAKUMARAN KANNAN
2012-07-23 8:05 ` Gao feng
2012-07-23 8:12 ` BALAKUMARAN KANNAN
2012-07-23 8:24 ` Gao feng
2012-07-23 8:36 ` BALAKUMARAN KANNAN
2012-07-23 9:44 ` Gao feng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.