From: Stephen Warren <swarren@wwwdotorg.org>
To: Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/7] drivers/iommu/tegra-smmu.c: remove invalid reference to list iterator variable
Date: Mon, 23 Jul 2012 17:59:21 +0000 [thread overview]
Message-ID: <500D90F9.7030909@wwwdotorg.org> (raw)
In-Reply-To: <1341747464-1772-6-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
On 07/08/2012 05:37 AM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
Julia,
It looks like this patch hasn't seen any replies since you didn't CC the
maintainers of this code. I've CC'd them now.
> If list_for_each_entry, etc complete a traversal of the list, the iterator
> variable ends up pointing to an address at an offset from the list head,
> and not a meaningful structure. Thus this value should not be used after
> the end of the iterator. Replace c->dev by dev, which is the value that
> c->dev has been compared to.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/7] drivers/iommu/tegra-smmu.c: remove invalid reference to list iterator variable
Date: Mon, 23 Jul 2012 11:59:21 -0600 [thread overview]
Message-ID: <500D90F9.7030909@wwwdotorg.org> (raw)
In-Reply-To: <1341747464-1772-6-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
On 07/08/2012 05:37 AM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
Julia,
It looks like this patch hasn't seen any replies since you didn't CC the
maintainers of this code. I've CC'd them now.
> If list_for_each_entry, etc complete a traversal of the list, the iterator
> variable ends up pointing to an address at an offset from the list head,
> and not a meaningful structure. Thus this value should not be used after
> the end of the iterator. Replace c->dev by dev, which is the value that
> c->dev has been compared to.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
Acked-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Joerg Roedel <joerg.roedel@amd.com>,
Hiroshi Doyu <hdoyu@nvidia.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH 5/7] drivers/iommu/tegra-smmu.c: remove invalid reference to list iterator variable
Date: Mon, 23 Jul 2012 11:59:21 -0600 [thread overview]
Message-ID: <500D90F9.7030909@wwwdotorg.org> (raw)
In-Reply-To: <1341747464-1772-6-git-send-email-Julia.Lawall@lip6.fr>
On 07/08/2012 05:37 AM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
Julia,
It looks like this patch hasn't seen any replies since you didn't CC the
maintainers of this code. I've CC'd them now.
> If list_for_each_entry, etc complete a traversal of the list, the iterator
> variable ends up pointing to an address at an offset from the list head,
> and not a meaningful structure. Thus this value should not be used after
> the end of the iterator. Replace c->dev by dev, which is the value that
> c->dev has been compared to.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
next prev parent reply other threads:[~2012-07-23 17:59 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 11:37 [PATCH 0/7] remove invalid reference to list iterator variable Julia Lawall
2012-07-08 11:37 ` Julia Lawall
2012-07-08 11:37 ` [PATCH 1/7] drivers/isdn/mISDN/stack.c: " Julia Lawall
2012-07-08 11:37 ` Julia Lawall
2012-07-09 22:24 ` David Miller
2012-07-09 22:24 ` David Miller
2012-07-08 11:37 ` [PATCH 2/7] net/rxrpc/ar-peer.c: " Julia Lawall
2012-07-08 11:37 ` Julia Lawall
2012-07-09 22:24 ` David Miller
2012-07-09 22:24 ` David Miller
2012-07-08 11:37 ` [PATCH 3/7] mm/slub.c: " Julia Lawall
2012-07-08 11:37 ` Julia Lawall
2012-07-08 11:37 ` Julia Lawall
2012-07-09 9:04 ` Pekka Enberg
2012-07-09 9:04 ` Pekka Enberg
2012-07-09 9:04 ` Pekka Enberg
2012-07-09 13:53 ` Christoph Lameter
2012-07-09 13:53 ` Christoph Lameter
2012-07-09 13:53 ` Christoph Lameter
2012-07-08 11:37 ` [PATCH 4/7] drivers/gpu/drm: " Julia Lawall
2012-07-08 11:37 ` Julia Lawall
2012-07-08 20:52 ` Paul Menzel
2012-07-08 20:52 ` Paul Menzel
2012-07-08 20:56 ` Julia Lawall
2012-07-08 20:56 ` Julia Lawall
2012-07-08 11:37 ` [PATCH 5/7] drivers/iommu/tegra-smmu.c: " Julia Lawall
2012-07-08 11:37 ` Julia Lawall
[not found] ` <1341747464-1772-6-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2012-07-23 17:59 ` Stephen Warren [this message]
2012-07-23 17:59 ` Stephen Warren
2012-07-23 17:59 ` Stephen Warren
[not found] ` <500D90F9.7030909-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-07-24 8:45 ` Hiroshi Doyu
2012-07-24 8:45 ` Hiroshi Doyu
2012-07-24 8:45 ` Hiroshi Doyu
2012-07-08 11:37 ` [PATCH 6/7] drivers/net/ethernet/broadcom/cnic.c: " Julia Lawall
2012-07-08 11:37 ` Julia Lawall
2012-07-09 22:25 ` [PATCH 6/7] drivers/net/ethernet/broadcom/cnic.c: remove invalid reference to list iterator vari David Miller
2012-07-09 22:25 ` [PATCH 6/7] drivers/net/ethernet/broadcom/cnic.c: remove invalid reference to list iterator variable David Miller
2012-07-08 11:37 ` [PATCH 7/7] drivers/s390/scsi/zfcp_cfdc.c: " Julia Lawall
2012-07-08 11:37 ` Julia Lawall
2012-08-20 18:30 ` Steffen Maier
2012-08-20 18:30 ` Steffen Maier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500D90F9.7030909@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Julia.Lawall-L2FTfq7BK8M@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.