From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] arm/dts: am33xx rtc node
Date: Wed, 25 Jul 2012 20:59:24 +0400 [thread overview]
Message-ID: <501025EC.6010600@mvista.com> (raw)
In-Reply-To: <C8443D0743D26F4388EA172BF4E2A7A93E9AD8B1@DBDE01.ent.ti.com>
Hello.
On 07/25/2012 06:09 PM, Mohammed, Afzal wrote:
>>> + rtc at 44e3e000 {
>> Address postfix in the node name without "reg" property?
> As per [1], "The unit-address is included if the node describes
> a device with an address".
Which in this case it doesn't.
> Here even though reg property is not present, as via hwmod
> (see below) it is getting address, isn't it better to have it
I think not.
>>> + compatible = "ti,da830-rtc";
>>> + ti,hwmods = "rtc";
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Mohammed, Afzal" <afzal@ti.com>
Cc: "Hilman, Kevin" <khilman@ti.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob@landley.net" <rob@landley.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 6/6] arm/dts: am33xx rtc node
Date: Wed, 25 Jul 2012 20:59:24 +0400 [thread overview]
Message-ID: <501025EC.6010600@mvista.com> (raw)
In-Reply-To: <C8443D0743D26F4388EA172BF4E2A7A93E9AD8B1@DBDE01.ent.ti.com>
Hello.
On 07/25/2012 06:09 PM, Mohammed, Afzal wrote:
>>> + rtc@44e3e000 {
>> Address postfix in the node name without "reg" property?
> As per [1], "The unit-address is included if the node describes
> a device with an address".
Which in this case it doesn't.
> Here even though reg property is not present, as via hwmod
> (see below) it is getting address, isn't it better to have it
I think not.
>>> + compatible = "ti,da830-rtc";
>>> + ti,hwmods = "rtc";
WBR, Sergei
next prev parent reply other threads:[~2012-07-25 16:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 6:11 [PATCH v2 0/6] omap-am33xx rtc dt support Afzal Mohammed
[not found] ` <cover.1343191280.git.afzal-l0cyMroinI0@public.gmane.org>
2012-07-25 6:12 ` [PATCH v2 1/6] rtc: omap: kicker mechanism support Afzal Mohammed
2012-07-25 11:15 ` Sergei Shtylyov
2012-07-25 11:15 ` Sergei Shtylyov
2012-07-25 11:15 ` Sergei Shtylyov
2012-07-25 14:01 ` Mohammed, Afzal
2012-07-25 14:01 ` Mohammed, Afzal
2012-07-25 6:12 ` [PATCH v2 2/6] ARM: davinci: remove rtc kicker release Afzal Mohammed
2012-07-25 6:12 ` [PATCH v2 3/6] rtc: omap: dt support Afzal Mohammed
2012-07-25 6:12 ` [PATCH v2 4/6] rtc: omap: depend on am33xx Afzal Mohammed
2012-07-25 6:12 ` [PATCH v2 5/6] rtc: omap: Add runtime pm support Afzal Mohammed
2012-07-25 6:12 ` [PATCH v2 6/6] arm/dts: am33xx rtc node Afzal Mohammed
2012-07-25 11:20 ` Sergei Shtylyov
2012-07-25 11:20 ` Sergei Shtylyov
2012-07-25 14:09 ` Mohammed, Afzal
2012-07-25 14:09 ` Mohammed, Afzal
2012-07-25 14:09 ` Mohammed, Afzal
2012-07-25 16:59 ` Sergei Shtylyov [this message]
2012-07-25 16:59 ` Sergei Shtylyov
2012-07-26 8:04 ` Mohammed, Afzal
2012-07-26 8:04 ` Mohammed, Afzal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501025EC.6010600@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.