From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: qemu-trivial@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
"Alexander Graf" <agraf@suse.de>,
qemu-devel@nongnu.org, "Anthony Liguori" <anthony@codemonkey.ws>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-trivial] [PATCH] megasas: Update function megasys_scsi_uninit
Date: Wed, 01 Aug 2012 09:38:19 +0200 [thread overview]
Message-ID: <5018DCEB.9060208@redhat.com> (raw)
In-Reply-To: <50185960.9050700@suse.de>
Il 01/08/2012 00:17, Hannes Reinecke ha scritto:
> Ad 2: no, the SAS address for the devices is _not_ the WWN.
> The WWN is the ID of the LUN, whereas the SAS address is the ID of the
> Target. So to be correct we would need to generate unique SAS addressed
> per target which needs to be different from the WWN.
Oh, that's even easier then, just delete all the get_wwn stuff and use
HBA address + 1 + sdev->id.
Paolo
> However, megasas does not need to present SAS addresses here; we can set
> the interface to PCI-E (instead of SAS) and just use the LUN number.
> Sadly I've yet to figure out the code for PCIE.
> (Doing it correctly involves staring a binary output and figuring the
> meaning of bits. Did I mention I don't have documentation for that beast?)
> That's what's stalled the patch for now.
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: qemu-trivial@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
"Alexander Graf" <agraf@suse.de>,
qemu-devel@nongnu.org, "Anthony Liguori" <anthony@codemonkey.ws>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit
Date: Wed, 01 Aug 2012 09:38:19 +0200 [thread overview]
Message-ID: <5018DCEB.9060208@redhat.com> (raw)
In-Reply-To: <50185960.9050700@suse.de>
Il 01/08/2012 00:17, Hannes Reinecke ha scritto:
> Ad 2: no, the SAS address for the devices is _not_ the WWN.
> The WWN is the ID of the LUN, whereas the SAS address is the ID of the
> Target. So to be correct we would need to generate unique SAS addressed
> per target which needs to be different from the WWN.
Oh, that's even easier then, just delete all the get_wwn stuff and use
HBA address + 1 + sdev->id.
Paolo
> However, megasas does not need to present SAS addresses here; we can set
> the interface to PCI-E (instead of SAS) and just use the LUN number.
> Sadly I've yet to figure out the code for PCIE.
> (Doing it correctly involves staring a binary output and figuring the
> meaning of bits. Did I mention I don't have documentation for that beast?)
> That's what's stalled the patch for now.
next prev parent reply other threads:[~2012-08-01 7:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 5:54 [Qemu-trivial] [PATCH] megasas: Update function megasys_scsi_uninit Stefan Weil
2012-07-31 5:54 ` [Qemu-devel] " Stefan Weil
2012-07-31 14:13 ` Paolo Bonzini
2012-07-31 14:39 ` [Qemu-trivial] " Andreas Färber
2012-07-31 14:39 ` Andreas Färber
2012-07-31 14:43 ` [Qemu-trivial] " Paolo Bonzini
2012-07-31 14:43 ` Paolo Bonzini
2012-07-31 14:46 ` [Qemu-trivial] " Andreas Färber
2012-07-31 14:46 ` Andreas Färber
2012-07-31 14:50 ` [Qemu-trivial] " Paolo Bonzini
2012-07-31 14:50 ` Paolo Bonzini
2012-07-31 14:55 ` [Qemu-trivial] " Andreas Färber
2012-07-31 14:55 ` Andreas Färber
2012-07-31 15:15 ` [Qemu-trivial] " Anthony Liguori
2012-07-31 15:15 ` Anthony Liguori
2012-07-31 15:45 ` [Qemu-trivial] " Paolo Bonzini
2012-07-31 15:45 ` Paolo Bonzini
2012-07-31 22:17 ` [Qemu-trivial] " Hannes Reinecke
2012-07-31 22:17 ` Hannes Reinecke
2012-08-01 7:38 ` Paolo Bonzini [this message]
2012-08-01 7:38 ` Paolo Bonzini
2012-08-01 7:54 ` [Qemu-trivial] " Hannes Reinecke
2012-08-01 7:54 ` [Qemu-devel] " Hannes Reinecke
2012-08-01 8:01 ` [Qemu-trivial] " Paolo Bonzini
2012-08-01 8:01 ` [Qemu-devel] " Paolo Bonzini
2012-08-01 9:15 ` [Qemu-trivial] " Hannes Reinecke
2012-08-01 9:15 ` [Qemu-devel] " Hannes Reinecke
2012-07-31 15:16 ` [Qemu-trivial] " Paolo Bonzini
2012-07-31 15:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5018DCEB.9060208@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=hare@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.