All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
	"Alexander Graf" <agraf@suse.de>,
	qemu-devel@nongnu.org, "Anthony Liguori" <anthony@codemonkey.ws>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-trivial] [PATCH] megasas: Update function megasys_scsi_uninit
Date: Wed, 01 Aug 2012 11:15:08 +0200	[thread overview]
Message-ID: <5018F39C.6090904@suse.de> (raw)
In-Reply-To: <5018E25E.4010801@redhat.com>

On 08/01/2012 10:01 AM, Paolo Bonzini wrote:
> Il 01/08/2012 09:54, Hannes Reinecke ha scritto:
>> On 08/01/2012 09:38 AM, Paolo Bonzini wrote:
>>> Il 01/08/2012 00:17, Hannes Reinecke ha scritto:
>>>> Ad 2: no, the SAS address for the devices is _not_ the WWN.
>>>> The WWN is the ID of the LUN, whereas the SAS address is the ID of the
>>>> Target. So to be correct we would need to generate unique SAS addressed
>>>> per target which needs to be different from the WWN.
>>>
>>> Oh, that's even easier then, just delete all the get_wwn stuff and use
>>> HBA address + 1 + sdev->id.
>>>
>> Which HBA address?
> 
> The HBA SAS address. :)
> 
Ah.

I've now send a new patch fixing things up.
Hopefully it gains Anthonys approval.

Anthony, I'm dead sorry but didn't manage to type your e-mail
address correctly.
Hope it doesn't fall through the cracks because of this ..

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)




WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
	"Alexander Graf" <agraf@suse.de>,
	qemu-devel@nongnu.org, "Anthony Liguori" <anthony@codemonkey.ws>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit
Date: Wed, 01 Aug 2012 11:15:08 +0200	[thread overview]
Message-ID: <5018F39C.6090904@suse.de> (raw)
In-Reply-To: <5018E25E.4010801@redhat.com>

On 08/01/2012 10:01 AM, Paolo Bonzini wrote:
> Il 01/08/2012 09:54, Hannes Reinecke ha scritto:
>> On 08/01/2012 09:38 AM, Paolo Bonzini wrote:
>>> Il 01/08/2012 00:17, Hannes Reinecke ha scritto:
>>>> Ad 2: no, the SAS address for the devices is _not_ the WWN.
>>>> The WWN is the ID of the LUN, whereas the SAS address is the ID of the
>>>> Target. So to be correct we would need to generate unique SAS addressed
>>>> per target which needs to be different from the WWN.
>>>
>>> Oh, that's even easier then, just delete all the get_wwn stuff and use
>>> HBA address + 1 + sdev->id.
>>>
>> Which HBA address?
> 
> The HBA SAS address. :)
> 
Ah.

I've now send a new patch fixing things up.
Hopefully it gains Anthonys approval.

Anthony, I'm dead sorry but didn't manage to type your e-mail
address correctly.
Hope it doesn't fall through the cracks because of this ..

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

  reply	other threads:[~2012-08-01  9:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31  5:54 [Qemu-trivial] [PATCH] megasas: Update function megasys_scsi_uninit Stefan Weil
2012-07-31  5:54 ` [Qemu-devel] " Stefan Weil
2012-07-31 14:13 ` Paolo Bonzini
2012-07-31 14:39 ` [Qemu-trivial] " Andreas Färber
2012-07-31 14:39   ` Andreas Färber
2012-07-31 14:43   ` [Qemu-trivial] " Paolo Bonzini
2012-07-31 14:43     ` Paolo Bonzini
2012-07-31 14:46     ` [Qemu-trivial] " Andreas Färber
2012-07-31 14:46       ` Andreas Färber
2012-07-31 14:50       ` [Qemu-trivial] " Paolo Bonzini
2012-07-31 14:50         ` Paolo Bonzini
2012-07-31 14:55         ` [Qemu-trivial] " Andreas Färber
2012-07-31 14:55           ` Andreas Färber
2012-07-31 15:15           ` [Qemu-trivial] " Anthony Liguori
2012-07-31 15:15             ` Anthony Liguori
2012-07-31 15:45             ` [Qemu-trivial] " Paolo Bonzini
2012-07-31 15:45               ` Paolo Bonzini
2012-07-31 22:17               ` [Qemu-trivial] " Hannes Reinecke
2012-07-31 22:17                 ` Hannes Reinecke
2012-08-01  7:38                 ` [Qemu-trivial] " Paolo Bonzini
2012-08-01  7:38                   ` [Qemu-devel] " Paolo Bonzini
2012-08-01  7:54                   ` [Qemu-trivial] " Hannes Reinecke
2012-08-01  7:54                     ` [Qemu-devel] " Hannes Reinecke
2012-08-01  8:01                     ` [Qemu-trivial] " Paolo Bonzini
2012-08-01  8:01                       ` [Qemu-devel] " Paolo Bonzini
2012-08-01  9:15                       ` Hannes Reinecke [this message]
2012-08-01  9:15                         ` Hannes Reinecke
2012-07-31 15:16           ` [Qemu-trivial] " Paolo Bonzini
2012-07-31 15:16             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5018F39C.6090904@suse.de \
    --to=hare@suse.de \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.