From: Vincent ETIENEN <ve@vetienne.net>
To: Sunil Mushran <sunil.mushran@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, Mark Fasheh <mfasheh@suse.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] kernel BUG at fs/buffer.c:2886! Linux 3.5.0
Date: Fri, 03 Aug 2012 09:22:29 +0200 [thread overview]
Message-ID: <501B7C35.1050602@vetienne.net> (raw)
In-Reply-To: <CAEeiSHWM2j3rFSGHtd06QRxT2NaL1gF8k5zPYKn6AYp=06dy1g@mail.gmail.com>
Le 02/08/2012 23:08, Sunil Mushran a ?crit :
> On Thu, Aug 2, 2012 at 12:28 PM, Vincent ETIENNE <ve@vetienne.net
> <mailto:ve@vetienne.net>> wrote:
>
> Hi
>
> based on current git ( commit
> 1a9b4993b70fb1884716902774dc9025b457760d )
> and reverting commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1
>
> commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1
> Author: Al Viro <viro@zeniv.linux.org.uk
> <mailto:viro@zeniv.linux.org.uk>>
> Date: Thu May 3 10:14:29 2012 -0400
>
> ocfs: simplify symlink handling
>
> and adding the correction from
>
> https://oss.oracle.com/git/?p=smushran/linux-2.6.git;a=commit;h=a2118b301104a24381b414bc93371d666fe8d43a
>
> suppres the fallocate bug
>
> and lead to no oops. At least immediatly. Will let it run some times
>
>
>
> Apply this change and re-run:
>
> diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c
> index f1fbb4b..66edce7 100644
> --- a/fs/ocfs2/symlink.c
> +++ b/fs/ocfs2/symlink.c
> @@ -57,7 +57,7 @@
> static int ocfs2_fast_symlink_readpage(struct file *unused, struct
> page *page)
> {
> struct inode *inode = page->mapping->host;
> - struct buffer_head *bh;
> + struct buffer_head *bh = NULL;
> int status = ocfs2_read_inode_block(inode, &bh);
> struct ocfs2_dinode *fe;
> const char *link;
>
latest head with only your two changes is working here, thanks a lot.
Running now flowlessly since a few hours.
Vincent
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20120803/61814922/attachment.html
WARNING: multiple messages have this Message-ID (diff)
From: Vincent ETIENEN <ve@vetienne.net>
To: Sunil Mushran <sunil.mushran@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, Mark Fasheh <mfasheh@suse.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
ocfs2-devel@oss.oracle.com
Subject: Re: kernel BUG at fs/buffer.c:2886! Linux 3.5.0
Date: Fri, 03 Aug 2012 09:22:29 +0200 [thread overview]
Message-ID: <501B7C35.1050602@vetienne.net> (raw)
In-Reply-To: <CAEeiSHWM2j3rFSGHtd06QRxT2NaL1gF8k5zPYKn6AYp=06dy1g@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1533 bytes --]
Le 02/08/2012 23:08, Sunil Mushran a écrit :
> On Thu, Aug 2, 2012 at 12:28 PM, Vincent ETIENNE <ve@vetienne.net
> <mailto:ve@vetienne.net>> wrote:
>
> Hi
>
> based on current git ( commit
> 1a9b4993b70fb1884716902774dc9025b457760d )
> and reverting commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1
>
> commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1
> Author: Al Viro <viro@zeniv.linux.org.uk
> <mailto:viro@zeniv.linux.org.uk>>
> Date: Thu May 3 10:14:29 2012 -0400
>
> ocfs: simplify symlink handling
>
> and adding the correction from
>
> https://oss.oracle.com/git/?p=smushran/linux-2.6.git;a=commit;h=a2118b301104a24381b414bc93371d666fe8d43a
>
> suppres the fallocate bug
>
> and lead to no oops. At least immediatly. Will let it run some times
>
>
>
> Apply this change and re-run:
>
> diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c
> index f1fbb4b..66edce7 100644
> --- a/fs/ocfs2/symlink.c
> +++ b/fs/ocfs2/symlink.c
> @@ -57,7 +57,7 @@
> static int ocfs2_fast_symlink_readpage(struct file *unused, struct
> page *page)
> {
> struct inode *inode = page->mapping->host;
> - struct buffer_head *bh;
> + struct buffer_head *bh = NULL;
> int status = ocfs2_read_inode_block(inode, &bh);
> struct ocfs2_dinode *fe;
> const char *link;
>
latest head with only your two changes is working here, thanks a lot.
Running now flowlessly since a few hours.
Vincent
[-- Attachment #1.2: Type: text/html, Size: 3242 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2012-08-03 7:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 22:18 kernel BUG at fs/buffer.c:2886! Linux 3.5.0 Vincent ETIENNE
2012-07-27 22:18 ` [Ocfs2-devel] " Vincent ETIENNE
2012-07-30 6:30 ` Joel Becker
2012-07-30 6:30 ` Joel Becker
2012-07-30 7:45 ` Vincent ETIENNE
2012-07-30 7:45 ` [Ocfs2-devel] " Vincent ETIENNE
2012-07-30 7:45 ` Vincent ETIENNE
2012-07-30 7:53 ` [Ocfs2-devel] " Joel Becker
2012-07-30 7:53 ` Joel Becker
2012-07-30 15:59 ` [Ocfs2-devel] " Sunil Mushran
2012-07-30 15:59 ` Sunil Mushran
2012-07-30 18:30 ` Vincent ETIENNE
2012-07-30 18:30 ` [Ocfs2-devel] " Vincent ETIENNE
2012-08-01 16:51 ` Vincent ETIENNE
2012-08-01 16:51 ` Vincent ETIENNE
2012-08-01 20:43 ` [Ocfs2-devel] " Vincent ETIENNE
2012-08-01 20:43 ` Vincent ETIENNE
2012-08-01 20:46 ` [Ocfs2-devel] " Vincent ETIENNE
2012-08-01 20:46 ` Vincent ETIENNE
2012-08-02 7:21 ` [Ocfs2-devel] " Vincent ETIENNE
2012-08-02 7:21 ` Vincent ETIENNE
2012-08-02 19:28 ` [Ocfs2-devel] " Vincent ETIENNE
2012-08-02 19:28 ` Vincent ETIENNE
2012-08-02 21:08 ` [Ocfs2-devel] " Sunil Mushran
2012-08-02 21:08 ` Sunil Mushran
2012-08-03 7:22 ` Vincent ETIENEN [this message]
2012-08-03 7:22 ` Vincent ETIENEN
2012-08-03 16:16 ` [Ocfs2-devel] " Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501B7C35.1050602@vetienne.net \
--to=ve@vetienne.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sunil.mushran@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.