From: Aaron Lu <aaron.lu@amd.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Tejun Heo <tj@kernel.org>, Jens Axboe <jaxboe@fusionio.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Alan Stern <stern@rowland.harvard.edu>,
Sergei Shtylyov <sshtylyov@mvista.com>,
Oliver Neukum <oneukum@suse.de>, Jeff Wu <jeff.wu@amd.com>,
Lin Ming <minggr@gmail.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Aaron Lu <aaron.lwe@gmail.com>
Subject: Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended
Date: Tue, 7 Aug 2012 14:18:11 +0800 [thread overview]
Message-ID: <5020B323.4010102@amd.com> (raw)
In-Reply-To: <501BE5B2.5040901@pobox.com>
On 08/03/2012 10:52 PM, Jeff Garzik wrote:
> On 08/03/2012 05:50 AM, Aaron Lu wrote:
>> Hello,
>>
>> Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any
>> comments?
>
> Typically you follow the pattern of similar exports in the file (or in
> the API, if no others are in the file).
Thanks Jeff for your suggestion, and I'll keep using EXPORT_SYMBOL.
If anyone thinks this is wrong, please kindly let me know, thanks.
-Aaron
WARNING: multiple messages have this Message-ID (diff)
From: Aaron Lu <aaron.lu@amd.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Tejun Heo <tj@kernel.org>, Jens Axboe <jaxboe@fusionio.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Alan Stern <stern@rowland.harvard.edu>,
Sergei Shtylyov <sshtylyov@mvista.com>,
Oliver Neukum <oneukum@suse.de>, Jeff Wu <jeff.wu@amd.com>,
Lin Ming <minggr@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-ide@vger.kernel.org>, Aaron Lu <aaron.lwe@gmail.com>
Subject: Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended
Date: Tue, 7 Aug 2012 14:18:11 +0800 [thread overview]
Message-ID: <5020B323.4010102@amd.com> (raw)
In-Reply-To: <501BE5B2.5040901@pobox.com>
On 08/03/2012 10:52 PM, Jeff Garzik wrote:
> On 08/03/2012 05:50 AM, Aaron Lu wrote:
>> Hello,
>>
>> Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any
>> comments?
>
> Typically you follow the pattern of similar exports in the file (or in
> the API, if no others are in the file).
Thanks Jeff for your suggestion, and I'll keep using EXPORT_SYMBOL.
If anyone thinks this is wrong, please kindly let me know, thanks.
-Aaron
next prev parent reply other threads:[~2012-08-07 6:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 9:00 [PATCH v4 0/7] ZPODD patches Aaron Lu
2012-07-27 9:00 ` Aaron Lu
2012-07-27 9:00 ` [PATCH v4 1/7] scsi: sr: check support for device busy class events Aaron Lu
2012-07-27 9:00 ` Aaron Lu
2012-07-27 9:00 ` [PATCH v4 2/7] scsi: pm: add interface to autosuspend scsi device Aaron Lu
2012-07-27 9:00 ` Aaron Lu
2012-07-27 9:00 ` [PATCH v4 3/7] scsi: sr: support zero power ODD(ZPODD) Aaron Lu
2012-07-27 9:00 ` Aaron Lu
2012-07-27 9:00 ` [PATCH v4 4/7] scsi: sr: block events when runtime suspended Aaron Lu
2012-07-27 9:00 ` Aaron Lu
2012-08-03 9:50 ` Aaron Lu
2012-08-03 9:50 ` Aaron Lu
2012-08-03 14:52 ` Jeff Garzik
2012-08-07 6:18 ` Aaron Lu [this message]
2012-08-07 6:18 ` Aaron Lu
2012-07-27 9:00 ` [PATCH v4 5/7] scsi: pm: use runtime resume callback if available Aaron Lu
2012-07-27 9:00 ` Aaron Lu
2012-07-27 9:00 ` [PATCH v4 6/7] scsi: sr: balance sr disk events block depth Aaron Lu
2012-07-27 9:00 ` Aaron Lu
2012-07-27 9:00 ` [PATCH v4 7/7] block: genhd: add an interface to set disk's poll interval Aaron Lu
2012-07-27 9:00 ` Aaron Lu
2012-07-31 2:40 ` [PATCH v4 0/7] ZPODD patches Aaron Lu
2012-07-31 2:40 ` Aaron Lu
2012-07-31 8:39 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5020B323.4010102@amd.com \
--to=aaron.lu@amd.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aaron.lwe@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=jeff.wu@amd.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=minggr@gmail.com \
--cc=oneukum@suse.de \
--cc=sshtylyov@mvista.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.