From: Stephen Warren <swarren@wwwdotorg.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's
Date: Wed, 08 Aug 2012 18:43:14 +0000 [thread overview]
Message-ID: <5022B342.7080606@wwwdotorg.org> (raw)
In-Reply-To: <1344389967-8465-2-git-send-email-linux@prisktech.co.nz>
On 08/07/2012 07:39 PM, Tony Prisk wrote:
> Add device tree files for VT8500, WM8505 and WM8650 SoC's and
> reference boards.
> diff --git a/arch/arm/boot/dts/vt8500_ref.dts b/arch/arm/boot/dts/vt8500_ref.dts
It appears more typical to use "-" rather than "_" in the filename to
join SoC and board names.
I guess "_ref" means "reference". Is that how the boards are commonly
known? Are you sure there will never be another reference board for
these SoCs? Given the "model" values in the file, something more like
vt8500-bv07.dts might be more appropriate?
> + /*
> + * Display node is based on Sascha Hauer's patch on dri-devel.
> + * Added a bpp property to calculate the size of the framebuffer
> + * until the binding is formalized.
> + */
> + display {
Maybe it's better to just hold off on adding this node, to wait until
the binding is complete so this file doesn't churn? Certainly it sounded
like Sascha was going to change the binding a little in response to
comments it received.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Tony Prisk <linux@prisktech.co.nz>
Cc: vt8500-wm8505-linux-kernel@googlegroups.com,
linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-doc@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
rtc-linux@googlegroups.com,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
Alan Stern <stern@rowland.harvard.edu>,
Eric Andersson <eric.andersson@unixphere.com>,
linux-serial@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>,
Stephen Warren <swarren@nvidia.com>,
Neil Zhang <zhangwm@marvell.com>,
linux-arm-kernel@lists.infradead.org,
Alan Cox <alan@linux.intel.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Linus Walleij <linus.walleij@stericsson.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's
Date: Wed, 08 Aug 2012 12:43:14 -0600 [thread overview]
Message-ID: <5022B342.7080606@wwwdotorg.org> (raw)
In-Reply-To: <1344389967-8465-2-git-send-email-linux@prisktech.co.nz>
On 08/07/2012 07:39 PM, Tony Prisk wrote:
> Add device tree files for VT8500, WM8505 and WM8650 SoC's and
> reference boards.
> diff --git a/arch/arm/boot/dts/vt8500_ref.dts b/arch/arm/boot/dts/vt8500_ref.dts
It appears more typical to use "-" rather than "_" in the filename to
join SoC and board names.
I guess "_ref" means "reference". Is that how the boards are commonly
known? Are you sure there will never be another reference board for
these SoCs? Given the "model" values in the file, something more like
vt8500-bv07.dts might be more appropriate?
> + /*
> + * Display node is based on Sascha Hauer's patch on dri-devel.
> + * Added a bpp property to calculate the size of the framebuffer
> + * until the binding is formalized.
> + */
> + display {
Maybe it's better to just hold off on adding this node, to wait until
the binding is complete so this file doesn't churn? Certainly it sounded
like Sascha was going to change the binding a little in response to
comments it received.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's
Date: Wed, 08 Aug 2012 12:43:14 -0600 [thread overview]
Message-ID: <5022B342.7080606@wwwdotorg.org> (raw)
In-Reply-To: <1344389967-8465-2-git-send-email-linux@prisktech.co.nz>
On 08/07/2012 07:39 PM, Tony Prisk wrote:
> Add device tree files for VT8500, WM8505 and WM8650 SoC's and
> reference boards.
> diff --git a/arch/arm/boot/dts/vt8500_ref.dts b/arch/arm/boot/dts/vt8500_ref.dts
It appears more typical to use "-" rather than "_" in the filename to
join SoC and board names.
I guess "_ref" means "reference". Is that how the boards are commonly
known? Are you sure there will never be another reference board for
these SoCs? Given the "model" values in the file, something more like
vt8500-bv07.dts might be more appropriate?
> + /*
> + * Display node is based on Sascha Hauer's patch on dri-devel.
> + * Added a bpp property to calculate the size of the framebuffer
> + * until the binding is formalized.
> + */
> + display {
Maybe it's better to just hold off on adding this node, to wait until
the binding is complete so this file doesn't churn? Certainly it sounded
like Sascha was going to change the binding a little in response to
comments it received.
next prev parent reply other threads:[~2012-08-08 18:43 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 1:39 [PATCH 0/8] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 18:43 ` Stephen Warren [this message]
2012-08-08 18:43 ` Stephen Warren
2012-08-08 18:43 ` Stephen Warren
[not found] ` <5022B342.7080606-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-08 20:08 ` Tony Prisk
2012-08-08 20:08 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 2/8] rtc: vt8500: Add devicetree support for vt8500-rtc Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 3/8] serial: vt8500: Add devicetree support for vt8500-serial Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 4/8] usb: vt8500: Add devicetree support for vt8500-ehci and -uhci Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 18:47 ` Stephen Warren
2012-08-08 18:47 ` Stephen Warren
2012-08-08 18:47 ` Stephen Warren
[not found] ` <5022B444.2020501-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-08 19:37 ` Tony Prisk
2012-08-08 19:37 ` Tony Prisk
[not found] ` <76F764B079F92A4E843589C893D0A022D1DCA8D0-A1+cU8XkcJSYgi1/3OOQJ8krCUz0bFs7@public.gmane.org>
2012-08-15 19:21 ` Stephen Warren
2012-08-15 19:21 ` Stephen Warren
2012-08-08 1:39 ` [PATCH 6/8] arm: vt8500: Update arch-vt8500 to devicetree support Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 18:58 ` Stephen Warren
2012-08-08 18:58 ` Stephen Warren
2012-08-08 18:58 ` Stephen Warren
[not found] ` <5022B6EE.7060006-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-08 19:37 ` Tony Prisk
2012-08-08 19:37 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 7/8] arm: vt8500: doc: Add device tree bindings for arch-vt8500 devices Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500 Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 1:39 ` Tony Prisk
2012-08-08 9:11 ` [rtc-linux] " Linus Walleij
2012-08-08 9:11 ` Linus Walleij
2012-08-08 9:11 ` Linus Walleij
2012-08-08 9:11 ` Linus Walleij
2012-08-08 9:19 ` Arnd Bergmann
2012-08-08 9:19 ` Arnd Bergmann
2012-08-08 9:19 ` Arnd Bergmann
2012-08-08 9:19 ` Arnd Bergmann
2012-08-08 14:28 ` Linus Walleij
2012-08-08 14:28 ` Linus Walleij
2012-08-08 14:28 ` Linus Walleij
2012-08-08 14:28 ` Linus Walleij
[not found] ` <CACRpkdabUWpDsBhz4ZEJNhEuqw-U+v-HrX7NcWoNLeuenv5t9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-08 19:46 ` Tony Prisk
2012-08-08 19:46 ` Tony Prisk
2012-08-08 18:38 ` Stephen Warren
2012-08-08 18:38 ` Stephen Warren
2012-08-08 18:38 ` Stephen Warren
2012-08-08 18:38 ` Stephen Warren
2012-08-08 19:17 ` Arnd Bergmann
2012-08-08 19:17 ` Arnd Bergmann
2012-08-08 19:17 ` Arnd Bergmann
2012-08-08 19:17 ` Arnd Bergmann
[not found] ` <1344389967-8465-1-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2012-08-08 2:40 ` [PATCH 0/8] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-08 2:40 ` Tony Prisk
2012-08-19 1:22 ` Marcos Silva Cunha
2012-08-19 1:22 ` Marcos Silva Cunha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5022B342.7080606@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.