All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500
Date: Wed, 08 Aug 2012 19:17:18 +0000	[thread overview]
Message-ID: <201208081917.19111.arnd@arndb.de> (raw)
In-Reply-To: <5022B242.1050001@wwwdotorg.org>

On Wednesday 08 August 2012, Stephen Warren wrote:
> I think that's all just:
> 
> module_platform_driver(vt8500_gpio_driver);
> 
> (except that _init uses platform_driver_probe() rather than
> platform_driver_register(), which seems unusual. I guess that explains
> the of_find_matching_node() above too.)

Ah, I totally missed both of these. Using platform_driver_register
is definitely preferred over platform_driver_probe in cases like
this, so using module_platform_driver is the right simplification.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	vt8500-wm8505-linux-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Florian Tobias Schandinat
	<FlorianSchandinat-Mmb7MZpHnFY@public.gmane.org>,
	Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Eric Andersson
	<eric.andersson-TStm8jYLEPpl57MIdRCFDg@public.gmane.org>,
	linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Neil Zhang <zhangwm-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	Linus Walleij
	<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500
Date: Wed, 8 Aug 2012 19:17:18 +0000	[thread overview]
Message-ID: <201208081917.19111.arnd@arndb.de> (raw)
In-Reply-To: <5022B242.1050001-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

On Wednesday 08 August 2012, Stephen Warren wrote:
> I think that's all just:
> 
> module_platform_driver(vt8500_gpio_driver);
> 
> (except that _init uses platform_driver_probe() rather than
> platform_driver_register(), which seems unusual. I guess that explains
> the of_find_matching_node() above too.)

Ah, I totally missed both of these. Using platform_driver_register
is definitely preferred over platform_driver_probe in cases like
this, so using module_platform_driver is the right simplification.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500
Date: Wed, 8 Aug 2012 19:17:18 +0000	[thread overview]
Message-ID: <201208081917.19111.arnd@arndb.de> (raw)
In-Reply-To: <5022B242.1050001@wwwdotorg.org>

On Wednesday 08 August 2012, Stephen Warren wrote:
> I think that's all just:
> 
> module_platform_driver(vt8500_gpio_driver);
> 
> (except that _init uses platform_driver_probe() rather than
> platform_driver_register(), which seems unusual. I guess that explains
> the of_find_matching_node() above too.)

Ah, I totally missed both of these. Using platform_driver_register
is definitely preferred over platform_driver_probe in cases like
this, so using module_platform_driver is the right simplification.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Tony Prisk <linux@prisktech.co.nz>,
	vt8500-wm8505-linux-kernel@googlegroups.com,
	Russell King <linux@arm.linux.org.uk>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Alan Cox <alan@linux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Hauke Mehrtens <hauke@hauke-m.de>, Felipe Balbi <balbi@ti.com>,
	Neil Zhang <zhangwm@marvell.com>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Rob Landley <rob@landley.net>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Stephen Warren <swarren@nvidia.com>,
	Eric Andersson <eric.andersson@unixphere.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-serial@vger.kernel.org, rtc-linux@googlegroups.com,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500
Date: Wed, 8 Aug 2012 19:17:18 +0000	[thread overview]
Message-ID: <201208081917.19111.arnd@arndb.de> (raw)
In-Reply-To: <5022B242.1050001@wwwdotorg.org>

On Wednesday 08 August 2012, Stephen Warren wrote:
> I think that's all just:
> 
> module_platform_driver(vt8500_gpio_driver);
> 
> (except that _init uses platform_driver_probe() rather than
> platform_driver_register(), which seems unusual. I guess that explains
> the of_find_matching_node() above too.)

Ah, I totally missed both of these. Using platform_driver_register
is definitely preferred over platform_driver_probe in cases like
this, so using module_platform_driver is the right simplification.

	Arnd

  reply	other threads:[~2012-08-08 19:17 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08  1:39 [PATCH 0/8] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-08  1:39 ` Tony Prisk
2012-08-08  1:39 ` Tony Prisk
2012-08-08  1:39 ` Tony Prisk
2012-08-08  1:39 ` [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08 18:43   ` Stephen Warren
2012-08-08 18:43     ` Stephen Warren
2012-08-08 18:43     ` Stephen Warren
     [not found]     ` <5022B342.7080606-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-08 20:08       ` Tony Prisk
2012-08-08 20:08         ` Tony Prisk
2012-08-08  1:39 ` [PATCH 2/8] rtc: vt8500: Add devicetree support for vt8500-rtc Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39 ` [PATCH 3/8] serial: vt8500: Add devicetree support for vt8500-serial Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39 ` [PATCH 4/8] usb: vt8500: Add devicetree support for vt8500-ehci and -uhci Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39 ` [PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08 18:47   ` Stephen Warren
2012-08-08 18:47     ` Stephen Warren
2012-08-08 18:47     ` Stephen Warren
     [not found]     ` <5022B444.2020501-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-08 19:37       ` Tony Prisk
2012-08-08 19:37         ` Tony Prisk
     [not found]         ` <76F764B079F92A4E843589C893D0A022D1DCA8D0-A1+cU8XkcJSYgi1/3OOQJ8krCUz0bFs7@public.gmane.org>
2012-08-15 19:21           ` Stephen Warren
2012-08-15 19:21             ` Stephen Warren
2012-08-08  1:39 ` [PATCH 6/8] arm: vt8500: Update arch-vt8500 to devicetree support Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08 18:58   ` Stephen Warren
2012-08-08 18:58     ` Stephen Warren
2012-08-08 18:58     ` Stephen Warren
     [not found]     ` <5022B6EE.7060006-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-08 19:37       ` Tony Prisk
2012-08-08 19:37         ` Tony Prisk
2012-08-08  1:39 ` [PATCH 7/8] arm: vt8500: doc: Add device tree bindings for arch-vt8500 devices Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39 ` [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500 Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  1:39   ` Tony Prisk
2012-08-08  9:11   ` [rtc-linux] " Linus Walleij
2012-08-08  9:11     ` Linus Walleij
2012-08-08  9:11     ` Linus Walleij
2012-08-08  9:11     ` Linus Walleij
2012-08-08  9:19     ` Arnd Bergmann
2012-08-08  9:19       ` Arnd Bergmann
2012-08-08  9:19       ` Arnd Bergmann
2012-08-08  9:19       ` Arnd Bergmann
2012-08-08 14:28       ` Linus Walleij
2012-08-08 14:28         ` Linus Walleij
2012-08-08 14:28         ` Linus Walleij
2012-08-08 14:28         ` Linus Walleij
     [not found]         ` <CACRpkdabUWpDsBhz4ZEJNhEuqw-U+v-HrX7NcWoNLeuenv5t9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-08 19:46           ` Tony Prisk
2012-08-08 19:46             ` Tony Prisk
2012-08-08 18:38   ` Stephen Warren
2012-08-08 18:38     ` Stephen Warren
2012-08-08 18:38     ` Stephen Warren
2012-08-08 18:38     ` Stephen Warren
2012-08-08 19:17     ` Arnd Bergmann [this message]
2012-08-08 19:17       ` Arnd Bergmann
2012-08-08 19:17       ` Arnd Bergmann
2012-08-08 19:17       ` Arnd Bergmann
     [not found] ` <1344389967-8465-1-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2012-08-08  2:40   ` [PATCH 0/8] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-08  2:40     ` Tony Prisk
2012-08-19  1:22 ` Marcos Silva Cunha
2012-08-19  1:22   ` Marcos Silva Cunha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208081917.19111.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.