Re: [PATCH] ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V

[David Henningsson <david.henningsson@canonical.com>]

On 08/09/2012 10:54 AM, Takashi Iwai wrote:
> At Thu,  9 Aug 2012 10:35:27 +0200,
> David Henningsson wrote:
>>
>> To turn off pin control for the pin was tested, and helped against
>> this issue.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1034779
>> Tested-by: Chih-Hsyuan Ho <chih.ho@canonical.com>
>> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
>> ---
>>   sound/pci/hda/patch_via.c |    8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> Alsa-info at: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1034779/+attachment/3254105/+files/asus-x55a-alsa-info.log
>>
>> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
>> index 80d90cb..c9484fe 100644
>> --- a/sound/pci/hda/patch_via.c
>> +++ b/sound/pci/hda/patch_via.c
>> @@ -1752,6 +1752,14 @@ static int via_suspend(struct hda_codec *codec)
>>   {
>>   	struct via_spec *spec = codec->spec;
>>   	vt1708_stop_hp_work(spec);
>> +
>> +	if (spec->codec_type == VT1802) {
>> +		/* Fix pop noise on headphones */
>> +		int i;
>> +		for (i = 0; i < spec->autocfg.hp_outs; i++)
>> +			snd_hda_set_pin_ctl(codec, spec->autocfg.hp_pins[0], 0);
>
> Shouldn't this be spec->autocfg.hp_pins[i]?

D'oh. Thanks for the review, sent new patch. Of course the actual 
machine only had one HP out, so the bug was not discovered by testing.



-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic