* [PATCH] ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V
@ 2012-08-09 8:35 David Henningsson
2012-08-09 8:54 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: David Henningsson @ 2012-08-09 8:35 UTC (permalink / raw)
To: tiwai, alsa-devel; +Cc: 1034779, David Henningsson
To turn off pin control for the pin was tested, and helped against
this issue.
BugLink: https://bugs.launchpad.net/bugs/1034779
Tested-by: Chih-Hsyuan Ho <chih.ho@canonical.com>
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
sound/pci/hda/patch_via.c | 8 ++++++++
1 file changed, 8 insertions(+)
Alsa-info at: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1034779/+attachment/3254105/+files/asus-x55a-alsa-info.log
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 80d90cb..c9484fe 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -1752,6 +1752,14 @@ static int via_suspend(struct hda_codec *codec)
{
struct via_spec *spec = codec->spec;
vt1708_stop_hp_work(spec);
+
+ if (spec->codec_type == VT1802) {
+ /* Fix pop noise on headphones */
+ int i;
+ for (i = 0; i < spec->autocfg.hp_outs; i++)
+ snd_hda_set_pin_ctl(codec, spec->autocfg.hp_pins[0], 0);
+ }
+
return 0;
}
#endif
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V
2012-08-09 8:35 [PATCH] ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V David Henningsson
@ 2012-08-09 8:54 ` Takashi Iwai
2012-08-09 8:57 ` David Henningsson
0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2012-08-09 8:54 UTC (permalink / raw)
To: David Henningsson; +Cc: alsa-devel, 1034779
At Thu, 9 Aug 2012 10:35:27 +0200,
David Henningsson wrote:
>
> To turn off pin control for the pin was tested, and helped against
> this issue.
>
> BugLink: https://bugs.launchpad.net/bugs/1034779
> Tested-by: Chih-Hsyuan Ho <chih.ho@canonical.com>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
> sound/pci/hda/patch_via.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> Alsa-info at: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1034779/+attachment/3254105/+files/asus-x55a-alsa-info.log
>
> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> index 80d90cb..c9484fe 100644
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -1752,6 +1752,14 @@ static int via_suspend(struct hda_codec *codec)
> {
> struct via_spec *spec = codec->spec;
> vt1708_stop_hp_work(spec);
> +
> + if (spec->codec_type == VT1802) {
> + /* Fix pop noise on headphones */
> + int i;
> + for (i = 0; i < spec->autocfg.hp_outs; i++)
> + snd_hda_set_pin_ctl(codec, spec->autocfg.hp_pins[0], 0);
Shouldn't this be spec->autocfg.hp_pins[i]?
thanks,
Takashi
> + }
> +
> return 0;
> }
> #endif
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V
2012-08-09 8:54 ` Takashi Iwai
@ 2012-08-09 8:57 ` David Henningsson
0 siblings, 0 replies; 5+ messages in thread
From: David Henningsson @ 2012-08-09 8:57 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, 1034779
On 08/09/2012 10:54 AM, Takashi Iwai wrote:
> At Thu, 9 Aug 2012 10:35:27 +0200,
> David Henningsson wrote:
>>
>> To turn off pin control for the pin was tested, and helped against
>> this issue.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1034779
>> Tested-by: Chih-Hsyuan Ho <chih.ho@canonical.com>
>> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
>> ---
>> sound/pci/hda/patch_via.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> Alsa-info at: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1034779/+attachment/3254105/+files/asus-x55a-alsa-info.log
>>
>> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
>> index 80d90cb..c9484fe 100644
>> --- a/sound/pci/hda/patch_via.c
>> +++ b/sound/pci/hda/patch_via.c
>> @@ -1752,6 +1752,14 @@ static int via_suspend(struct hda_codec *codec)
>> {
>> struct via_spec *spec = codec->spec;
>> vt1708_stop_hp_work(spec);
>> +
>> + if (spec->codec_type == VT1802) {
>> + /* Fix pop noise on headphones */
>> + int i;
>> + for (i = 0; i < spec->autocfg.hp_outs; i++)
>> + snd_hda_set_pin_ctl(codec, spec->autocfg.hp_pins[0], 0);
>
> Shouldn't this be spec->autocfg.hp_pins[i]?
D'oh. Thanks for the review, sent new patch. Of course the actual
machine only had one HP out, so the bug was not discovered by testing.
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V
@ 2012-08-09 8:56 David Henningsson
2012-08-09 9:01 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: David Henningsson @ 2012-08-09 8:56 UTC (permalink / raw)
To: tiwai, alsa-devel; +Cc: 1034779, David Henningsson
To turn off pin control for the pin was tested, and helped against
this issue.
BugLink: https://bugs.launchpad.net/bugs/1034779
Tested-by: Chih-Hsyuan Ho <chih.ho@canonical.com>
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
sound/pci/hda/patch_via.c | 8 ++++++++
1 file changed, 8 insertions(+)
Alsa-info at: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1034779/+attachment/3254105/+files/asus-x55a-alsa-info.log
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 80d90cb..c9484fe 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -1752,6 +1752,14 @@ static int via_suspend(struct hda_codec *codec)
{
struct via_spec *spec = codec->spec;
vt1708_stop_hp_work(spec);
+
+ if (spec->codec_type == VT1802) {
+ /* Fix pop noise on headphones */
+ int i;
+ for (i = 0; i < spec->autocfg.hp_outs; i++)
+ snd_hda_set_pin_ctl(codec, spec->autocfg.hp_pins[i], 0);
+ }
+
return 0;
}
#endif
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V
2012-08-09 8:56 David Henningsson
@ 2012-08-09 9:01 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2012-08-09 9:01 UTC (permalink / raw)
To: David Henningsson; +Cc: alsa-devel, 1034779
At Thu, 9 Aug 2012 10:56:12 +0200,
David Henningsson wrote:
>
> To turn off pin control for the pin was tested, and helped against
> this issue.
>
> BugLink: https://bugs.launchpad.net/bugs/1034779
> Tested-by: Chih-Hsyuan Ho <chih.ho@canonical.com>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Thanks, applied.
Takashi
> ---
> sound/pci/hda/patch_via.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> Alsa-info at: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1034779/+attachment/3254105/+files/asus-x55a-alsa-info.log
>
> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> index 80d90cb..c9484fe 100644
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -1752,6 +1752,14 @@ static int via_suspend(struct hda_codec *codec)
> {
> struct via_spec *spec = codec->spec;
> vt1708_stop_hp_work(spec);
> +
> + if (spec->codec_type == VT1802) {
> + /* Fix pop noise on headphones */
> + int i;
> + for (i = 0; i < spec->autocfg.hp_outs; i++)
> + snd_hda_set_pin_ctl(codec, spec->autocfg.hp_pins[i], 0);
> + }
> +
> return 0;
> }
> #endif
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-09 8:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-09 8:35 [PATCH] ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V David Henningsson
2012-08-09 8:54 ` Takashi Iwai
2012-08-09 8:57 ` David Henningsson
-- strict thread matches above, loose matches on Subject: below --
2012-08-09 8:56 David Henningsson
2012-08-09 9:01 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.