From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org,
Alejandro Martinez Ruiz <alex@securiforest.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] ehci: fix assertion typo
Date: Tue, 14 Aug 2012 17:27:19 +0200 [thread overview]
Message-ID: <502A6E57.9070402@suse.de> (raw)
In-Reply-To: <1344953582-24303-1-git-send-email-alex@securiforest.com>
Am 14.08.2012 16:13, schrieb Alejandro Martinez Ruiz:
> Signed-off-by: Alejandro Martinez Ruiz <alex@securiforest.com>
> ---
> hw/usb/hcd-ehci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Patch looks like a sensible bugfix for 1.2, we most likely don't intend
to overwrite the status. Gerd, could you take a second look?
Andreas
>
> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
> index b043e7c..104c21d 100644
> --- a/hw/usb/hcd-ehci.c
> +++ b/hw/usb/hcd-ehci.c
> @@ -2010,7 +2010,7 @@ static void ehci_fill_queue(EHCIPacket *p)
> p->qtdaddr = qtdaddr;
> p->qtd = qtd;
> p->usb_status = ehci_execute(p, "queue");
> - assert(p->usb_status = USB_RET_ASYNC);
> + assert(p->usb_status == USB_RET_ASYNC);
> p->async = EHCI_ASYNC_INFLIGHT;
> }
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org,
Alejandro Martinez Ruiz <alex@securiforest.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ehci: fix assertion typo
Date: Tue, 14 Aug 2012 17:27:19 +0200 [thread overview]
Message-ID: <502A6E57.9070402@suse.de> (raw)
In-Reply-To: <1344953582-24303-1-git-send-email-alex@securiforest.com>
Am 14.08.2012 16:13, schrieb Alejandro Martinez Ruiz:
> Signed-off-by: Alejandro Martinez Ruiz <alex@securiforest.com>
> ---
> hw/usb/hcd-ehci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Patch looks like a sensible bugfix for 1.2, we most likely don't intend
to overwrite the status. Gerd, could you take a second look?
Andreas
>
> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
> index b043e7c..104c21d 100644
> --- a/hw/usb/hcd-ehci.c
> +++ b/hw/usb/hcd-ehci.c
> @@ -2010,7 +2010,7 @@ static void ehci_fill_queue(EHCIPacket *p)
> p->qtdaddr = qtdaddr;
> p->qtd = qtd;
> p->usb_status = ehci_execute(p, "queue");
> - assert(p->usb_status = USB_RET_ASYNC);
> + assert(p->usb_status == USB_RET_ASYNC);
> p->async = EHCI_ASYNC_INFLIGHT;
> }
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-08-14 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 14:13 [Qemu-trivial] [PATCH] ehci: fix assertion typo Alejandro Martinez Ruiz
2012-08-14 14:13 ` [Qemu-devel] " Alejandro Martinez Ruiz
2012-08-14 15:27 ` Andreas Färber [this message]
2012-08-14 15:27 ` Andreas Färber
2012-08-15 13:35 ` [Qemu-trivial] " Stefan Hajnoczi
2012-08-15 13:35 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A6E57.9070402@suse.de \
--to=afaerber@suse.de \
--cc=alex@securiforest.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.