* [Qemu-trivial] [PATCH] ehci: fix assertion typo
@ 2012-08-14 14:13 ` Alejandro Martinez Ruiz
0 siblings, 0 replies; 6+ messages in thread
From: Alejandro Martinez Ruiz @ 2012-08-14 14:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Signed-off-by: Alejandro Martinez Ruiz <alex@securiforest.com>
---
hw/usb/hcd-ehci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index b043e7c..104c21d 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2010,7 +2010,7 @@ static void ehci_fill_queue(EHCIPacket *p)
p->qtdaddr = qtdaddr;
p->qtd = qtd;
p->usb_status = ehci_execute(p, "queue");
- assert(p->usb_status = USB_RET_ASYNC);
+ assert(p->usb_status == USB_RET_ASYNC);
p->async = EHCI_ASYNC_INFLIGHT;
}
}
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] ehci: fix assertion typo
@ 2012-08-14 14:13 ` Alejandro Martinez Ruiz
0 siblings, 0 replies; 6+ messages in thread
From: Alejandro Martinez Ruiz @ 2012-08-14 14:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Signed-off-by: Alejandro Martinez Ruiz <alex@securiforest.com>
---
hw/usb/hcd-ehci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index b043e7c..104c21d 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2010,7 +2010,7 @@ static void ehci_fill_queue(EHCIPacket *p)
p->qtdaddr = qtdaddr;
p->qtd = qtd;
p->usb_status = ehci_execute(p, "queue");
- assert(p->usb_status = USB_RET_ASYNC);
+ assert(p->usb_status == USB_RET_ASYNC);
p->async = EHCI_ASYNC_INFLIGHT;
}
}
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] ehci: fix assertion typo
2012-08-14 14:13 ` [Qemu-devel] " Alejandro Martinez Ruiz
@ 2012-08-14 15:27 ` Andreas Färber
-1 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2012-08-14 15:27 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-trivial, Alejandro Martinez Ruiz, qemu-devel
Am 14.08.2012 16:13, schrieb Alejandro Martinez Ruiz:
> Signed-off-by: Alejandro Martinez Ruiz <alex@securiforest.com>
> ---
> hw/usb/hcd-ehci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Patch looks like a sensible bugfix for 1.2, we most likely don't intend
to overwrite the status. Gerd, could you take a second look?
Andreas
>
> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
> index b043e7c..104c21d 100644
> --- a/hw/usb/hcd-ehci.c
> +++ b/hw/usb/hcd-ehci.c
> @@ -2010,7 +2010,7 @@ static void ehci_fill_queue(EHCIPacket *p)
> p->qtdaddr = qtdaddr;
> p->qtd = qtd;
> p->usb_status = ehci_execute(p, "queue");
> - assert(p->usb_status = USB_RET_ASYNC);
> + assert(p->usb_status == USB_RET_ASYNC);
> p->async = EHCI_ASYNC_INFLIGHT;
> }
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] ehci: fix assertion typo
@ 2012-08-14 15:27 ` Andreas Färber
0 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2012-08-14 15:27 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-trivial, Alejandro Martinez Ruiz, qemu-devel
Am 14.08.2012 16:13, schrieb Alejandro Martinez Ruiz:
> Signed-off-by: Alejandro Martinez Ruiz <alex@securiforest.com>
> ---
> hw/usb/hcd-ehci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Patch looks like a sensible bugfix for 1.2, we most likely don't intend
to overwrite the status. Gerd, could you take a second look?
Andreas
>
> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
> index b043e7c..104c21d 100644
> --- a/hw/usb/hcd-ehci.c
> +++ b/hw/usb/hcd-ehci.c
> @@ -2010,7 +2010,7 @@ static void ehci_fill_queue(EHCIPacket *p)
> p->qtdaddr = qtdaddr;
> p->qtd = qtd;
> p->usb_status = ehci_execute(p, "queue");
> - assert(p->usb_status = USB_RET_ASYNC);
> + assert(p->usb_status == USB_RET_ASYNC);
> p->async = EHCI_ASYNC_INFLIGHT;
> }
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] ehci: fix assertion typo
2012-08-14 14:13 ` [Qemu-devel] " Alejandro Martinez Ruiz
@ 2012-08-15 13:35 ` Stefan Hajnoczi
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2012-08-15 13:35 UTC (permalink / raw)
To: Alejandro Martinez Ruiz; +Cc: qemu-trivial, qemu-devel
On Tue, Aug 14, 2012 at 04:13:02PM +0200, Alejandro Martinez Ruiz wrote:
> Signed-off-by: Alejandro Martinez Ruiz <alex@securiforest.com>
> ---
> hw/usb/hcd-ehci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good but would be good to hear from Gerd just to be sure.
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-15 13:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-14 14:13 [Qemu-trivial] [PATCH] ehci: fix assertion typo Alejandro Martinez Ruiz
2012-08-14 14:13 ` [Qemu-devel] " Alejandro Martinez Ruiz
2012-08-14 15:27 ` [Qemu-trivial] " Andreas Färber
2012-08-14 15:27 ` Andreas Färber
2012-08-15 13:35 ` [Qemu-trivial] " Stefan Hajnoczi
2012-08-15 13:35 ` [Qemu-devel] " Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.