From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dt: tegra: harmony: add regulators
Date: Fri, 17 Aug 2012 13:55:24 -0600 [thread overview]
Message-ID: <502EA1AC.4090205@wwwdotorg.org> (raw)
In-Reply-To: <502E9B09.3080800-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On 08/17/2012 01:27 PM, Stephen Warren wrote:
> On 08/17/2012 12:59 AM, Laxman Dewangan wrote:
>> Harmony uses a TPS6586x regulator. Instantiate this, and hook up a
>> couple of fixed GPIO-controlled regulators too.
>>
>> Based on Ventana regulator patch by Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> and converted to Harmony.
>
> Thanks, applied to Tegra's for-3.7/dt branch.
Oh hang on, this adds regulators to DT, but doesn't do anything to
remove the board-file registration of Harmony's regulators from
board-dt-tegra20.c, which end up conflicting, and preventing the PCIe
driver from being registered.
So, this patch really wants to remove the legacy code to, but doing so
will be problematic; to avoid runtime git bisect failures, we'd need to
merge the regulator tree in first, or wait until next kernel release or
something... Thoughts?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: swarren@nvidia.com, olof@lixom.net, linux@arm.linux.org.uk,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] ARM: dt: tegra: harmony: add regulators
Date: Fri, 17 Aug 2012 13:55:24 -0600 [thread overview]
Message-ID: <502EA1AC.4090205@wwwdotorg.org> (raw)
In-Reply-To: <502E9B09.3080800@wwwdotorg.org>
On 08/17/2012 01:27 PM, Stephen Warren wrote:
> On 08/17/2012 12:59 AM, Laxman Dewangan wrote:
>> Harmony uses a TPS6586x regulator. Instantiate this, and hook up a
>> couple of fixed GPIO-controlled regulators too.
>>
>> Based on Ventana regulator patch by Stephen Warren <swarren@nvidia.com>
>> and converted to Harmony.
>
> Thanks, applied to Tegra's for-3.7/dt branch.
Oh hang on, this adds regulators to DT, but doesn't do anything to
remove the board-file registration of Harmony's regulators from
board-dt-tegra20.c, which end up conflicting, and preventing the PCIe
driver from being registered.
So, this patch really wants to remove the legacy code to, but doing so
will be problematic; to avoid runtime git bisect failures, we'd need to
merge the regulator tree in first, or wait until next kernel release or
something... Thoughts?
next prev parent reply other threads:[~2012-08-17 19:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 6:59 [PATCH] ARM: dt: tegra: harmony: add regulators Laxman Dewangan
2012-08-17 6:59 ` Laxman Dewangan
[not found] ` <1345186799-18229-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-08-17 19:27 ` Stephen Warren
2012-08-17 19:27 ` Stephen Warren
[not found] ` <502E9B09.3080800-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-17 19:55 ` Stephen Warren [this message]
2012-08-17 19:55 ` Stephen Warren
[not found] ` <502EA1AC.4090205-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-20 17:22 ` Laxman Dewangan
2012-08-20 17:22 ` Laxman Dewangan
[not found] ` <50327242.80103-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-08-20 17:49 ` Stephen Warren
2012-08-20 17:49 ` Stephen Warren
[not found] ` <50327897.5030601-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-20 17:54 ` Mark Brown
2012-08-20 17:54 ` Mark Brown
[not found] ` <20120820175410.GI26991-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-08-20 18:08 ` Stephen Warren
2012-08-20 18:08 ` Stephen Warren
[not found] ` <50327D2D.6000509-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-20 18:14 ` Mark Brown
2012-08-20 18:14 ` Mark Brown
[not found] ` <20120820181432.GJ26991-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-08-20 18:37 ` Stephen Warren
2012-08-20 18:37 ` Stephen Warren
[not found] ` <503283F8.4070808-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-22 19:07 ` Mark Brown
2012-08-22 19:07 ` Mark Brown
[not found] ` <20120822190714.GF7995-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-08-24 18:53 ` Stephen Warren
2012-08-24 18:53 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502EA1AC.4090205@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.