All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Cong Meng <mc@linux.vnet.ibm.com>
Cc: stefanha@linux.vnet.ibm.com, zwanp@cn.ibm.com,
	linuxram@us.ibm.com, qemu-devel@nongnu.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-scsi spec: add per-LUN parameter query
Date: Mon, 20 Aug 2012 15:18:30 +0200	[thread overview]
Message-ID: <50323926.8000205@redhat.com> (raw)
In-Reply-To: <1345453404-15244-1-git-send-email-mc@linux.vnet.ibm.com>

Il 20/08/2012 11:03, Cong Meng ha scritto:
> Each virtio scsi HBA has global request queue limits. But the passthrough
> LUNs (scsi-generic) come from different host HBAs may have different request
> queue limits. If the guest sends commands that exceed the host limits, the
> commands will be rejected by host HAB. 
> 
> To address this issue, this patch adds a per-LUN parameter query via the control
> queue, and defines some parameter query types. The driver can query and set the
> needed per-LUN parameters if the device enables this feature.
> 
> Signed-off-by: Cong Meng <mc@linux.vnet.ibm.com>
> --
>  virtio-spec.lyx |  218 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 218 insertions(+), 0 deletions(-)

Do you have kernel and QEMU patches for this?  That would help me
evaluate whether the interface is the correct one.

In any case, I'd rather have a single command returning all three values
(VIRTIO_SCSI_T_LUN_QUEUE_PARAMS), since it's unlikely that you need just
one.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Cong Meng <mc@linux.vnet.ibm.com>
Cc: stefanha@linux.vnet.ibm.com, zwanp@cn.ibm.com,
	Rusty Russell <rusty@rustcorp.com.au>,
	linuxram@us.ibm.com, qemu-devel@nongnu.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query
Date: Mon, 20 Aug 2012 15:18:30 +0200	[thread overview]
Message-ID: <50323926.8000205@redhat.com> (raw)
In-Reply-To: <1345453404-15244-1-git-send-email-mc@linux.vnet.ibm.com>

Il 20/08/2012 11:03, Cong Meng ha scritto:
> Each virtio scsi HBA has global request queue limits. But the passthrough
> LUNs (scsi-generic) come from different host HBAs may have different request
> queue limits. If the guest sends commands that exceed the host limits, the
> commands will be rejected by host HAB. 
> 
> To address this issue, this patch adds a per-LUN parameter query via the control
> queue, and defines some parameter query types. The driver can query and set the
> needed per-LUN parameters if the device enables this feature.
> 
> Signed-off-by: Cong Meng <mc@linux.vnet.ibm.com>
> --
>  virtio-spec.lyx |  218 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 218 insertions(+), 0 deletions(-)

Do you have kernel and QEMU patches for this?  That would help me
evaluate whether the interface is the correct one.

In any case, I'd rather have a single command returning all three values
(VIRTIO_SCSI_T_LUN_QUEUE_PARAMS), since it's unlikely that you need just
one.

Paolo

  reply	other threads:[~2012-08-20 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  9:03 [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query Cong Meng
2012-08-20 13:18 ` Paolo Bonzini [this message]
2012-08-20 13:18   ` Paolo Bonzini
2012-08-20 14:44   ` McPacino
2012-08-20 14:44     ` [Qemu-devel] " McPacino
2012-08-20 15:57     ` Paolo Bonzini
2012-08-20 15:57       ` [Qemu-devel] " Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2012-08-20  9:03 Cong Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50323926.8000205@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=linuxram@us.ibm.com \
    --cc=mc@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=zwanp@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.