From: Paolo Bonzini <pbonzini@redhat.com>
To: McPacino <mcpacino@gmail.com>
Cc: stefanha@linux.vnet.ibm.com, zwanp@cn.ibm.com,
linuxram@us.ibm.com, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org,
Cong Meng <mc@linux.vnet.ibm.com>
Subject: Re: [PATCH] virtio-scsi spec: add per-LUN parameter query
Date: Mon, 20 Aug 2012 17:57:28 +0200 [thread overview]
Message-ID: <50325E68.6080401@redhat.com> (raw)
In-Reply-To: <CAOKNXO7PLs8ansCf0YajruO=yX8B_FAeZ==iuYwN2mAqoOLVuQ@mail.gmail.com>
Il 20/08/2012 16:44, McPacino ha scritto:
>
> 在 2012-8-20 下午9:18，"Paolo Bonzini" <pbonzini@redhat.com
> <mailto:pbonzini@redhat.com>>写道：
>>
>> Il 20/08/2012 11:03, Cong Meng ha scritto:
>> > Each virtio scsi HBA has global request queue limits. But the
> passthrough
>> > LUNs (scsi-generic) come from different host HBAs may have different
> request
>> > queue limits. If the guest sends commands that exceed the host
> limits, the
>> > commands will be rejected by host HAB.
>> >
>> > To address this issue, this patch adds a per-LUN parameter query via
> the control
>> > queue, and defines some parameter query types. The driver can query
> and set the
>> > needed per-LUN parameters if the device enables this feature.
>> >
>> > Signed-off-by: Cong Meng <mc@linux.vnet.ibm.com
> <mailto:mc@linux.vnet.ibm.com>>
>> > --
>> > virtio-spec.lyx | 218
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> > 1 files changed, 218 insertions(+), 0 deletions(-)
>>
>> Do you have kernel and QEMU patches for this? That would help me
>> evaluate whether the interface is the correct one.
>>
> yes,I have a demo. I will post it after I polish it tomorrow.
>
>> In any case, I'd rather have a single command returning all three values
>> (VIRTIO_SCSI_T_LUN_QUEUE_PARAMS), since it's unlikely that you need just
>> one.
>
> I intend to seperat them one by one. As there is opportunity that other
> new parameters are needed for other features.
You can use more feature bits to dictate which bits are present.
Paolo
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: McPacino <mcpacino@gmail.com>
Cc: stefanha@linux.vnet.ibm.com, zwanp@cn.ibm.com,
linuxram@us.ibm.com, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org,
Cong Meng <mc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query
Date: Mon, 20 Aug 2012 17:57:28 +0200 [thread overview]
Message-ID: <50325E68.6080401@redhat.com> (raw)
In-Reply-To: <CAOKNXO7PLs8ansCf0YajruO=yX8B_FAeZ==iuYwN2mAqoOLVuQ@mail.gmail.com>
Il 20/08/2012 16:44, McPacino ha scritto:
>
> 在 2012-8-20 下午9:18，"Paolo Bonzini" <pbonzini@redhat.com
> <mailto:pbonzini@redhat.com>>写道：
>>
>> Il 20/08/2012 11:03, Cong Meng ha scritto:
>> > Each virtio scsi HBA has global request queue limits. But the
> passthrough
>> > LUNs (scsi-generic) come from different host HBAs may have different
> request
>> > queue limits. If the guest sends commands that exceed the host
> limits, the
>> > commands will be rejected by host HAB.
>> >
>> > To address this issue, this patch adds a per-LUN parameter query via
> the control
>> > queue, and defines some parameter query types. The driver can query
> and set the
>> > needed per-LUN parameters if the device enables this feature.
>> >
>> > Signed-off-by: Cong Meng <mc@linux.vnet.ibm.com
> <mailto:mc@linux.vnet.ibm.com>>
>> > --
>> > virtio-spec.lyx | 218
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> > 1 files changed, 218 insertions(+), 0 deletions(-)
>>
>> Do you have kernel and QEMU patches for this? That would help me
>> evaluate whether the interface is the correct one.
>>
> yes,I have a demo. I will post it after I polish it tomorrow.
>
>> In any case, I'd rather have a single command returning all three values
>> (VIRTIO_SCSI_T_LUN_QUEUE_PARAMS), since it's unlikely that you need just
>> one.
>
> I intend to seperat them one by one. As there is opportunity that other
> new parameters are needed for other features.
You can use more feature bits to dictate which bits are present.
Paolo
next prev parent reply other threads:[~2012-08-20 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 9:03 [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query Cong Meng
2012-08-20 13:18 ` Paolo Bonzini
2012-08-20 13:18 ` [Qemu-devel] " Paolo Bonzini
2012-08-20 14:44 ` McPacino
2012-08-20 14:44 ` [Qemu-devel] " McPacino
2012-08-20 15:57 ` Paolo Bonzini [this message]
2012-08-20 15:57 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2012-08-20 9:03 Cong Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50325E68.6080401@redhat.com \
--to=pbonzini@redhat.com \
--cc=linuxram@us.ibm.com \
--cc=mc@linux.vnet.ibm.com \
--cc=mcpacino@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zwanp@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.