From: Avi Kivity <avi@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru,
qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com,
kraxel@redhat.com, xen-devel@lists.xensource.com,
i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com,
anthony.perard@citrix.com, lersek@redhat.com,
stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com,
Igor Mammedov <imammedo@redhat.com>,
lcapitulino@redhat.com, rth@twiddle.net, kwolf@redhat.com,
aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC] How should QEMU code handle include statements
Date: Tue, 21 Aug 2012 13:19:05 +0300 [thread overview]
Message-ID: <50336099.3040206@redhat.com> (raw)
In-Reply-To: <50329903.8000608@weilnetz.de>
On 08/20/2012 11:07 PM, Stefan Weil wrote:
> While I personally prefer (1) and used it for my first contributions,
> QEMU introduced qemu-common.h. I had the impression that from then on
> QEMU preferred strategy (2). Obviously not everybody shares that
> impression.
>
> Which strategy / rule do we want to use for QEMU code?
(1).
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru,
qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com,
kraxel@redhat.com, xen-devel@lists.xensource.com,
i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com,
anthony.perard@citrix.com, lersek@redhat.com,
stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com,
Igor Mammedov <imammedo@redhat.com>,
lcapitulino@redhat.com, rth@twiddle.net, kwolf@redhat.com,
aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com,
afaerber@suse.de
Subject: Re: [RFC] How should QEMU code handle include statements
Date: Tue, 21 Aug 2012 13:19:05 +0300 [thread overview]
Message-ID: <50336099.3040206@redhat.com> (raw)
In-Reply-To: <50329903.8000608@weilnetz.de>
On 08/20/2012 11:07 PM, Stefan Weil wrote:
> While I personally prefer (1) and used it for my first contributions,
> QEMU introduced qemu-common.h. I had the impression that from then on
> QEMU preferred strategy (2). Obviously not everybody shares that
> impression.
>
> Which strategy / rule do we want to use for QEMU code?
(1).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-21 10:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 23:39 [Qemu-devel] [PATCH 0/5 v2] cpu: make a child of DeviceState Igor Mammedov
2012-08-19 23:39 ` Igor Mammedov
2012-08-19 23:39 ` [Qemu-devel] [PATCH 1/5] move qemu_irq typedef out of cpu-common.h Igor Mammedov
2012-08-19 23:39 ` Igor Mammedov
2012-08-20 4:41 ` [Qemu-devel] " Stefan Weil
2012-08-20 4:41 ` Stefan Weil
2012-08-20 11:13 ` [Qemu-devel] " Igor Mammedov
2012-08-20 11:13 ` Igor Mammedov
2012-08-20 19:46 ` [Qemu-devel] " Blue Swirl
2012-08-20 19:46 ` Blue Swirl
2012-08-20 20:14 ` [Qemu-devel] " Anthony Liguori
2012-08-20 20:14 ` Anthony Liguori
2012-08-19 23:39 ` [Qemu-devel] [PATCH 2/5] qdev: split up header so it can be used in cpu.h Igor Mammedov
2012-08-19 23:39 ` Igor Mammedov
2012-08-19 23:39 ` [Qemu-devel] [PATCH 3/5] qapi-types.h doesn't really need to include qemu-common.h Igor Mammedov
2012-08-19 23:39 ` Igor Mammedov
2012-08-20 15:22 ` [Qemu-devel] " Luiz Capitulino
2012-08-20 15:22 ` Luiz Capitulino
2012-08-20 19:59 ` [Qemu-devel] " Igor Mammedov
2012-08-20 19:59 ` Igor Mammedov
2012-08-19 23:39 ` [Qemu-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h Igor Mammedov
2012-08-19 23:39 ` Igor Mammedov
2012-08-20 15:28 ` [Qemu-devel] " Luiz Capitulino
2012-08-20 15:28 ` Luiz Capitulino
2012-08-20 20:00 ` [Qemu-devel] [Xen-devel] " Igor Mammedov
2012-08-20 20:00 ` Igor Mammedov
2012-08-19 23:39 ` [Qemu-devel] [PATCH 5/5] make CPU a child of DeviceState Igor Mammedov
2012-08-19 23:39 ` Igor Mammedov
2012-08-21 14:03 ` [Qemu-devel] " Eduardo Habkost
2012-08-21 14:03 ` Eduardo Habkost
2012-08-20 4:52 ` [Qemu-devel] [PATCH 0/5 v2] cpu: make " Stefan Weil
2012-08-20 4:52 ` Stefan Weil
2012-08-20 11:47 ` [Qemu-devel] " Igor Mammedov
2012-08-20 11:47 ` Igor Mammedov
2012-08-20 20:07 ` [Qemu-devel] [RFC] How should QEMU code handle include statements (was: Re: [PATCH 0/5 v2] cpu: make a child of DeviceState) Stefan Weil
2012-08-20 20:07 ` Stefan Weil
2012-08-21 10:19 ` Avi Kivity [this message]
2012-08-21 10:19 ` [RFC] How should QEMU code handle include statements Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50336099.3040206@redhat.com \
--to=avi@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=i.mitsyanko@samsung.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@linux.vnet.ibm.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.