Re: [Qemu-devel] [PATCH 0/5 v2] cpu: make a child of DeviceState

[Stefan Weil <sw@weilnetz.de>]

Am 20.08.2012 01:39, schrieb Igor Mammedov:
> this is th 3rd approach to make CPU a child of DeviceState
> for both kinds of targets *-user and *-softmmu. It seems
> with current state of qemu it doesn't take too much effort
> to make it compile. Please check if it doesn't break
> something on other targets/archs/hosts than i386.
>
> what's tested:
>    - compile tested building all targets on FC17x64 host.
>    - briefly tested i386 user and softmmu targets
>
> Anthony Liguori (1):
>    qdev: split up header so it can be used in cpu.h
>
> Igor Mammedov (4):
>    move qemu_irq typedef out of cpu-common.h
>    qapi-types.h doesn't really need to include qemu-common.h
>    cleanup error.h, included qapi-types.h aready has stdbool.h
>    make CPU a child of DeviceState
>
>   error.h               |    1 -
>   hw/arm-misc.h         |    1 +
>   hw/bt.h               |    2 +
>   hw/devices.h          |    2 +
>   hw/irq.h              |    2 +
>   hw/mc146818rtc.c      |    1 +
>   hw/omap.h             |    1 +
>   hw/qdev-addr.c        |    1 +
>   hw/qdev-core.h        |  240 ++++++++++++++++++++++++++++++++
>   hw/qdev-monitor.h     |   16 ++
>   hw/qdev-properties.c  |    1 +
>   hw/qdev-properties.h  |  128 +++++++++++++++++
>   hw/qdev.c             |    1 +
>   hw/qdev.h             |  371 +------------------------------------------------
>   hw/soc_dma.h          |    1 +
>   hw/xen.h              |    1 +
>   include/qemu/cpu.h    |    6 +-
>   qemu-common.h         |    1 -
>   scripts/qapi-types.py |    2 +-
>   sysemu.h              |    1 +
>   20 files changed, 407 insertions(+), 373 deletions(-)
>   create mode 100644 hw/qdev-core.h
>   create mode 100644 hw/qdev-monitor.h
>   create mode 100644 hw/qdev-properties.h
>

I'd prefer if you could keep the following simple pattern:

* Start includes in *.c files with config.h (optionally)
   and qemu-common.h.

* Don't include standard include files which are already
   included in qemu-common.h

* Don't include qemu-common.h in *.h files.

Regards,

Stefan Weil