From: Jan Kiszka <jan.kiszka@siemens.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "patches@linaro.org" <patches@linaro.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()
Date: Tue, 21 Aug 2012 12:27:51 +0200 [thread overview]
Message-ID: <503362A7.4010106@siemens.com> (raw)
In-Reply-To: <CAFEAcA-FSMPJOPx6Y_WkuNWQ3D2_6giQ+ExLqqmoRECBrev2_A@mail.gmail.com>
On 2012-08-21 10:25, Peter Maydell wrote:
> On 21 August 2012 09:19, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2012-08-15 13:08, Peter Maydell wrote:
>>> Move the init of the irqchip_inject_ioctl field of KVMState out of
>>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq()
>>> can be used even when no irqchip is created (for architectures
>>> that support async interrupt notification even without an in
>>> kernel irqchip).
>
>> As it's not yet merged, some late comment: irqchip_inject_ioctl should
>> be renamed as well. irq_inject_ioctl?
>
> If we're changing it anyway, IIRC Avi didn't like the term "inject"
> here?
Then irq_set_ioctl.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "patches@linaro.org" <patches@linaro.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()
Date: Tue, 21 Aug 2012 12:27:51 +0200 [thread overview]
Message-ID: <503362A7.4010106@siemens.com> (raw)
In-Reply-To: <CAFEAcA-FSMPJOPx6Y_WkuNWQ3D2_6giQ+ExLqqmoRECBrev2_A@mail.gmail.com>
On 2012-08-21 10:25, Peter Maydell wrote:
> On 21 August 2012 09:19, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2012-08-15 13:08, Peter Maydell wrote:
>>> Move the init of the irqchip_inject_ioctl field of KVMState out of
>>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq()
>>> can be used even when no irqchip is created (for architectures
>>> that support async interrupt notification even without an in
>>> kernel irqchip).
>
>> As it's not yet merged, some late comment: irqchip_inject_ioctl should
>> be renamed as well. irq_inject_ioctl?
>
> If we're changing it anyway, IIRC Avi didn't like the term "inject"
> here?
Then irq_set_ioctl.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-08-21 10:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 11:08 [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() Peter Maydell
2012-08-15 11:08 ` [Qemu-devel] " Peter Maydell
2012-08-15 18:34 ` Marcelo Tosatti
2012-08-15 18:34 ` Marcelo Tosatti
2012-08-21 8:19 ` Jan Kiszka
2012-08-21 8:19 ` [Qemu-devel] " Jan Kiszka
2012-08-21 8:25 ` Peter Maydell
2012-08-21 8:25 ` [Qemu-devel] " Peter Maydell
2012-08-21 10:27 ` Jan Kiszka [this message]
2012-08-21 10:27 ` Jan Kiszka
2012-08-23 9:13 ` Marcelo Tosatti
2012-08-23 9:13 ` [Qemu-devel] " Marcelo Tosatti
2012-08-23 14:13 ` Peter Maydell
2012-08-23 14:13 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503362A7.4010106@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.