All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@dlhnet.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>, Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop
Date: Wed, 22 Aug 2012 14:52:10 +0200	[thread overview]
Message-ID: <5034D5FA.70906@dlhnet.de> (raw)
In-Reply-To: <CAJSP0QVv5HMVOp6tibSbRshRd-rPo0azGR61t02ffrdGxqZpkg@mail.gmail.com>

On 08/21/12 10:23, Stefan Hajnoczi wrote:
> On Tue, Aug 21, 2012 at 8:21 AM, Jan Kiszka<jan.kiszka@siemens.com>  wrote:
>> On 2012-08-19 11:42, Avi Kivity wrote:
>>> On 08/17/2012 06:04 PM, Jan Kiszka wrote:
>>>>>> Can anyone imagine that such a barrier may actually be required? If it
>>>>>> is currently possible that env->stop is evaluated before we called into
>>>>>> sigtimedwait in qemu_kvm_eat_signals, then we could actually eat the
>>>>>> signal without properly processing its reason (stop).
>>>> Should not be required (TM): Both signal eating / stop checking and stop
>>>> setting / signal generation happens under the BQL, thus the ordering
>>>> must not make a difference here.
>>> Agree.
>>>
>>>
>>>> Don't see where we could lose a signal. Maybe due to a subtle memory
>>>> corruption that sets thread_kicked to non-zero, preventing the kicking
>>>> this way.
>>> Cannot be ruled out, yet too much of a coincidence.
>>>
>>> Could be a kernel bug (either in kvm or elsewhere), we've had several
>>> before in this area.
>>>
>>> Is this reproducible?
>> Not for me. Peter only hit it very rarely, Peter obviously more easily.
> I have only hit this once and was not able to reproduce it.
For me it was very reproducible, but my issue was fixed by:

http://www.mail-archive.com/kvm@vger.kernel.org/msg70908.html

Never seen this since then,
Peter

> Stefan

WARNING: multiple messages have this Message-ID (diff)
From: Peter Lieven <pl@dlhnet.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>, Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop
Date: Wed, 22 Aug 2012 14:52:10 +0200	[thread overview]
Message-ID: <5034D5FA.70906@dlhnet.de> (raw)
In-Reply-To: <CAJSP0QVv5HMVOp6tibSbRshRd-rPo0azGR61t02ffrdGxqZpkg@mail.gmail.com>

On 08/21/12 10:23, Stefan Hajnoczi wrote:
> On Tue, Aug 21, 2012 at 8:21 AM, Jan Kiszka<jan.kiszka@siemens.com>  wrote:
>> On 2012-08-19 11:42, Avi Kivity wrote:
>>> On 08/17/2012 06:04 PM, Jan Kiszka wrote:
>>>>>> Can anyone imagine that such a barrier may actually be required? If it
>>>>>> is currently possible that env->stop is evaluated before we called into
>>>>>> sigtimedwait in qemu_kvm_eat_signals, then we could actually eat the
>>>>>> signal without properly processing its reason (stop).
>>>> Should not be required (TM): Both signal eating / stop checking and stop
>>>> setting / signal generation happens under the BQL, thus the ordering
>>>> must not make a difference here.
>>> Agree.
>>>
>>>
>>>> Don't see where we could lose a signal. Maybe due to a subtle memory
>>>> corruption that sets thread_kicked to non-zero, preventing the kicking
>>>> this way.
>>> Cannot be ruled out, yet too much of a coincidence.
>>>
>>> Could be a kernel bug (either in kvm or elsewhere), we've had several
>>> before in this area.
>>>
>>> Is this reproducible?
>> Not for me. Peter only hit it very rarely, Peter obviously more easily.
> I have only hit this once and was not able to reproduce it.
For me it was very reproducible, but my issue was fixed by:

http://www.mail-archive.com/kvm@vger.kernel.org/msg70908.html

Never seen this since then,
Peter

> Stefan

  reply	other threads:[~2012-08-22 12:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 13:05 qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop Peter Lieven
2012-06-28 13:25 ` Jan Kiszka
2012-06-28 15:02   ` Peter Lieven
2012-06-28 15:22     ` Jan Kiszka
2012-06-28 16:29       ` Peter Lieven
2012-06-28 16:32         ` Avi Kivity
2012-06-28 19:27           ` Peter Lieven
2012-07-01  8:19             ` Avi Kivity
2012-07-01  8:19               ` [Qemu-devel] " Avi Kivity
2012-07-01 19:18               ` Peter Lieven
2012-07-01 19:18                 ` [Qemu-devel] " Peter Lieven
2012-07-02  7:05                 ` Jan Kiszka
2012-07-02  7:05                   ` [Qemu-devel] " Jan Kiszka
2012-07-02  8:12                   ` Peter Lieven
2012-07-02  8:12                     ` [Qemu-devel] " Peter Lieven
2012-08-06 15:11 ` Stefan Hajnoczi
2012-08-06 15:11   ` [Qemu-devel] " Stefan Hajnoczi
2012-08-17 13:11   ` Jan Kiszka
2012-08-17 13:11     ` [Qemu-devel] " Jan Kiszka
2012-08-17 14:36     ` Jan Kiszka
2012-08-17 14:36       ` [Qemu-devel] " Jan Kiszka
2012-08-17 14:41       ` Jan Kiszka
2012-08-17 14:41         ` [Qemu-devel] " Jan Kiszka
2012-08-17 15:04         ` Jan Kiszka
2012-08-17 15:04           ` [Qemu-devel] " Jan Kiszka
2012-08-19  9:42           ` Avi Kivity
2012-08-19  9:42             ` [Qemu-devel] " Avi Kivity
2012-08-21  7:21             ` Jan Kiszka
2012-08-21  7:21               ` [Qemu-devel] " Jan Kiszka
2012-08-21  8:23               ` Stefan Hajnoczi
2012-08-21  8:23                 ` [Qemu-devel] " Stefan Hajnoczi
2012-08-22 12:52                 ` Peter Lieven [this message]
2012-08-22 12:52                   ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5034D5FA.70906@dlhnet.de \
    --to=pl@dlhnet.de \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.